Skip to content

Commit 485a5b4

Browse files
UCT-768: Sorted errors by lines
1 parent 32ddd98 commit 485a5b4

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

src/com/magento/idea/magento2uct/execution/GenerateUctReportCommand.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import com.magento.idea.magento2uct.inspections.UctProblemsHolder;
3333
import com.magento.idea.magento2uct.packages.SupportedIssue;
3434
import com.magento.idea.magento2uct.settings.UctSettingsService;
35+
import com.magento.idea.magento2uct.util.inspection.SortDescriptorResultsUtil;
3536
import java.nio.file.Paths;
3637
import org.jetbrains.annotations.NotNull;
3738
import org.jetbrains.annotations.Nullable;
@@ -129,7 +130,9 @@ public void execute() {
129130
}
130131

131132
for (final ProblemDescriptor descriptor
132-
: fileProblemsHolder.getResults()) {
133+
: SortDescriptorResultsUtil.sort(
134+
fileProblemsHolder.getResults()
135+
)) {
133136
final Integer code = fileProblemsHolder.getErrorCodeForDescriptor(
134137
descriptor
135138
);
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
/*
2+
* Copyright © Magento, Inc. All rights reserved.
3+
* See COPYING.txt for license details.
4+
*/
5+
6+
package com.magento.idea.magento2uct.util.inspection;
7+
8+
import com.intellij.codeInspection.ProblemDescriptor;
9+
import java.util.Comparator;
10+
import java.util.LinkedList;
11+
import java.util.List;
12+
13+
public final class SortDescriptorResultsUtil {
14+
15+
private SortDescriptorResultsUtil() {
16+
}
17+
18+
/**
19+
* Get problems sorted by its lines.
20+
*
21+
* @param problems List[ProblemDescriptor]
22+
*
23+
* @return List[ProblemDescriptor]
24+
*/
25+
public static List<ProblemDescriptor> sort(final List<ProblemDescriptor> problems) {
26+
if (problems.isEmpty()) {
27+
return problems;
28+
}
29+
problems.sort(Comparator.comparingInt(ProblemDescriptor::getLineNumber));
30+
31+
return new LinkedList<>(problems);
32+
}
33+
}

0 commit comments

Comments
 (0)