Merge pull request #211 from magento/190-cover-module-xml-generator-by-test

Covered module.xml generator by test

Author: Vitaliy

testData/actions/generation/generator/ModuleXmlGenerator/generateFileInRoot/module.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0"?>
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
+    <module name="Test_Module"/>
+</config>

testData/actions/generation/generator/ModuleXmlGenerator/generateModuleFile/module.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0"?>
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
+    <module name="Test_Module"/>
+</config>

tests/com/magento/idea/magento2plugin/actions/generation/generator/BaseGeneratorTestCase.java

@@ -4,9 +4,11 @@
  */
 package com.magento.idea.magento2plugin.actions.generation.generator;
 
+import com.intellij.psi.PsiDirectory;
 import com.intellij.psi.PsiFile;
 import com.magento.idea.magento2plugin.BaseProjectTestCase;
-import java.io.File;
+import com.magento.idea.magento2plugin.magento.packages.File;
+import com.magento.idea.magento2plugin.project.util.GetProjectBasePath;
 
 abstract public class BaseGeneratorTestCase extends BaseProjectTestCase {
     private static final String testDataFolderPath = "testData" + File.separator + "actions" + File.separator;
@@ -32,4 +34,10 @@ protected void assertGeneratedFileIsCorrect(
         assertEquals(expectedFile.getText(), resultFile.getText());
         assertEquals(expectedFile.getName(), resultFile.getName());
     }
+
+    protected PsiDirectory getProjectDirectory() {
+        return myFixture.getPsiManager().findDirectory(
+            GetProjectBasePath.execute(myFixture.getProject())
+        );
+    }
 }

tests/com/magento/idea/magento2plugin/actions/generation/generator/ModuleXmlGeneratorTest.java

@@ -0,0 +1,61 @@
+/*
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+package com.magento.idea.magento2plugin.actions.generation.generator;
+
+import com.intellij.openapi.project.Project;
+import com.intellij.psi.PsiDirectory;
+import com.intellij.psi.PsiFile;
+import com.magento.idea.magento2plugin.actions.generation.data.ModuleXmlData;
+import com.magento.idea.magento2plugin.magento.files.ModuleXml;
+import com.magento.idea.magento2plugin.magento.packages.File;
+import com.magento.idea.magento2plugin.magento.packages.Package;
+
+public class ModuleXmlGeneratorTest extends BaseGeneratorTestCase {
+
+    public void testGenerateModuleFile() {
+        String filePath = this.getFixturePath(ModuleXml.FILE_NAME);
+        PsiFile expectedFile = myFixture.configureByFile(filePath);
+        PsiDirectory projectDir = getProjectDirectory();
+
+        Project project = myFixture.getProject();
+        ModuleXmlData moduleXmlData = new ModuleXmlData(
+            "Test",
+            "Module",
+            projectDir,
+            true
+        );
+        ModuleXmlGenerator moduleXmlGenerator = new ModuleXmlGenerator(moduleXmlData, project);
+        PsiFile moduleXml = moduleXmlGenerator.generate("test");
+
+        assertGeneratedFileIsCorrect(
+            expectedFile,
+            projectDir.getVirtualFile().getPath() +
+                "/Test/Module" + File.separator + Package.MODULE_BASE_AREA_DIR,
+            moduleXml
+        );
+    }
+
+    public void testGenerateFileInRoot() {
+        String filePath = this.getFixturePath(ModuleXml.FILE_NAME);
+        PsiFile expectedFile = myFixture.configureByFile(filePath);
+        PsiDirectory projectDir = getProjectDirectory();
+
+        Project project = myFixture.getProject();
+        ModuleXmlData moduleXmlData = new ModuleXmlData(
+            "Test",
+            "Module",
+            projectDir,
+            false
+        );
+        ModuleXmlGenerator moduleXmlGenerator = new ModuleXmlGenerator(moduleXmlData, project);
+        PsiFile moduleXml = moduleXmlGenerator.generate("test");
+
+        assertGeneratedFileIsCorrect(
+            expectedFile,
+            projectDir.getVirtualFile().getPath() + File.separator + Package.MODULE_BASE_AREA_DIR,
+            moduleXml
+        );
+    }
+}