Fixed override class by a preference action update

Vitaliy Boyko · Vitaliy Boyko · commit 78ebc5aa1c14 · 2020-04-06T20:42:18.000+03:00
diff --git a/src/com/magento/idea/magento2plugin/actions/generation/OverrideClassByAPreferenceAction.java b/src/com/magento/idea/magento2plugin/actions/generation/OverrideClassByAPreferenceAction.java
@@ -37,15 +37,14 @@ public void update(AnActionEvent event) {
             PsiFile psiFile = pair.getFirst();
             PhpClass phpClass = pair.getSecond();
             targetClass = phpClass;
-            if (!(psiFile instanceof PhpFile) && phpClass != null) {
+            if (psiFile instanceof PhpFile && phpClass != null) {
+                this.setStatus(event, true);
+            } else  {
                 this.setStatus(event, false);
-                return;
             }
         } else {
             this.setStatus(event, false);
-            return;
         }
-        this.setStatus(event, true);
     }
 
     private void setStatus(AnActionEvent event, boolean status) {

Original file line number	Diff line number	Diff line change
`@@ -37,15 +37,14 @@ public void update(AnActionEvent event) {`
`37`	`37`	`PsiFile psiFile = pair.getFirst();`
`38`	`38`	`PhpClass phpClass = pair.getSecond();`
`39`	`39`	`targetClass = phpClass;`
`40`		`- if (!(psiFile instanceof PhpFile) && phpClass != null) {`
	`40`	`+ if (psiFile instanceof PhpFile && phpClass != null) {`
	`41`	`+ this.setStatus(event, true);`
	`42`	`+ } else {`
`41`	`43`	`this.setStatus(event, false);`
`42`		`- return;`
`43`	`44`	`}`
`44`	`45`	`} else {`
`45`	`46`	`this.setStatus(event, false);`
`46`		`- return;`
`47`	`47`	`}`
`48`		`- this.setStatus(event, true);`
`49`	`48`	`}`
`50`	`49`
`51`	`50`	`private void setStatus(AnActionEvent event, boolean status) {`