Fix for CreateAPluginAction accessible from the wrong context

Vitaliy Boyko · Vitaliy Boyko · commit 872153c51cb9 · 2020-04-28T15:33:50.000+03:00
diff --git a/src/com/magento/idea/magento2plugin/actions/generation/CreateAPluginAction.java b/src/com/magento/idea/magento2plugin/actions/generation/CreateAPluginAction.java
@@ -45,18 +45,19 @@ public void update(AnActionEvent event) {
             PsiFile psiFile = pair.getFirst();
             PhpClass phpClass = pair.getSecond();
             if (phpClass == null || psiFile == null) {
+                this.setStatus(event, false);
                 return;
             }
             targetClass = phpClass;
             if (!(psiFile instanceof PhpFile) || phpClass.isFinal() || this.targetMethod == null) {
                 this.setStatus(event, false);
                 return;
             }
-        } else {
-            this.setStatus(event, false);
+            this.setStatus(event, true);
             return;
         }
-        this.setStatus(event, true);
+
+        this.setStatus(event, false);
     }
 
     private void setStatus(AnActionEvent event, boolean status) {

Original file line number	Diff line number	Diff line change
`@@ -45,18 +45,19 @@ public void update(AnActionEvent event) {`
`45`	`45`	`PsiFile psiFile = pair.getFirst();`
`46`	`46`	`PhpClass phpClass = pair.getSecond();`
`47`	`47`	`if (phpClass == null \|\| psiFile == null) {`
	`48`	`+ this.setStatus(event, false);`
`48`	`49`	`return;`
`49`	`50`	`}`
`50`	`51`	`targetClass = phpClass;`
`51`	`52`	`if (!(psiFile instanceof PhpFile) \|\| phpClass.isFinal() \|\| this.targetMethod == null) {`
`52`	`53`	`this.setStatus(event, false);`
`53`	`54`	`return;`
`54`	`55`	`}`
`55`		`- } else {`
`56`		`- this.setStatus(event, false);`
	`56`	`+ this.setStatus(event, true);`
`57`	`57`	`return;`
`58`	`58`	`}`
`59`		`- this.setStatus(event, true);`
	`59`	`+`
	`60`	`+ this.setStatus(event, false);`
`60`	`61`	`}`
`61`	`62`
`62`	`63`	`private void setStatus(AnActionEvent event, boolean status) {`