Skip to content

Commit 9f74bd6

Browse files
committed
Update test scripts for Windows compatibility
Replaced browser kill command to target Edge instead of Firefox for Windows. Adjusted GitHub Actions workflow to upload test artifacts on failure specifically for Windows environments.
1 parent c4b17eb commit 9f74bd6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/gradle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,12 @@ jobs:
6767
./gradlew test
6868
6969
- name: Capture Test Artifacts on Failure
70-
if: failure() && matrix.os == 'ubuntu-latest'
70+
if: failure() && matrix.os == 'windows-latest'
7171
run: tar -cvzf video.tgz ./video
7272
shell: bash
7373

7474
- name: Upload Test Video Artifact
75-
if: failure() && matrix.os == 'ubuntu-latest'
75+
if: failure() && matrix.os == 'windows-latest'
7676
uses: actions/upload-artifact@v4
7777
with:
7878
name: latest-test-video

src/test/kotlin/com/magento/idea/magento2plugin/actions/content/MarkDirectoryAsMagentoRootTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ class MarkDirectoryAsMagentoRootTest {
184184
try {
185185
if (os.contains("win")) {
186186
// For Windows: Close common browsers like Chrome, Firefox, etc.
187-
Runtime.getRuntime().exec("taskkill /F /IM firefox.exe")
187+
Runtime.getRuntime().exec("taskkill /F /IM edge.exe")
188188
} else if (os.contains("mac")) {
189189
// For macOS: Kill browsers using `pkill`
190190
Runtime.getRuntime().exec("killall -9 safari")

0 commit comments

Comments
 (0)