Skip to content

Commit a1dfac9

Browse files
coderimuscoderimus
committed
Remove comments
2 parents aec07d4 + 99a277d commit a1dfac9

File tree

74 files changed

+1280
-176
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+1280
-176
lines changed

‎.github/workflows/gradlepublishalpha.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ name: Publish Plugin alpha version
55
on:
66
push:
77
branches:
8-
- 1.0.1-develop
8+
- master
99

1010
jobs:
1111
build:

‎resources/magento2/common.properties

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,32 @@
1+
common.magento.installationPath=Magento Installation Path
12
common.package.name=Package Name
23
common.module.name=Module Name
3-
common.module.version=Module Version
4-
common.module.license=Module's license(s)
5-
common.module.dependencies=Module Dependencies
6-
common.module.description=Module Description
4+
common.module.version=Version
5+
common.module.license=License(s)
6+
common.dependencies=Dependencies
77
common.ok=OK
88
common.cancel=Cancel
99
common.error=Error
1010
common.module.target=Target Module
1111
common.area.target=Target Area
12+
common.name=Name
13+
common.className=Class Name
14+
common.directoryPath=Directory Path
15+
common.methodType=Method Type
16+
common.sortOrder=Sort Order
17+
common.hint.viewModelPreferredVersusBlock=Please consider creating a view model instead of a block if possible for your use case.
18+
common.schedule=Schedule
19+
common.schedule.fixed=Fixed
20+
common.schedule.configurable=Configurable
21+
common.schedule.everyMinute=Every Minute
22+
common.schedule.atMidnight=At midnight
23+
common.schedule.custom=Custom
24+
common.cronGroup=Cron Group
25+
common.directory=Directory
26+
common.notAvailable=N/A
27+
common.classInheritance=Inherit Class
28+
common.license.proprietary=Proprietary
29+
common.description=Description
1230
common.cli.class.name=Class Name
1331
common.cli.cli.description=CLI Description
1432
common.cli.cli.name=CLI Name

‎src/com/magento/idea/magento2plugin/actions/generation/CreateAPluginAction.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,20 @@ public void update(AnActionEvent event) {
4444
Pair<PsiFile, PhpClass> pair = this.findPhpClass(event);
4545
PsiFile psiFile = pair.getFirst();
4646
PhpClass phpClass = pair.getSecond();
47-
if (phpClass == null || psiFile == null) {
48-
return;
49-
}
50-
targetClass = phpClass;
51-
if (!(psiFile instanceof PhpFile) || phpClass.isFinal() || this.targetMethod == null) {
47+
if ((phpClass == null || psiFile == null)
48+
|| !(psiFile instanceof PhpFile)
49+
|| phpClass.isFinal()
50+
|| this.targetMethod == null
51+
) {
5252
this.setStatus(event, false);
5353
return;
5454
}
55-
} else {
56-
this.setStatus(event, false);
55+
targetClass = phpClass;
56+
this.setStatus(event, true);
5757
return;
5858
}
59-
this.setStatus(event, true);
59+
60+
this.setStatus(event, false);
6061
}
6162

6263
private void setStatus(AnActionEvent event, boolean status) {

‎src/com/magento/idea/magento2plugin/actions/generation/data/ObserverFileData.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/*
2+
* Copyright © Magento, Inc. All rights reserved.
3+
* See COPYING.txt for license details.
4+
*/
15
package com.magento.idea.magento2plugin.actions.generation.data;
26

37
public class ObserverFileData {
@@ -13,14 +17,14 @@ public ObserverFileData(
1317
String observerClassName,
1418
String observerModule,
1519
String targetEvent,
16-
String pluginClassFqn,
20+
String observerClassFqn,
1721
String namespace
1822
) {
1923
this.observerDirectory = observerDirectory;
2024
this.observerClassName = observerClassName;
2125
this.observerModule = observerModule;
2226
this.targetEvent = targetEvent;
23-
this.observerClassFqn = pluginClassFqn;
27+
this.observerClassFqn = observerClassFqn;
2428
this.namespace = namespace;
2529
}
2630

‎src/com/magento/idea/magento2plugin/actions/generation/dialog/CreateAPluginDialog.form

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
<grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
7878
</constraints>
7979
<properties>
80-
<text value="Plugin Class Name"/>
80+
<text resource-bundle="magento2/common" key="common.className"/>
8181
</properties>
8282
</component>
8383
<component id="e4858" class="javax.swing.JTextField" binding="pluginDirectory">
@@ -100,15 +100,15 @@
100100
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
101101
</constraints>
102102
<properties>
103-
<text value="Plugin Directory Path"/>
103+
<text resource-bundle="magento2/common" key="common.directoryPath"/>
104104
</properties>
105105
</component>
106106
<component id="14359" class="javax.swing.JLabel" binding="pluginNameLabel">
107107
<constraints>
108108
<grid row="2" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
109109
</constraints>
110110
<properties>
111-
<text value="Plugin Name"/>
111+
<text resource-bundle="magento2/common" key="common.name"/>
112112
</properties>
113113
</component>
114114
<component id="9431c" class="javax.swing.JTextField" binding="pluginName">
@@ -143,7 +143,7 @@
143143
<grid row="3" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
144144
</constraints>
145145
<properties>
146-
<text value="Sort Order"/>
146+
<text resource-bundle="magento2/common" key="common.sortOrder"/>
147147
</properties>
148148
</component>
149149
</children>
@@ -171,7 +171,7 @@
171171
<grid row="4" column="0" row-span="1" col-span="2" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
172172
</constraints>
173173
<properties>
174-
<text value="Plugin Method Type"/>
174+
<text resource-bundle="magento2/common" key="common.methodType"/>
175175
</properties>
176176
</component>
177177
<component id="bd654" class="com.magento.idea.magento2plugin.ui.FilteredComboBox" binding="pluginModule" custom-create="true">

‎src/com/magento/idea/magento2plugin/actions/generation/dialog/CreateAnObserverDialog.form

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
6767
</constraints>
6868
<properties>
69-
<text value="Observer Class Name"/>
69+
<text resource-bundle="magento2/common" key="common.className"/>
7070
</properties>
7171
</component>
7272
<component id="e4858" class="javax.swing.JTextField" binding="observerDirectory">
@@ -89,15 +89,15 @@
8989
<grid row="2" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
9090
</constraints>
9191
<properties>
92-
<text value="Observer Directory Path"/>
92+
<text resource-bundle="magento2/common" key="common.directoryPath"/>
9393
</properties>
9494
</component>
9595
<component id="54e7b" class="javax.swing.JLabel" binding="observerNameLabel">
9696
<constraints>
9797
<grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
9898
</constraints>
9999
<properties>
100-
<text value="Observer Name"/>
100+
<text resource-bundle="magento2/common" key="common.name"/>
101101
</properties>
102102
</component>
103103
<component id="ad3ba" class="javax.swing.JTextField" binding="observerClassName">
@@ -155,4 +155,7 @@
155155
</component>
156156
</children>
157157
</grid>
158+
<inspectionSuppressions>
159+
<suppress inspection="InvalidPropertyKeyForm" id="3fe2b"/>
160+
</inspectionSuppressions>
158161
</form>

‎src/com/magento/idea/magento2plugin/actions/generation/dialog/NewBlockDialog.form

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<grid id="cbd77" binding="contentPanel" layout-manager="GridLayoutManager" row-count="3" column-count="1" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
44
<margin top="10" left="10" bottom="10" right="10"/>
55
<constraints>
6-
<xy x="48" y="54" width="419" height="297"/>
6+
<xy x="48" y="54" width="455" height="297"/>
77
</constraints>
88
<properties>
99
<name value="New Magento2 Block.."/>
@@ -69,7 +69,7 @@
6969
</constraints>
7070
<properties>
7171
<labelFor value="2d9cc"/>
72-
<text value="Block Name"/>
72+
<text resource-bundle="magento2/common" key="common.name"/>
7373
</properties>
7474
</component>
7575
<component id="2d9cc" class="javax.swing.JTextField" binding="blockName">
@@ -100,7 +100,7 @@
100100
</constraints>
101101
<properties>
102102
<labelFor value="fdc52"/>
103-
<text value="Block Directory"/>
103+
<text resource-bundle="magento2/common" key="common.directory"/>
104104
</properties>
105105
<clientProperties>
106106
<html.disable class="java.lang.Boolean" value="true"/>
@@ -127,7 +127,7 @@
127127
<enabled value="false"/>
128128
<margin top="0" left="0" bottom="0" right="0"/>
129129
<opaque value="false"/>
130-
<text value="Please consider creating a view model instead of a block if possible for your use case."/>
130+
<text resource-bundle="magento2/common" key="common.hint.viewModelPreferredVersusBlock"/>
131131
</properties>
132132
<clientProperties>
133133
<html.disable class="java.lang.Boolean" value="false"/>
@@ -148,4 +148,7 @@
148148
<member id="e6153"/>
149149
</group>
150150
</buttonGroups>
151+
<inspectionSuppressions>
152+
<suppress inspection="InvalidPropertyKeyForm" id="be25f"/>
153+
</inspectionSuppressions>
151154
</form>

‎src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronjobDialog.form

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
</constraints>
7474
<properties>
7575
<labelFor value="fe780"/>
76-
<text value="Cronjob ClassName"/>
76+
<text resource-bundle="magento2/common" key="common.className"/>
7777
</properties>
7878
</component>
7979
<component id="e23f7" class="javax.swing.JLabel">
@@ -82,15 +82,15 @@
8282
</constraints>
8383
<properties>
8484
<labelFor value="b2d70"/>
85-
<text value="Cronjob Directory"/>
85+
<text resource-bundle="magento2/common" key="common.directory"/>
8686
</properties>
8787
</component>
8888
<component id="462a3" class="javax.swing.JLabel">
8989
<constraints>
9090
<grid row="4" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
9191
</constraints>
9292
<properties>
93-
<text value="Schedule"/>
93+
<text resource-bundle="magento2/common" key="common.schedule"/>
9494
</properties>
9595
</component>
9696
<vspacer id="efb9e">
@@ -104,15 +104,15 @@
104104
</constraints>
105105
<properties>
106106
<selected value="true"/>
107-
<text value="Fixed"/>
107+
<text resource-bundle="magento2/common" key="common.schedule.fixed"/>
108108
</properties>
109109
</component>
110110
<component id="649c" class="javax.swing.JRadioButton" binding="configurableScheduleRadioButton">
111111
<constraints>
112112
<grid row="4" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
113113
</constraints>
114114
<properties>
115-
<text value="Configurable"/>
115+
<text resource-bundle="magento2/common" key="common.schedule.configurable"/>
116116
</properties>
117117
</component>
118118
<grid id="832a2" binding="fixedSchedulePanel" layout-manager="GridLayoutManager" row-count="2" column-count="3" same-size-horizontally="false" same-size-vertically="false" hgap="-1" vgap="-1">
@@ -131,15 +131,15 @@
131131
</constraints>
132132
<properties>
133133
<selected value="true"/>
134-
<text value="Every Minute"/>
134+
<text resource-bundle="magento2/common" key="common.schedule.everyMinute"/>
135135
</properties>
136136
</component>
137137
<component id="daa" class="javax.swing.JRadioButton" binding="customScheduleRadioButton">
138138
<constraints>
139139
<grid row="0" column="2" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
140140
</constraints>
141141
<properties>
142-
<text value="Custom"/>
142+
<text resource-bundle="magento2/common" key="common.schedule.custom"/>
143143
</properties>
144144
</component>
145145
<component id="5be88" class="javax.swing.JTextField" binding="cronjobScheduleField">
@@ -159,7 +159,7 @@
159159
<grid row="0" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
160160
</constraints>
161161
<properties>
162-
<text value="At midnight"/>
162+
<text resource-bundle="magento2/common" key="common.schedule.atMidnight"/>
163163
</properties>
164164
</component>
165165
</children>
@@ -197,7 +197,7 @@
197197
<grid row="3" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
198198
</constraints>
199199
<properties>
200-
<text value="Cron Group"/>
200+
<text resource-bundle="magento2/common" key="common.cronGroup"/>
201201
</properties>
202202
</component>
203203
<component id="77d9d" class="com.magento.idea.magento2plugin.ui.FilteredComboBox" binding="cronGroupComboBox" custom-create="true">
@@ -213,7 +213,7 @@
213213
<grid row="2" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
214214
</constraints>
215215
<properties>
216-
<text value="Cronjob Name"/>
216+
<text resource-bundle="magento2/common" key="common.name"/>
217217
</properties>
218218
</component>
219219
<component id="555fd" class="javax.swing.JTextField" binding="cronjobNameField">
@@ -250,4 +250,7 @@
250250
<member id="ee2c9"/>
251251
</group>
252252
</buttonGroups>
253+
<inspectionSuppressions>
254+
<suppress inspection="InvalidPropertyKeyForm" id="e23f7"/>
255+
</inspectionSuppressions>
253256
</form>

‎src/com/magento/idea/magento2plugin/actions/generation/dialog/NewGraphQlResolverDialog.form

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</constraints>
2929
<properties>
3030
<labelFor value="2d9cc"/>
31-
<text value="GraphQL Resolver Name"/>
31+
<text resource-bundle="magento2/common" key="common.className"/>
3232
</properties>
3333
</component>
3434
<component id="1f03b" class="javax.swing.JTextField" binding="graphQlResolverClassName">
@@ -59,7 +59,7 @@
5959
</constraints>
6060
<properties>
6161
<labelFor value="fdc52"/>
62-
<text value="GraphQL Resolver Directory"/>
62+
<text resource-bundle="magento2/common" key="common.directory"/>
6363
</properties>
6464
<clientProperties>
6565
<html.disable class="java.lang.Boolean" value="true"/>

‎src/com/magento/idea/magento2plugin/actions/generation/dialog/NewModuleDialog.form

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
<grid row="5" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="9" fill="0" indent="0" use-parent-layout="false"/>
178178
</constraints>
179179
<properties>
180-
<text resource-bundle="magento2/common" key="common.module.dependencies"/>
180+
<text resource-bundle="magento2/common" key="common.dependencies"/>
181181
<toolTipText value=""/>
182182
</properties>
183183
</component>
@@ -208,7 +208,7 @@
208208
</grid>
209209
</constraints>
210210
<properties>
211-
<text value="N/A"/>
211+
<text resource-bundle="magento2/common" key="common.notAvailable"/>
212212
<toolTipText value=""/>
213213
</properties>
214214
<clientProperties>
@@ -220,7 +220,7 @@
220220
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
221221
</constraints>
222222
<properties>
223-
<text resource-bundle="magento2/common" key="common.module.description"/>
223+
<text resource-bundle="magento2/common" key="common.description"/>
224224
<toolTipText value=""/>
225225
</properties>
226226
</component>

0 commit comments

Comments
 (0)