Skip to content

Commit acce71f

Browse files
author
Vitaliy Boyko
committed
Fixed PMD 2
1 parent f123e1c commit acce71f

File tree

4 files changed

+2
-9
lines changed

4 files changed

+2
-9
lines changed

src/com/magento/idea/magento2plugin/actions/generation/data/DataProviderDeclarationData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class DataProviderDeclarationData {
1111
private final String virtualTypeName;
1212
private final String collectionFqn;
1313
private final String dataSource;
14-
private String tableName;
14+
private final String tableName;
1515

1616
/**
1717
* Data Provider XML declaration data.

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewUiComponentFormDialog.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import com.magento.idea.magento2plugin.magento.files.ControllerFrontendPhp;
4545
import com.magento.idea.magento2plugin.magento.files.FormButtonBlockPhp;
4646
import com.magento.idea.magento2plugin.magento.files.ModuleMenuXml;
47-
import com.magento.idea.magento2plugin.magento.files.UiComponentDataProviderPhp;
4847
import com.magento.idea.magento2plugin.magento.packages.Areas;
4948
import com.magento.idea.magento2plugin.magento.packages.File;
5049
import com.magento.idea.magento2plugin.magento.packages.HttpMethod;

src/com/magento/idea/magento2plugin/actions/generation/generator/AclXmlGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public PsiFile generate(final String actionName) {
114114

115115
addSubTagsQueue.add(targetTag);
116116
childParentRelationMap.put(targetTag, parent);
117-
CommitXmlFileUtil.execute(aclXml, addSubTagsQueue, childParentRelationMap);;
117+
CommitXmlFileUtil.execute(aclXml, addSubTagsQueue, childParentRelationMap);
118118
FileBasedIndex.getInstance().requestReindex(aclXml.getVirtualFile());
119119

120120
return aclXml;

src/com/magento/idea/magento2plugin/actions/generation/generator/UiComponentDataProviderGenerator.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,4 @@ private String getDataProviderFqn() {
152152
uiComponentGridDataProviderData.getName()
153153
);
154154
}
155-
156-
private String getNameFromFqn(final String fqn) {
157-
final String[] fqnArray = fqn.split("\\\\");
158-
159-
return fqnArray[fqnArray.length - 1];
160-
}
161155
}

0 commit comments

Comments
 (0)