Skip to content

Commit c55976f

Browse files
Added logic fon validation only visible fields on the dialog
1 parent c85b4cc commit c55976f

File tree

1 file changed

+27
-1
lines changed

1 file changed

+27
-1
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/AbstractDialog.java

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ protected void clearValidationHighlighting() {
119119
* @return List[FieldValidationData]
120120
*/
121121
protected List<FieldValidationData> getFieldsToValidate() {
122-
return new LinkedList<>(fieldsValidationsList);
122+
return getAvailableForFiltering(fieldsValidationsList);
123123
}
124124

125125
/**
@@ -235,4 +235,30 @@ private int getParentTabPaneForComponent(final @NotNull Container component) {
235235

236236
return getParentTabPaneForComponent(parent);
237237
}
238+
239+
/**
240+
* Returns only available for validation field.
241+
*
242+
* @param allFields List
243+
*
244+
* @return List
245+
*/
246+
private List<FieldValidationData> getAvailableForFiltering(
247+
final @NotNull List<FieldValidationData> allFields
248+
) {
249+
final List<FieldValidationData> result = new LinkedList<>();
250+
251+
for (final FieldValidationData fieldValidationData : allFields) {
252+
final JComponent component = ExtractComponentFromFieldUtil.extract(
253+
fieldValidationData.getField(),
254+
this
255+
);
256+
257+
if (component != null && component.isVisible() && component.getParent().isVisible()) {
258+
result.add(fieldValidationData);
259+
}
260+
}
261+
262+
return result;
263+
}
238264
}

0 commit comments

Comments
 (0)