Skip to content

Commit c8ae8f9

Browse files
committed
Review adjustents
1 parent 9fd7d9d commit c8ae8f9

File tree

4 files changed

+19
-20
lines changed

4 files changed

+19
-20
lines changed

resources/magento2/common.properties

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
common.package.name=Package Name
2+
common.module.name=Module Name
3+
common.module.version=Module Version
4+
common.module.license=Module's license(s)
5+
common.module.dependencies=Module Dependencies
6+
common.module.description=Module Description
7+
common.ok=OK
8+
common.cancel=Cancel

resources/magento2/new_module_generation_dialog.properties

Lines changed: 0 additions & 10 deletions
This file was deleted.

resources/magento2/validation.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ validator.class.alreadyDeclared={0} already declared in the target module
1212
validator.magentoVersionInvalid=Please specify valid Magento version or use 'any' keyword as default
1313
validator.class.targetClassNotFound=Target class is not found. Check the di.xml file
1414
validator.moduleNameIsTheSameAsPackage=Module name must be different from the package name
15+
validator.mustNotBeEmptyShouldContainLettersOrNumbers=Must not be empty, should contain letters or numbers

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewModuleDialog.form

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@
3636
<grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
3737
</constraints>
3838
<properties>
39-
<text resource-bundle="magento2/new_module_generation_dialog" key="ok"/>
39+
<text resource-bundle="magento2/common" key="common.ok"/>
4040
</properties>
4141
</component>
4242
<component id="5723f" class="javax.swing.JButton" binding="buttonCancel">
4343
<constraints>
4444
<grid row="0" column="1" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="0" fill="1" indent="0" use-parent-layout="false"/>
4545
</constraints>
4646
<properties>
47-
<text resource-bundle="magento2/new_module_generation_dialog" key="cancel"/>
47+
<text resource-bundle="magento2/common" key="common.cancel"/>
4848
</properties>
4949
</component>
5050
</children>
@@ -69,7 +69,7 @@
6969
</constraints>
7070
<properties>
7171
<text value=""/>
72-
<toolTipText resource-bundle="magento2/new_module_generation_dialog" key="must.not.be.empty.should.contain.letters.or.numbers"/>
72+
<toolTipText resource-bundle="magento2/validation" key="validator.mustNotBeEmptyShouldContainLettersOrNumbers"/>
7373
</properties>
7474
<clientProperties>
7575
<html.disable class="java.lang.Boolean" value="true"/>
@@ -80,7 +80,7 @@
8080
<grid row="0" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
8181
</constraints>
8282
<properties>
83-
<text resource-bundle="magento2/new_module_generation_dialog" key="package.name"/>
83+
<text resource-bundle="magento2/common" key="common.package.name"/>
8484
<toolTipText value=""/>
8585
<verifyInputWhenFocusTarget value="false"/>
8686
</properties>
@@ -93,7 +93,7 @@
9393
</constraints>
9494
<properties>
9595
<text value=""/>
96-
<toolTipText resource-bundle="magento2/new_module_generation_dialog" key="must.not.be.empty.should.contain.letters.or.numbers"/>
96+
<toolTipText resource-bundle="magento2/validation" key="validator.mustNotBeEmptyShouldContainLettersOrNumbers"/>
9797
</properties>
9898
<clientProperties>
9999
<html.disable class="java.lang.Boolean" value="true"/>
@@ -104,7 +104,7 @@
104104
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
105105
</constraints>
106106
<properties>
107-
<text resource-bundle="magento2/new_module_generation_dialog" key="module.name"/>
107+
<text resource-bundle="magento2/common" key="common.module.name"/>
108108
<toolTipText value=""/>
109109
</properties>
110110
</component>
@@ -126,7 +126,7 @@
126126
<grid row="2" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
127127
</constraints>
128128
<properties>
129-
<text resource-bundle="magento2/new_module_generation_dialog" key="module.version"/>
129+
<text resource-bundle="magento2/common" key="common.module.version"/>
130130
<toolTipText value=""/>
131131
</properties>
132132
</component>
@@ -135,7 +135,7 @@
135135
<grid row="3" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="9" fill="0" indent="0" use-parent-layout="false"/>
136136
</constraints>
137137
<properties>
138-
<text resource-bundle="magento2/new_module_generation_dialog" key="module.license"/>
138+
<text resource-bundle="magento2/common" key="common.module.license"/>
139139
<toolTipText value=""/>
140140
</properties>
141141
</component>
@@ -177,7 +177,7 @@
177177
<grid row="5" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="9" fill="0" indent="0" use-parent-layout="false"/>
178178
</constraints>
179179
<properties>
180-
<text resource-bundle="magento2/new_module_generation_dialog" key="module.dependencies"/>
180+
<text resource-bundle="magento2/common" key="common.module.dependencies"/>
181181
<toolTipText value=""/>
182182
</properties>
183183
</component>
@@ -220,7 +220,7 @@
220220
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
221221
</constraints>
222222
<properties>
223-
<text resource-bundle="magento2/new_module_generation_dialog" key="module.description"/>
223+
<text resource-bundle="magento2/common" key="common.module.description"/>
224224
<toolTipText value=""/>
225225
</properties>
226226
</component>

0 commit comments

Comments
 (0)