#issue-178 Fixed static tests

Author: Sergiy Zhovnir

src/com/magento/idea/magento2plugin/actions/generation/NewCronGroupAction.java

@@ -29,19 +29,20 @@ public NewCronGroupAction() {
 
     @Override
     public void actionPerformed(final AnActionEvent event) {
-        DataContext dataContext = event.getDataContext();
-        IdeView view = LangDataKeys.IDE_VIEW.getData(dataContext);
+        final DataContext dataContext = event.getDataContext();
+        final IdeView view = LangDataKeys.IDE_VIEW.getData(dataContext);
 
         if (view == null) {
             return;
         }
 
-        Project project = CommonDataKeys.PROJECT.getData(dataContext);
+        final Project project = CommonDataKeys.PROJECT.getData(dataContext);
         if (project == null) {
             return;
         }
 
-        PsiDirectory directory = view.getOrChooseDirectory();
+        final PsiDirectory directory = view.getOrChooseDirectory();
+
         if (directory == null) {
             return;
         }

src/com/magento/idea/magento2plugin/actions/generation/data/CronGroupXmlData.java

@@ -5,6 +5,7 @@
 
 package com.magento.idea.magento2plugin.actions.generation.data;
 
+@SuppressWarnings({"PMD.DataClass"})
 public class CronGroupXmlData {
     private final String module;
     private final String groupName;
@@ -30,15 +31,15 @@ public class CronGroupXmlData {
      * @param useSeparateProcess Use separate process
      */
     public CronGroupXmlData(
-            String module,
-            String groupName,
-            Integer scheduleGenerateEvery,
-            Integer scheduleAheadFor,
-            Integer scheduleLifetime,
-            Integer historyCleanupEvery,
-            Integer historySuccessLifetime,
-            Integer historyFailureLifetime,
-            Integer useSeparateProcess
+            final String module,
+            final String groupName,
+            final Integer scheduleGenerateEvery,
+            final Integer scheduleAheadFor,
+            final Integer scheduleLifetime,
+            final Integer historyCleanupEvery,
+            final Integer historySuccessLifetime,
+            final Integer historyFailureLifetime,
+            final Integer useSeparateProcess
     ) {
         this.module = module;
         this.groupName = groupName;

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronGroupDialog.java

@@ -27,6 +27,10 @@
 import javax.swing.JTextField;
 import javax.swing.KeyStroke;
 
+@SuppressWarnings({
+        "PMD.TooManyFields",
+        "PMD.TooManyMethods"
+})
 public class NewCronGroupDialog extends AbstractDialog {
     private final NewCronGroupValidator validator;
     private final String moduleName;
@@ -57,6 +61,7 @@ public class NewCronGroupDialog extends AbstractDialog {
      * @param directory Directory
      */
     public NewCronGroupDialog(final Project project, final PsiDirectory directory) {
+        super();
         this.project = project;
         setContentPane(contentPanel);
         setModal(true);
@@ -90,6 +95,7 @@ public void windowClosing(final WindowEvent event) {
      *
      * @return CronGroupXmlData
      */
+    @SuppressWarnings({"PMD.NullAssignment"})
     public CronGroupXmlData getCronGroupXmlData() {
         return new CronGroupXmlData(
                 getModuleName(),
@@ -249,6 +255,7 @@ private Boolean getAddUseSeparateProcess() {
         return addUseSeparateProcess.isSelected();
     }
 
+    @SuppressWarnings({"PMD.UnusedPrivateMethod"})
     private void createUIComponents() {
         this.useSeparateProcess = new FilteredComboBox(getYesNoOptions());
     }

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/NewCronGroupValidator.java

@@ -12,10 +12,10 @@
 import com.magento.idea.magento2plugin.util.RegExUtil;
 import javax.swing.JOptionPane;
 
-@SuppressWarnings({"PMD.OnlyOneReturn"})
+@SuppressWarnings({"PMD.OnlyOneReturn", "PMD.NonThreadSafeSingleton"})
 public class NewCronGroupValidator {
     private static final String MUST_NOT_BE_NEGATIVE = "validator.mustNotBeNegative";
-    private static NewCronGroupValidator INSTANCE;
+    private static NewCronGroupValidator instance;
     private final ValidatorBundle validatorBundle;
     private final CommonBundle commonBundle;
 
@@ -25,11 +25,11 @@ public class NewCronGroupValidator {
      * @return NewCronGroupValidator
      */
     public static NewCronGroupValidator getInstance() {
-        if (null == INSTANCE) {
-            INSTANCE = new NewCronGroupValidator();
+        if (null == instance) {
+            instance = new NewCronGroupValidator();
         }
 
-        return INSTANCE;
+        return instance;
     }
 
     /**

src/com/magento/idea/magento2plugin/actions/generation/generator/ModuleCronGroupXmlGenerator.java

@@ -29,6 +29,7 @@
 import java.util.Properties;
 import javax.swing.JOptionPane;
 
+@SuppressWarnings({"PMD.AvoidPrintStackTrace"})
 public class ModuleCronGroupXmlGenerator extends FileGenerator {
     private final CronGroupXmlData cronGroupXmlData;
     private final Project project;
@@ -101,8 +102,8 @@ public PsiFile generate(final String actionName) {
                 );
 
                 textBuf.append(cronjobRegistrationTemplate);
-            } catch (final IOException e) {
-                e.printStackTrace();
+            } catch (final IOException exception) {
+                exception.printStackTrace();
                 return;
             }
 
@@ -144,7 +145,7 @@ public PsiFile generate(final String actionName) {
                 }
 
                 document.insertString(insertPos, textBuf);
-                int endPos = insertPos + textBuf.length() + 1;
+                final int endPos = insertPos + textBuf.length() + 1;
 
                 this.codeStyleManager.reformatText(cronGroupXmlFile, insertPos, endPos);
                 this.psiDocumentManager.commitDocument(document);
@@ -220,13 +221,13 @@ protected void fillAttributes(final Properties attributes) {
      * @return XmlTag
      */
     private XmlTag getCronGroupTag(final XmlFile cronGroupXmlFile, final String cronGroupName) {
-        Collection<XmlAttributeValue> attributes = XmlPsiTreeUtil.findAttributeValueElements(
+        final Collection<XmlAttributeValue> attributes = XmlPsiTreeUtil.findAttributeValueElements(
                 cronGroupXmlFile,
                 CrontabXmlTemplate.CRON_GROUP_TAG,
                 CrontabXmlTemplate.CRON_GROUP_NAME_ATTRIBUTE
         );
 
-        for (XmlAttributeValue cronGroupIdAttribute: attributes) {
+        for (final XmlAttributeValue cronGroupIdAttribute: attributes) {
             if (!cronGroupIdAttribute.getValue().equals(cronGroupName)) {
                 continue;
             }

src/com/magento/idea/magento2plugin/actions/generation/generator/util/FindOrCreateCronGroupXml.java

@@ -49,7 +49,7 @@ public PsiFile execute(final String actionName, final String moduleName) {
 
         fileDirectories.add(Package.moduleBaseAreaDir);
 
-        for (String fileDirectory: fileDirectories) {
+        for (final String fileDirectory: fileDirectories) {
             parentDirectory = this.directoryGenerator.findOrCreateSubdirectory(
                     parentDirectory,
                     fileDirectory