Skip to content

Commit cfa711e

Browse files
author
Vitaliy Boyko
committed
Merge branch '5.1.0-develop' of github.com:magento/magento2-phpstorm-plugin into 5.0.1-forwardport
# Conflicts: # CHANGELOG.md # README.md # build.gradle # resources/META-INF/plugin.xml # src/com/magento/idea/magento2plugin/stubs/indexes/PluginIndex.java
2 parents 051d406 + ed2a70c commit cfa711e

File tree

25 files changed

+116
-60
lines changed

25 files changed

+116
-60
lines changed

.gitattributes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,5 @@
1515
*.PDF diff=astextplain
1616
*.rtf diff=astextplain
1717
*.RTF diff=astextplain
18+
19+
*.ft text eol=lf

.github/workflows/gradle.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Grant execute permission for gradlew
3131
run: chmod +x gradlew
3232
- name: Run automated tests
33-
run: ./gradlew test -i --no-daemon
33+
run: ./gradlew test --no-daemon
3434

3535
build-windows:
3636
runs-on: windows-latest
@@ -54,7 +54,7 @@ jobs:
5454
- name: Grant execute permission for gradlew
5555
run: chmod +x gradlew
5656
- name: Run automated tests
57-
run: ./gradlew test -i --no-daemon
57+
run: ./gradlew test --no-daemon
5858

5959
build-macos:
6060
runs-on: macos-latest
@@ -78,7 +78,7 @@ jobs:
7878
- name: Grant execute permission for gradlew
7979
run: chmod +x gradlew
8080
- name: Run automated tests
81-
run: ./gradlew test -i --no-daemon
81+
run: ./gradlew test --no-daemon
8282

8383
static-tests:
8484
runs-on: ubuntu-latest
@@ -104,11 +104,11 @@ jobs:
104104
- id: file_changes
105105
uses: trilom/[email protected]
106106
- name: Run Code Style Check
107-
run: ./gradlew checkstyleCI -i --no-daemon
107+
run: ./gradlew checkstyleCI --no-daemon
108108
env:
109109
MODIFIED_FILES: ${{ steps.file_changes.outputs.files}}
110110
ACTIONS_STEP_DEBUG: true
111111
- name: Run PMD Quality Check
112-
run: ./gradlew pmdCI -i --no-daemon
112+
run: ./gradlew pmdCI --no-daemon
113113
env:
114114
MODIFIED_FILES: ${{ steps.file_changes.outputs.files}}

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
66

7+
## 5.1.0
8+
79
## 5.0.1
810

911
### Fixed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242

4343
1. Check out this repository
4444
1. Open a folder with the project in the IntelliJ Ultimate using the `open` action button.
45-
1. Make sure that you on the latest develop branch (e.g `5.0.1-develop`)
45+
1. Make sure that you on the latest develop branch (e.g `5.1.0-develop`)
4646
1. Right-click on the `build.gradle` file, choose "Import Gradle project" (if this is not exist look for "Build module '<root folder name>'") (you need to have Gradle plugin installed)
4747
1. Check if the right SDK version is used for the project.
4848
- Current Java version for the project is **java 11**, so you should additionally download **SDK 11** and choose it in the module settings: `Right click by the project root > Open Module Settings > Project Settings > Project > Project SDK`

build.gradle

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@
44
*/
55

66
plugins {
7-
id 'org.jetbrains.intellij' version '1.1.4'
7+
id 'org.jetbrains.intellij' version '1.11.0'
88
id 'checkstyle'
99
id 'pmd'
10-
id 'org.jetbrains.changelog' version '1.2.1'
10+
id 'org.jetbrains.changelog' version '2.0.0'
1111
}
1212

1313
repositories {
1414
mavenCentral()
1515
}
1616

1717
group 'com.magento.idea'
18-
version '5.0.1'
18+
version '5.1.0'
1919

2020
apply plugin: 'org.jetbrains.intellij'
2121
apply plugin: 'java'
2222
apply plugin: 'idea'
2323
apply plugin: 'groovy'
2424
apply plugin: 'org.jetbrains.changelog'
2525

26-
def phpPluginVersion = System.getProperty("phpPluginVersion", "212.5080.55")
27-
def ideaVersion = System.getProperty("ideaVersion", "2021.2.1")
26+
def phpPluginVersion = System.getProperty("phpPluginVersion", "222.3739.45")
27+
def ideaVersion = System.getProperty("ideaVersion", "2022.2.1")
2828
def javaVersion = 11
2929

3030
sourceCompatibility = javaVersion
@@ -41,7 +41,7 @@ intellij {
4141
'properties',
4242
'CSS',
4343
'JavaScriptLanguage',
44-
'com.intellij.lang.jsgraphql:3.1.2',
44+
'com.intellij.lang.jsgraphql:3.2.1',
4545
'platform-images',
4646
'copyright'
4747
]
@@ -105,12 +105,26 @@ idea {
105105
}
106106

107107
dependencies {
108-
testImplementation 'junit:junit:4.13'
109-
implementation 'com.googlecode.json-simple:json-simple:1.1.1'
108+
implementation(
109+
"org.junit.jupiter:junit-jupiter:5.8.2",
110+
"com.googlecode.json-simple:json-simple:1.1.1"
111+
)
112+
testRuntimeOnly('org.junit.vintage:junit-vintage-engine:5.9.0')
113+
testRuntimeOnly("org.junit.platform:junit-platform-launcher:1.9.0")
114+
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.9.00")
110115
}
111116

112117
test {
113-
useJUnit()
114-
118+
useJUnitPlatform {
119+
includeEngines("junit-vintage")
120+
}
121+
dependsOn cleanTest
122+
testLogging.showStandardStreams = true
123+
testLogging {
124+
lifecycle {
125+
events "skipped", "failed", "standard_error", "standard_out"
126+
exceptionFormat "short"
127+
}
128+
}
115129
maxHeapSize = '1G'
116130
}

resources/META-INF/plugin.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<idea-plugin require-restart="true">
88
<id>com.magento.idea.magento2plugin</id>
99
<name>Magento PhpStorm</name>
10-
<version>5.0.1</version>
10+
<version>5.1.0</version>
1111
<vendor url="https://github.com/magento/magento2-phpstorm-plugin">Magento Inc.</vendor>
1212

1313
<description><![CDATA[
@@ -24,7 +24,7 @@
2424
</change-notes>
2525

2626
<!-- please see http://confluence.jetbrains.com/display/IDEADEV/Build+Number+Ranges for description -->
27-
<idea-version since-build="212.5080.55"/>
27+
<idea-version since-build="222.3739.54"/>
2828

2929
<!-- please see http://confluence.jetbrains.com/display/IDEADEV/Plugin+Compatibility+with+IntelliJ+Platform+Products
3030
on how to target different products -->

src/com/magento/idea/magento2plugin/generation/php/MagentoTemplatesFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import com.intellij.ide.util.projectWizard.WizardContext;
99
import com.intellij.platform.ProjectTemplate;
1010
import com.intellij.platform.ProjectTemplatesFactory;
11-
import com.jetbrains.php.config.generation.PhpEmptyTemplatesFactory;
11+
import com.jetbrains.php.config.generation.PhpEmptyProjectGenerator;
1212
import icons.PhpIcons;
1313
import javax.swing.Icon;
1414
import org.jetbrains.annotations.NotNull;
@@ -18,7 +18,7 @@ public class MagentoTemplatesFactory extends ProjectTemplatesFactory {
1818

1919
@NotNull
2020
public String[] getGroups() {
21-
return new String[]{PhpEmptyTemplatesFactory.PHP_PROJECT_TEMPLATE_GROUP};
21+
return new String[]{PhpEmptyProjectGenerator.PHP_PROJECT_TEMPLATE_GROUP};
2222
}
2323

2424
public Icon getGroupIcon(final String group) {

testData/actions/generation/generator/DeleteEntityGenerator/generateDeleteEntityFile/Delete.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function execute()
5858
try {
5959
$this->deleteByIdCommand->execute($entityId);
6060
$this->messageManager->addSuccessMessage(__('You have successfully deleted Company entity'));
61-
} catch (CouldNotDeleteException | NoSuchEntityException $exception) {
61+
} catch (CouldNotDeleteException|NoSuchEntityException $exception) {
6262
$this->messageManager->addErrorMessage($exception->getMessage());
6363
}
6464

testData/actions/generation/generator/WebApiInterfaceGenerator/withObjectTypesAndPhpDocComments/SimpleServiceTwoInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public function execute(SimpleModelTwo $simpleModelTwo, ?string $param2 = null):
2222

2323
/**
2424
* TODO: need to describe this method.
25-
*
25+
* @return void
2626
*/
2727
public function fetch(): void;
2828
}

testData/actions/generation/generator/WebApiInterfaceGenerator/withPrimitiveTypes/SimpleServiceInterface.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ interface SimpleServiceInterface
1313
* TODO: need to describe this method.
1414
* @param int $param1
1515
* @param string $param2
16+
* @return void
1617
*/
1718
public function execute(int $param1, string $param2);
1819
}

0 commit comments

Comments
 (0)