Static checks fixes

Author: bohdan-harniuk

src/com/magento/idea/magento2plugin/actions/generation/data/DeleteEntityControllerFileData.java

@@ -13,7 +13,7 @@ public class DeleteEntityControllerFileData {
     private final String moduleName;
     private final String acl;
     private final String entityId;
-    private final boolean isDeleteCommandHasInterface;
+    private final boolean deleteCommandHasInterface;
 
     /**
      * Controller Delete file constructor.
@@ -34,7 +34,7 @@ public DeleteEntityControllerFileData(
         this.moduleName = moduleName;
         this.acl = acl;
         this.entityId = entityId;
-        this.isDeleteCommandHasInterface = isDeleteCommandHasInterface;
+        this.deleteCommandHasInterface = isDeleteCommandHasInterface;
     }
 
     /**
@@ -79,6 +79,6 @@ public String getEntityId() {
      * @return boolean
      */
     public boolean isDeleteCommandHasInterface() {
-        return isDeleteCommandHasInterface;
+        return deleteCommandHasInterface;
     }
 }

src/com/magento/idea/magento2plugin/actions/generation/data/SaveEntityControllerFileData.java

@@ -16,7 +16,7 @@ public class SaveEntityControllerFileData {
     private final String dtoName;
     private final String dtoInterfaceName;
     private final boolean dtoWithInterface;
-    private final boolean isSaveCommandHasInterface;
+    private final boolean saveCommandHasInterface;
 
     /**
      * Controller save file constructor.
@@ -47,7 +47,7 @@ public SaveEntityControllerFileData(
         this.dtoName = dtoName;
         this.dtoInterfaceName = dtoInterfaceName;
         this.dtoWithInterface = isDtoWithInterface;
-        this.isSaveCommandHasInterface = isSaveCommandHasInterface;
+        this.saveCommandHasInterface = isSaveCommandHasInterface;
     }
 
     /**
@@ -119,6 +119,6 @@ public boolean isDtoWithInterface() {
      * @return boolean
      */
     public boolean isSaveCommandHasInterface() {
-        return isSaveCommandHasInterface;
+        return saveCommandHasInterface;
     }
 }

src/com/magento/idea/magento2plugin/actions/generation/data/UiComponentDataProviderData.java

@@ -11,7 +11,7 @@ public class UiComponentDataProviderData {
     private final String path;
     private final String entityName;
     private final String entityIdFieldName;
-    private final boolean isQueryHasInterface;
+    private final boolean queryHasInterface;
 
     /**
      * UiComponentGridDataProviderData constructor.
@@ -46,7 +46,7 @@ public UiComponentDataProviderData(
         this.path = path;
         this.entityName = entityName;
         this.entityIdFieldName = entityIdFieldName;
-        this.isQueryHasInterface = isQueryHasInterface;
+        this.queryHasInterface = isQueryHasInterface;
     }
 
     /**
@@ -91,6 +91,6 @@ public String getEntityIdFieldName() {
      * @return boolean
      */
     public boolean isQueryHasInterface() {
-        return isQueryHasInterface;
+        return queryHasInterface;
     }
 }

src/com/magento/idea/magento2plugin/actions/generation/data/dialog/EntityCreatorContextData.java

@@ -21,7 +21,7 @@ public class EntityCreatorContextData implements GenerationContextData {
     private final String moduleName;
     private final String actionName;
     private final boolean hasOpenFileFlag;
-    private final boolean hasWebApi;
+    private final boolean webApi;
     private final String indexViewAction;
     private final String editViewAction;
     private final String newViewAction;
@@ -80,7 +80,7 @@ public EntityCreatorContextData(
         this.moduleName = moduleName;
         this.actionName = actionName;
         this.hasOpenFileFlag = hasOpenFileFlag;
-        this.hasWebApi = hasWebApi;
+        this.webApi = hasWebApi;
         this.indexViewAction = indexViewAction;
         this.editViewAction = editViewAction;
         this.newViewAction = newViewAction;
@@ -121,7 +121,7 @@ public boolean checkIfHasOpenFileFlag() {
      * @return boolean
      */
     public boolean hasWebApi() {
-        return hasWebApi;
+        return webApi;
     }
 
     /**

src/com/magento/idea/magento2plugin/actions/generation/data/dialog/NewEntityDialogData.java

@@ -18,7 +18,7 @@ public class NewEntityDialogData implements DialogData {
     private final String tableResource;
     private final boolean adminUiComponents;
     private final boolean dtoInterface;
-    private final boolean hasWebApi;
+    private final boolean webApi;
 
     // Admin UI Components tab data.
     private final String route;
@@ -111,7 +111,7 @@ public NewEntityDialogData(
         this.tableResource = tableResource;
         this.adminUiComponents = hasAdminUiComponents;
         this.dtoInterface = hasDtoInterface;
-        this.hasWebApi = hasWebApi;
+        this.webApi = hasWebApi;
         this.route = route;
         this.formLabel = formLabel;
         this.formName = formName;
@@ -201,7 +201,7 @@ public boolean hasDtoInterface() {
      * @return boolean
      */
     public boolean hasWebApi() {
-        return hasWebApi;
+        return webApi;
     }
 
     /**

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewInterfaceForServiceDialog.java

@@ -9,20 +9,15 @@
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiDirectory;
 import com.jetbrains.php.lang.actions.PhpNamedElementNode;
-import com.jetbrains.php.lang.psi.PhpFile;
 import com.jetbrains.php.lang.psi.elements.Method;
 import com.jetbrains.php.lang.psi.elements.PhpClass;
 import com.magento.idea.magento2plugin.actions.generation.NewWebApiInterfaceAction;
-import com.magento.idea.magento2plugin.actions.generation.data.PreferenceDiXmFileData;
 import com.magento.idea.magento2plugin.actions.generation.data.php.WebApiInterfaceData;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.FieldValidation;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.RuleRegistry;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.NotEmptyRule;
 import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.PhpClassRule;
-import com.magento.idea.magento2plugin.actions.generation.generator.PreferenceDiXmlGenerator;
 import com.magento.idea.magento2plugin.actions.generation.generator.php.WebApiInterfaceGenerator;
-import com.magento.idea.magento2plugin.magento.packages.Areas;
-import com.magento.idea.magento2plugin.util.GetFirstClassOfFile;
 import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
 import com.magento.idea.magento2plugin.util.php.PhpTypeMetadataParserUtil;
 import java.awt.event.KeyEvent;
@@ -31,7 +26,6 @@
 import java.util.Arrays;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.Objects;
 import javax.swing.JButton;
 import javax.swing.JComponent;
 import javax.swing.JLabel;