Skip to content

Commit db3aa7f

Browse files
author
Vitaliy
authored
Merge pull request #285 from magento/fixed-usage-of-JavaScriptFileType
Removed usage of the JavaScriptFileType constructor
2 parents b184c8b + e314f10 commit db3aa7f

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

src/com/magento/idea/magento2plugin/completion/provider/RequireJsMappingCompletionProvider.java

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
* Copyright © Magento, Inc. All rights reserved.
33
* See COPYING.txt for license details.
44
*/
5+
56
package com.magento.idea.magento2plugin.completion.provider;
67

78
import com.intellij.codeInsight.completion.CompletionParameters;
@@ -13,27 +14,31 @@
1314
import com.intellij.util.ProcessingContext;
1415
import com.intellij.util.indexing.FileBasedIndex;
1516
import com.magento.idea.magento2plugin.stubs.indexes.js.RequireJsIndex;
16-
import org.jetbrains.annotations.NotNull;
1717
import java.util.Collection;
18+
import org.jetbrains.annotations.NotNull;
1819

1920
public class RequireJsMappingCompletionProvider extends CompletionProvider<CompletionParameters> {
2021

2122
@Override
22-
protected void addCompletions(@NotNull CompletionParameters parameters,
23-
ProcessingContext context,
24-
@NotNull CompletionResultSet result) {
25-
PsiElement position = parameters.getPosition().getOriginalElement();
23+
protected void addCompletions(
24+
final @NotNull CompletionParameters parameters,
25+
final ProcessingContext context,
26+
final @NotNull CompletionResultSet result
27+
) {
28+
final PsiElement position = parameters.getPosition().getOriginalElement();
2629
if (position == null) {
2730
return;
2831
}
29-
String prefix = result.getPrefixMatcher().getPrefix();
32+
final String prefix = result.getPrefixMatcher().getPrefix();
3033

31-
Collection<String> requireJsKeys
32-
= FileBasedIndex.getInstance().getAllKeys(RequireJsIndex.KEY, position.getProject());
34+
final Collection<String> requireJsKeys
35+
= FileBasedIndex.getInstance().getAllKeys(
36+
RequireJsIndex.KEY, position.getProject()
37+
);
3338

3439
requireJsKeys.removeIf(m -> !m.startsWith(prefix));
35-
JavaScriptFileType jsFileType = new JavaScriptFileType();
36-
for (String requireJsKey : requireJsKeys) {
40+
final JavaScriptFileType jsFileType = JavaScriptFileType.INSTANCE;
41+
for (final String requireJsKey : requireJsKeys) {
3742
result.addElement(
3843
LookupElementBuilder
3944
.create(requireJsKey)

0 commit comments

Comments
 (0)