Skip to content

Commit e571e6c

Browse files
Refactored models
1 parent 05ee9b0 commit e571e6c

File tree

2 files changed

+22
-20
lines changed

2 files changed

+22
-20
lines changed

src/com/magento/idea/magento2plugin/actions/generation/data/ProductEntityData.java

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
package com.magento.idea.magento2plugin.actions.generation.data;
77

8+
import com.magento.idea.magento2plugin.magento.packages.File;
9+
import com.magento.idea.magento2plugin.magento.packages.Package;
810
import com.magento.idea.magento2plugin.magento.packages.eav.EavEntities;
911

1012
@SuppressWarnings({"PMD.TooManyFields"})
@@ -142,16 +144,36 @@ public String getInput() {
142144

143145
@Override
144146
public String getNamespace() {
147+
if (namespace == null) {
148+
namespace = getDataPathNamespace();
149+
}
150+
145151
return namespace;
146152
}
147153

154+
private String getDataPathNamespace() {
155+
final String[] parts = moduleName.split(Package.vendorModuleNameSeparator);
156+
if (parts[0] == null || parts[1] == null || parts.length > 2) {
157+
return null;
158+
}
159+
final String directoryPart = getDirectory().replace(
160+
File.separator,
161+
Package.fqnSeparator
162+
);
163+
return parts[0] + Package.fqnSeparator + parts[1] + Package.fqnSeparator + directoryPart;
164+
}
165+
148166
@Override
149167
public String getModuleName() {
150168
return moduleName;
151169
}
152170

153171
@Override
154172
public String getDirectory() {
173+
if (directory == null) {
174+
directory = "Setup/Patch/Data";
175+
}
176+
155177
return directory;
156178
}
157179

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewEavAttributeDialog.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.Lowercase;
1818
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.NotEmptyRule;
1919
import com.magento.idea.magento2plugin.actions.generation.generator.EavAttributeSetupPatchGenerator;
20-
import com.magento.idea.magento2plugin.magento.packages.File;
21-
import com.magento.idea.magento2plugin.magento.packages.Package;
2220
import com.magento.idea.magento2plugin.magento.packages.eav.AttributeInputs;
2321
import com.magento.idea.magento2plugin.magento.packages.eav.AttributeScopes;
2422
import com.magento.idea.magento2plugin.magento.packages.eav.AttributeTypes;
@@ -223,8 +221,6 @@ private EavEntityDataInterface getEntityData() {
223221
}
224222

225223
private ProductEntityData populateProductEntityData(final ProductEntityData productEntityData) {
226-
productEntityData.setNamespace(getDataPathNamespace());
227-
productEntityData.setDirectory(getDataPathDirectory());
228224
productEntityData.setModuleName(getModuleName());
229225

230226
productEntityData.setDataPatchName(getDataPatchName());
@@ -308,26 +304,10 @@ private String getDataPatchName() {
308304
return dataPatchNameTextField.getText().trim();
309305
}
310306

311-
private String getDataPathNamespace() {
312-
final String[] parts = moduleName.split(Package.vendorModuleNameSeparator);
313-
if (parts[0] == null || parts[1] == null || parts.length > 2) {
314-
return null;
315-
}
316-
final String directoryPart = getDataPathDirectory().replace(
317-
File.separator,
318-
Package.fqnSeparator
319-
);
320-
return parts[0] + Package.fqnSeparator + parts[1] + Package.fqnSeparator + directoryPart;
321-
}
322-
323307
private String getAttributeType() {
324308
return typeComboBox.getSelectedItem().toString().trim();
325309
}
326310

327-
private String getDataPathDirectory() {
328-
return "Setup/Patch/Data";
329-
}
330-
331311
private String getModuleName() {
332312
return moduleName;
333313
}

0 commit comments

Comments
 (0)