Skip to content

Commit f75bf1f

Browse files
author
Sergiy Zhovnir
committed
Merge branch '1.0.1-develop' into issue-57-controller-generation
2 parents 09b6fa4 + 7b8eaf0 commit f75bf1f

File tree

75 files changed

+1074
-164
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

75 files changed

+1074
-164
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 0 additions & 33 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: bug
6+
assignees: ''
7+
8+
---
9+
10+
<!---
11+
Thank you for contributing to Magento.
12+
To help us process this issue we recommend that you add the following information:
13+
- Summary of the issue,
14+
- Information on your environment,
15+
- Steps to reproduce,
16+
- Expected and actual results,
17+
Fields marked with (*) are required. Please don't remove the template.
18+
-->
19+
20+
**Describe the bug** (*)
21+
22+
A clear and concise description of what the bug is.
23+
24+
**To Reproduce** (*)
25+
26+
Steps to reproduce the behavior:
27+
1. Go to '...'
28+
2. Click on '....'
29+
3. Scroll down to '....'
30+
4. See error
31+
32+
**Expected behavior** (*)
33+
34+
A clear and concise description of what you expected to happen.
35+
36+
**Screenshots**
37+
38+
If applicable, add screenshots to help explain your problem.
39+
40+
**Please complete the following information:** (*)
41+
42+
- OS: [e.g. iOS]
43+
- PhpStorm/Intellij version [e.g. 2019.3.3]
44+
- Version [e.g. 1.0.0]
45+
46+
**Additional context**
47+
48+
Add any other context about the problem here.
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
<!---
11+
Thank you for contributing to Magento.
12+
To help us process this issue we recommend that you add the following information:
13+
- Summary of the issue,
14+
- Expected and actual results,
15+
Fields marked with (*) are required. Please don't remove the template.
16+
-->
17+
18+
**Is your feature request related to a problem? Please describe.**
19+
20+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
21+
22+
**Describe the solution you'd like** (*)
23+
24+
A clear and concise description of what you want to happen.
25+
26+
**Describe alternatives you've considered**
27+
28+
A clear and concise description of any alternative solutions or features you've considered.
29+
30+
**Additional context**
31+
32+
Add any other context or screenshots about the feature request here.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,27 @@
99

1010
<!--- Please provide a general summary of the Pull Request in the Title above -->
1111

12-
### Description (*)
12+
**Description** (*)
1313
<!---
1414
Please provide a description of the changes proposed in the pull request.
1515
Letting us know what has changed and why it needed changing will help us validate this pull request.
1616
-->
1717

18-
### Fixed Issues (if relevant)
18+
**Fixed Issues (if relevant)**
1919
<!---
2020
If relevant, please provide a list of fixed issues in the format magento/magento2-phpstorm-plugin#<issue_number>.
2121
There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.
2222
-->
2323
1. magento/magento2-phpstorm-plugin#<issue_number>: Issue title
2424

25-
### Questions or comments
25+
**Questions or comments**
2626
<!---
2727
If relevant, here you can ask questions or provide comments on your pull request for the reviewer
2828
For example if you need assistance with writing tests or would like some feedback on one of your development ideas
2929
-->
3030

31-
### Contribution checklist (*)
31+
**Contribution checklist** (*)
3232
- [ ] Pull request has a meaningful description of its purpose
3333
- [ ] All commits are accompanied by meaningful commit messages
34-
34+
- [ ] All new or changed code is covered with integration/functional tests (if applicable)
35+
- [ ] All automated tests passed successfully (all builds are green)

.github/workflows/gradlepublish.yml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# This workflow will build a package using Gradle and then publish it to JetBrains repository when a release is created
2+
3+
name: Publish Plugin
4+
5+
on:
6+
release:
7+
types: [created]
8+
9+
jobs:
10+
build:
11+
12+
runs-on: ubuntu-latest
13+
14+
steps:
15+
- uses: actions/checkout@v2
16+
- name: Set up JDK 1.8
17+
uses: actions/setup-java@v1
18+
with:
19+
java-version: 1.8
20+
- name: Gradle wrapper
21+
run: gradle wrapper
22+
- name: Grant execute permission for gradlew
23+
run: chmod +x gradlew
24+
- name: Run publish plugin
25+
run: ./gradlew publishPlugin -i
26+
env:
27+
MAGENTO_PHPSTORM_intellijPublishToken: ${{ secrets.JET_BRAINS_TOKEN }}
28+
MAGENTO_PHPSTORM_isAlpha: false
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# This workflow will build a package using Gradle and then publish it to JetBrains alpha repository when a PR is merged to the develop branch
2+
3+
name: Publish Plugin alpha version
4+
5+
on:
6+
push:
7+
branches:
8+
- 1.0.1-develop
9+
10+
jobs:
11+
build:
12+
13+
runs-on: ubuntu-latest
14+
15+
steps:
16+
- uses: actions/checkout@v2
17+
- name: Set up JDK 1.8
18+
uses: actions/setup-java@v1
19+
with:
20+
java-version: 1.8
21+
- name: Gradle wrapper
22+
run: gradle wrapper
23+
- name: Grant execute permission for gradlew
24+
run: chmod +x gradlew
25+
- name: Run publish plugin
26+
run: ./gradlew publishPlugin -i
27+
env:
28+
MAGENTO_PHPSTORM_intellijPublishToken: ${{ secrets.JET_BRAINS_TOKEN }}
29+
MAGENTO_PHPSTORM_isAlpha: true

CHANGELOG.md

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,27 @@
11
1.0.0
22
=============
33
* Features:
4-
* "Go to GraphQL schema" line marker in the scope of class/interface and method
5-
* "Go to GraphQL resolver class" line marker in the scope of GraphQL schema type arguments
64
* RequireJS mapping support (reference navigation, completion)
7-
* Plugin class methods generation
8-
* Plugin declaration inspection in the scope of a Plugin Class
95
* MFTF support MVP (reference navigation, completion)
10-
* Fixed support of 2020.* versions of IDE's
6+
* Line markers for navigation from a plugin class to a target class
7+
* Line markers for navigation from a GraphQl resolver to schema and vice versa
8+
* Create a plugin for a class public method
119
* Create a New Magento 2 Module action
12-
* Code Inspection: Duplicated Observer Usage in events XML
13-
* Create a Plugin class for a class public method action
14-
* Code Inspection: Warning regarding Cacheable false attribute in default XML
15-
* Create a Preference for a class action
1610
* Create a Block action
17-
* Line markers for navigation from a plugin class to a target class
18-
* Magento 2 Module Project template on the start up
11+
* Create a View Model action
12+
* Create a new Magento 2 module as a separate project
1913
* Create an observer for an event action
20-
* Plugin - Target line markers
21-
* GraphQL resolver inspection in the scope of a PHP Class
14+
* Create a GraphQL resolver action
15+
* Override class by reference action
16+
* Plugin class methods generation
17+
* Code Inspection: Duplicated plugin Usage in di.xml
18+
* Code Inspection: Plugin declaration in the scope of a Plugin Class
19+
* Code Inspection: Warning regarding Cacheable false attribute in default XML
20+
* Code Inspection: GraphQL resolver in the scope of a PHP Class
21+
* Code Inspection: Duplicated Observer Usage in events XML
22+
* Moved plugin configuration from `Settings > Preferences > Languages & Frameworks > PHP > Magento` to
23+
`Settings > Preferences > Languages & Frameworks > PHP > Frameworks > Magento`
24+
* Fixed support of 2020.* versions of IDE's
2225

2326
0.3.0
2427
=============

build.gradle

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,17 @@ sourceSets {
4242
resources.srcDir 'testData'
4343
}
4444
}
45+
46+
publishPlugin {
47+
token = System.getenv("MAGENTO_PHPSTORM_intellijPublishToken")
48+
if (Boolean.valueOf(System.getenv("MAGENTO_PHPSTORM_isAlpha"))) {
49+
channels 'alpha'
50+
version = version + "-alpha-" + getDate()
51+
}
52+
}
53+
54+
static def getDate() {
55+
def date = new Date()
56+
def formattedDate = date.format('yyyy-MM-dd-HH-mm')
57+
return formattedDate
58+
}

resources/META-INF/withJsGraphQl.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
<!--
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
-->
7+
18
<idea-plugin>
29
<extensions defaultExtensionNs="com.intellij">
310
<fileBasedIndex implementation="com.magento.idea.magento2plugin.stubs.indexes.graphql.GraphQlResolverIndex" />
@@ -9,5 +16,11 @@
916
enabledByDefault="true"
1017
level="ERROR"
1118
implementationClass="com.magento.idea.magento2plugin.inspections.php.GraphQlResolverInspection"/>
19+
<localInspection language="GraphQL" groupPath="GraphQL"
20+
shortName="SchemaResolverInspection" displayName="Schema Resolver must implements ResolverInterface"
21+
groupName="Magento 2"
22+
enabledByDefault="true"
23+
level="ERROR"
24+
implementationClass="com.magento.idea.magento2plugin.inspections.graphqls.SchemaResolverInspection"/>
1225
</extensions>
1326
</idea-plugin>

resources/fileTemplates/code/Magento Crontab Cronjob Registration.xml.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
<tr>
4343
<td valign="top"><nobr><font face="verdana" size="-2"><b>${CRONJOB_SCHEDULE}</b></font></nobr></td>
4444
<td width="10">&nbsp;</td>
45-
<td width="100%" valign="top"><font face="verdana" size="-1">The valid fixed cron schedule expression which defines when cronjob is planed to execute</font></td>
45+
<td width="100%" valign="top"><font face="verdana" size="-1">The valid fixed cron schedule expression which defines when cronjob is planned to execute</font></td>
4646
</tr>
4747
<tr>
4848
<td valign="top"><nobr><font face="verdana" size="-2"><b>${CRONJOB_SCHEDULE_CONFIG_PATH}</b></font></nobr></td>

0 commit comments

Comments
 (0)