Skip to content

Commit fa2ab71

Browse files
committed
[#267]_write unit test
1 parent fc2533d commit fa2ab71

File tree

7 files changed

+121
-4
lines changed

7 files changed

+121
-4
lines changed
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
package com.magento.idea.magento2plugin.magento.files;
2+
3+
import com.intellij.lang.Language;
4+
import com.intellij.lang.xml.XMLLanguage;
5+
6+
public class ModuleXmlHaveSetupVersion implements ModuleFileInterface {
7+
8+
public static String FILE_NAME = "module.xml";
9+
public static String MODULE_ATTR_NAME = "name";
10+
public static String TEMPLATE = "Magento Module Xml";
11+
private static ModuleXmlHaveSetupVersion INSTANCE = null;
12+
13+
public static ModuleXmlHaveSetupVersion getInstance() {
14+
if (null == INSTANCE) {
15+
INSTANCE = new ModuleXmlHaveSetupVersion();
16+
}
17+
return INSTANCE;
18+
}
19+
20+
@Override
21+
public String getFileName() {
22+
return FILE_NAME;
23+
}
24+
25+
@Override
26+
public String getTemplate() {
27+
return TEMPLATE;
28+
}
29+
30+
@Override
31+
public Language getLanguage() {
32+
return XMLLanguage.INSTANCE;
33+
}
34+
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
33
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
4-
<module name="Test_Module" setup_version="1.0.0"/>
4+
<module name="Test_Module"/>
55
</config>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
33
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
4-
<module name="Test_Module" setup_version="1.0.0"/>
4+
<module name="Test_Module"/>
55
</config>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<?xml version="1.0"?>
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
4+
<module name="Test_Module" setup_version="1.0.0"/>
5+
</config>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<?xml version="1.0"?>
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
4+
<module name="Test_Module" setup_version="1.0.0"/>
5+
</config>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
package com.magento.idea.magento2plugin.actions.generation.generator;
2+
3+
import com.intellij.openapi.project.Project;
4+
import com.intellij.psi.PsiDirectory;
5+
import com.intellij.psi.PsiFile;
6+
import com.magento.idea.magento2plugin.actions.generation.data.ModuleXmlData;
7+
import com.magento.idea.magento2plugin.magento.files.ModuleXml;
8+
import com.magento.idea.magento2plugin.magento.files.ModuleXmlHaveSetupVersion;
9+
import com.magento.idea.magento2plugin.magento.packages.File;
10+
import com.magento.idea.magento2plugin.magento.packages.Package;
11+
12+
public class ModuleXmlGeneratorHaveSetupVersionTest extends BaseGeneratorTestCase {
13+
14+
/**
15+
* Test checks whether module.xml is generated correctly.
16+
*/
17+
public void testGenerateModuleFile() {
18+
final String filePath = this.getFixturePath(ModuleXmlHaveSetupVersion.FILE_NAME);
19+
final PsiFile expectedFile = myFixture.configureByFile(filePath);
20+
final PsiDirectory projectDir = getProjectDirectory();
21+
22+
final Project project = myFixture.getProject();
23+
final ModuleXmlData moduleXmlData = new ModuleXmlData(
24+
"Test",
25+
"Module",
26+
"1.0.0",
27+
projectDir,
28+
true
29+
);
30+
final ModuleXmlGenerator moduleXmlGenerator = new ModuleXmlGenerator(
31+
moduleXmlData,
32+
project
33+
);
34+
final PsiFile moduleXml = moduleXmlGenerator.generate("test");
35+
36+
assertGeneratedFileIsCorrect(
37+
expectedFile,
38+
projectDir.getVirtualFile().getPath()
39+
+ "/Test/Module" + File.separator + Package.moduleBaseAreaDir,
40+
moduleXml
41+
);
42+
}
43+
44+
/**
45+
* Test checks whether module.xml is generated
46+
* correctly for module as a separate project.
47+
*/
48+
public void testGenerateFileInRoot() {
49+
final String filePath = this.getFixturePath(ModuleXml.FILE_NAME);
50+
final PsiFile expectedFile = myFixture.configureByFile(filePath);
51+
final PsiDirectory projectDir = getProjectDirectory();
52+
53+
final Project project = myFixture.getProject();
54+
final ModuleXmlData moduleXmlData = new ModuleXmlData(
55+
"Test",
56+
"Module",
57+
"1.0.0",
58+
projectDir,
59+
false
60+
);
61+
final ModuleXmlGenerator moduleXmlGenerator = new ModuleXmlGenerator(
62+
moduleXmlData,
63+
project
64+
);
65+
final PsiFile moduleXml = moduleXmlGenerator.generate("test");
66+
67+
assertGeneratedFileIsCorrect(
68+
expectedFile,
69+
projectDir.getVirtualFile().getPath() + File.separator + Package.moduleBaseAreaDir,
70+
moduleXml
71+
);
72+
}
73+
}

tests/com/magento/idea/magento2plugin/actions/generation/generator/ModuleXmlGeneratorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void testGenerateModuleFile() {
2727
final ModuleXmlData moduleXmlData = new ModuleXmlData(
2828
"Test",
2929
"Module",
30-
"1.0.0",
30+
null,
3131
projectDir,
3232
true
3333
);
@@ -58,7 +58,7 @@ public void testGenerateFileInRoot() {
5858
final ModuleXmlData moduleXmlData = new ModuleXmlData(
5959
"Test",
6060
"Module",
61-
"1.0.0",
61+
null,
6262
projectDir,
6363
false
6464
);

0 commit comments

Comments
 (0)