Skip to content

Commit 9e7d8d4

Browse files
committed
AC-13306::Adobe Commerce 2.4.8 core code is compatible with PHP 8.4
1 parent f4a2fde commit 9e7d8d4

File tree

9 files changed

+11
-11
lines changed

9 files changed

+11
-11
lines changed

app/code/Magento/BundleSampleData/Setup/Installer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class Installer implements Setup\SampleData\InstallerInterface
3232
*/
3333
public function __construct(
3434
\Magento\BundleSampleData\Model\Product $bundleProduct,
35-
StoreManagerInterface $storeManager = null
35+
?StoreManagerInterface $storeManager = null
3636
) {
3737
$this->bundleProduct = $bundleProduct;
3838
$this->storeManager = $storeManager ?: \Magento\Framework\App\ObjectManager::getInstance()

app/code/Magento/CatalogRuleSampleData/Model/Rule.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function __construct(
7272
\Magento\Catalog\Model\ResourceModel\Category\CollectionFactory $categoryCollectionFactory,
7373
\Magento\Customer\Model\GroupFactory $groupFactory,
7474
\Magento\Store\Model\WebsiteFactory $websiteFactory,
75-
Json $serializer = null
75+
?Json $serializer = null
7676
) {
7777
$this->fixtureManager = $sampleDataContext->getFixtureManager();
7878
$this->csvReader = $sampleDataContext->getCsvReader();

app/code/Magento/DownloadableSampleData/Model/Product/Converter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ public function __construct(
3232
\Magento\Catalog\Model\ResourceModel\Product\Attribute\CollectionFactory $attributeCollectionFactory,
3333
\Magento\Eav\Model\ResourceModel\Entity\Attribute\Option\CollectionFactory $attrOptionCollectionFactory,
3434
\Magento\Catalog\Model\ResourceModel\Product\CollectionFactory $productCollectionFactory,
35-
\Magento\Downloadable\Api\Data\File\ContentInterfaceFactory $fileContentFactory = null,
36-
Filesystem $filesystem = null
35+
?\Magento\Downloadable\Api\Data\File\ContentInterfaceFactory $fileContentFactory = null,
36+
?Filesystem $filesystem = null
3737
) {
3838
parent::__construct(
3939
$categoryTreeFactory,

app/code/Magento/DownloadableSampleData/Setup/Installer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function __construct(
4444
Category $category,
4545
Attribute $attribute,
4646
Product $product,
47-
StoreManagerInterface $storeManager = null
47+
?StoreManagerInterface $storeManager = null
4848
) {
4949
$this->category = $category;
5050
$this->attribute = $attribute;

app/code/Magento/GroupedProductSampleData/Setup/Installer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class Installer implements Setup\SampleData\InstallerInterface
2929
*/
3030
public function __construct(
3131
\Magento\GroupedProductSampleData\Model\Product $groupedProduct,
32-
StoreManagerInterface $storeManager = null
32+
?StoreManagerInterface $storeManager = null
3333
) {
3434
$this->groupedProduct = $groupedProduct;
3535
$this->storeManager = $storeManager ?: \Magento\Framework\App\ObjectManager::getInstance()

app/code/Magento/OfflineShippingSampleData/Model/Tablerate.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public function __construct(
8383
\Magento\Framework\App\Cache\TypeListInterface $cacheTypeList,
8484
\Magento\Framework\App\Config\Storage\WriterInterface $configWriter,
8585
\Magento\Store\Model\StoreManagerInterface $storeManager,
86-
SystemConfig $systemConfig = null
86+
?SystemConfig $systemConfig = null
8787
) {
8888
$this->fixtureManager = $sampleDataContext->getFixtureManager();
8989
$this->csvReader = $sampleDataContext->getCsvReader();

app/code/Magento/SalesSampleData/Model/Order/Converter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public function __construct(
5656
\Magento\Catalog\Model\ProductFactory $productFactory,
5757
\Magento\ConfigurableSampleData\Model\Product\ConverterFactory $productConverterFactory,
5858
\Magento\Eav\Model\Config $eavConfig,
59-
Json $serializer = null
59+
?Json $serializer = null
6060
) {
6161
$this->customerRepository = $customerAccount;
6262
$this->productFactory = $productFactory;

app/code/Magento/TaxSampleData/Model/Tax.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public function __construct(
8787
\Magento\Tax\Model\Calculation\RateFactory $taxRateFactory,
8888
\Magento\Framework\Api\SearchCriteriaBuilder $criteriaBuilder,
8989
\Magento\Framework\Api\FilterBuilder $filterBuilder,
90-
\Magento\Directory\Model\ResourceModel\Region\CollectionFactory $regionCollectionFactory = null
90+
?\Magento\Directory\Model\ResourceModel\Region\CollectionFactory $regionCollectionFactory = null
9191
) {
9292
$this->fixtureManager = $sampleDataContext->getFixtureManager();
9393
$this->csvReader = $sampleDataContext->getCsvReader();

app/code/Magento/WidgetSampleData/Model/CmsBlock.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ public function __construct(
7676
\Magento\Cms\Model\BlockFactory $cmsBlockFactory,
7777
\Magento\Widget\Model\ResourceModel\Widget\Instance\CollectionFactory $appCollectionFactory,
7878
\Magento\Catalog\Model\ResourceModel\Category\CollectionFactory $categoryFactory,
79-
Json $serializer = null,
80-
State $appState = null
79+
?Json $serializer = null,
80+
?State $appState = null
8181
) {
8282
$this->fixtureManager = $sampleDataContext->getFixtureManager();
8383
$this->csvReader = $sampleDataContext->getCsvReader();

0 commit comments

Comments
 (0)