MAGETWO-66328: Remove usages of serialize/unserialize in CustomerSampleData

- Convert install code to JSON serializer and change csv data to JSON array
- Fix minor docblock issues
- Fix bug in di.xml that breaks installation

Author: tjwiebell

app/code/Magento/CustomerSampleData/Model/Customer.php

@@ -5,11 +5,11 @@
  */
 namespace Magento\CustomerSampleData\Model;
 
-use Magento\Framework\Setup\SampleData\Context as SampleDataContext;
 use Magento\Customer\Api\Data\RegionInterface;
+use Magento\Framework\Serialize\Serializer\Json;
+use Magento\Framework\Setup\SampleData\Context as SampleDataContext;
 
 /**
- * Class Customer
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Customer
@@ -50,12 +50,12 @@ class Customer
     protected $accountManagement;
 
     /**
-     * @var array $customerDataProfile
+     * @var array
      */
     protected $customerDataProfile;
 
     /**
-     * @var array $customerDataAddress
+     * @var array
      */
     protected $customerDataAddress;
 
@@ -69,9 +69,16 @@ class Customer
      */
     protected $dataObjectHelper;
 
-
+    /**
+     * @var \Magento\Framework\App\State
+     */
     protected $appState;
 
+    /**
+     * @var Json
+     */
+    private $serializer;
+
     /**
      * @param SampleDataContext $sampleDataContext
      * @param \Magento\Directory\Model\CountryFactory $countryFactory
@@ -82,6 +89,7 @@ class Customer
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\Framework\Api\DataObjectHelper $dataObjectHelper
      * @param \Magento\Framework\App\State $appState
+     * @param Json $serializer
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
@@ -93,7 +101,8 @@ public function __construct(
         \Magento\Customer\Api\AccountManagementInterface $accountManagement,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\Framework\Api\DataObjectHelper $dataObjectHelper,
-        \Magento\Framework\App\State $appState
+        \Magento\Framework\App\State $appState,
+        Json $serializer = null
     ) {
         $this->fixtureManager = $sampleDataContext->getFixtureManager();
         $this->csvReader = $sampleDataContext->getCsvReader();
@@ -105,10 +114,13 @@ public function __construct(
         $this->storeManager = $storeManager;
         $this->dataObjectHelper = $dataObjectHelper;
         $this->appState = $appState;
+        $this->serializer = $serializer ?: \Magento\Framework\App\ObjectManager::getInstance()->get(Json::class);
     }
 
     /**
-     * {@inheritdoc}
+     * Loop through list of fixture files and install sample data
+     *
+     * @param string[] $fixtures
      */
     public function install($fixtures)
     {
@@ -237,7 +249,7 @@ protected function convertRowData($row, $data)
         foreach ($row as $field => $value) {
             if (isset($data[$field])) {
                 if ($field == 'street') {
-                    $data[$field] = unserialize($value);
+                    $data[$field] = $this->serializer->unserialize($value);
                     continue;
                 }
                 if ($field == 'password') {

app/code/Magento/CustomerSampleData/etc/di.xml

@@ -6,7 +6,7 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
-    <type name="\Magento\Framework\Mail\TransportInterface">
+    <type name="Magento\Framework\Mail\TransportInterface">
         <plugin name="customer-sample-data-disable-registration-email-send" type="Magento\CustomerSampleData\Magento\Framework\Mail\Transport\MailPlugin"/>
     </type>
 </config>

app/code/Magento/CustomerSampleData/fixtures/customer_profile.csv

@@ -1,2 +1,2 @@
 firstname,lastname,email,password,dob,gender,street,city,region,country_id,postcode,telephone
-Veronica,Costello,"[email protected]","[email protected]","1973-12-15",2,"a:2:{i:0;s:24:""6146 Honey Bluff Parkway"";i:1;s:0:"""";}",Calder,Michigan,US,"49628-7978","(555) 229-3326"
+Veronica,Costello,"[email protected]","[email protected]","1973-12-15",2,"[""6146 Honey Bluff Parkway"",""""]",Calder,Michigan,US,"49628-7978","(555) 229-3326"