PWA-2343 moving computed resolver into connector, passing additional resolvers to UPWARD (#16)

Author: justinconabree

Controller/UpwardControllerFactory.php

@@ -11,6 +11,7 @@
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Upward\Controller as UpwardController;
 use Magento\UpwardConnector\Api\UpwardPathManagerInterface;
+use Magento\UpwardConnector\Resolver\Computed;
 
 class UpwardControllerFactory
 {
@@ -51,6 +52,17 @@ public function create(RequestInterface $request): UpwardController
             throw new \RuntimeException('Path to UPWARD configuration file not set.');
         }
 
-        return $this->objectManager->create(UpwardController::class, compact('request', 'upwardConfig'));
+        $additionalResolvers = [
+            Computed::RESOLVER_TYPE => Computed::class
+        ];
+
+        return $this->objectManager->create(
+            UpwardController::class,
+            compact(
+                'request',
+                'upwardConfig',
+                'additionalResolvers'
+            )
+        );
     }
 }

Resolver/Computed.php

@@ -0,0 +1,62 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Magento\UpwardConnector\Resolver;
+
+use Magento\Framework\App\ObjectManager;
+use Magento\Upward\Definition;
+use Magento\Upward\Resolver\AbstractResolver;
+use Magento\UpwardConnector\Api\ComputedInterface;
+use Magento\UpwardConnector\Model\ComputedPool;
+
+class Computed extends AbstractResolver
+{
+    public const RESOLVER_TYPE = 'computed';
+
+    /** @var \Magento\UpwardConnector\Model\ComputedPool */
+    private $computed;
+
+    public function __construct()
+    {
+        $this->computed = ObjectManager::getInstance()
+            ->get(ComputedPool::class);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getIndicator(): string
+    {
+        return 'computed';
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function isValid(Definition $definition): bool
+    {
+        return $definition->has('type');
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function resolve($definition)
+    {
+        $computeType = $this->getIterator()->get('type', $definition);
+        $computeResolver = $this->computed->getItem($computeType);
+        if (!($computeResolver instanceof ComputedInterface)) {
+            throw new \RuntimeException(sprintf(
+                'Compute definition %s is not valid.',
+                $computeType
+            ));
+        }
+
+        return $computeResolver->resolve($this->getIterator(), $definition);
+    }
+}