Skip to content

Commit b6a4a50

Browse files
[PWA-1089] Store Admins cant get to Order Tracking information (#4)
* Whitelist -> Allowlist * Use inclusive language and add shipping as default value * Add flag to easily restore default value Co-authored-by: Revanth Kumar Annavarapu <[email protected]>
1 parent fce51e9 commit b6a4a50

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ _Use the absolute path on the server for the value of this configuration._
2323

2424
Example: `/app/node_modules/@magento/venia-concept/dist/upward.yml`
2525

26-
### Front Name Whitelist
26+
### Front Name Allowlist
2727

2828
This configuration allows you to specify a line-separated list of routes to forward to the default Magento theme.
2929

Test/Unit/Magento/Framework/App/AreaListTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ public function afterGetCodeByFrontNameDataProvider()
7070
return [
7171
'Adminhtml area passes through' => ['adminhtml', '', 'adminhtml'],
7272
'Frontend area w/o frontname goes to UPWARD' => ['frontend', '', 'pwa'],
73-
'Frontend area w/o frontname in whitelist goes to UPWARD' => ['frontend', 'baz', 'pwa'],
74-
'Frontend area with frontname in whitelist passes through' => ['frontend', 'foo', 'frontend']
73+
'Frontend area w/o frontname in allow list goes to UPWARD' => ['frontend', 'baz', 'pwa'],
74+
'Frontend area with frontname in allow list passes through' => ['frontend', 'foo', 'frontend']
7575
];
7676
}
7777
}

etc/adminhtml/system.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
<config_path>web/upward/path</config_path>
1919
<comment>Server path to YAML configuration file for UPWARD</comment>
2020
</field>
21-
<field id="front_names_to_skip" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="30" translate="label,comment" type="textarea">
22-
<label>Front Name Whitelist</label>
21+
<field id="front_names_to_skip" canRestore="1" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="30" translate="label,comment" type="textarea">
22+
<label>Front Name Allowlist</label>
2323
<comment>Line break separated list of URL's that will load the default Magento frontend.</comment>
2424
</field>
2525
<field id="prerender_enabled" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="40" translate="label,comment" type="select">

etc/config.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
<default>
1010
<web>
1111
<upward>
12+
<front_names_to_skip>shipping</front_names_to_skip>
1213
<prerender_enabled>0</prerender_enabled>
1314
<prerender_crawlers>
1415
googlebot

0 commit comments

Comments
 (0)