MC-32709: Customer configuration: Account sharing options

Author: dimonovp

dev/tests/integration/testsuite/Magento/Customer/Model/AccountManagement/CreateAccountTest.php

@@ -19,6 +19,7 @@
 use Magento\Framework\Encryption\EncryptorInterface;
 use Magento\Framework\Exception\InputException;
 use Magento\Framework\Exception\LocalizedException;
+use Magento\Framework\Exception\State\InputMismatchException;
 use Magento\Framework\Math\Random;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\Validator\Exception;
@@ -496,9 +497,33 @@ public function testCreateNewCustomerFromClone(): void
         $this->assertCustomerData($customer, $expectedCustomerData);
         $this->accountManagement->authenticate(
             $customer->getEmail(),
-            '_aPassword1',
-            true
+            '_aPassword1'
+        );
+    }
+
+    /**
+     * Test for create customer account for second website (with existing email for default website)
+     * with global account scope config.
+     *
+     * @magentoConfigFixture current_store customer/account_share/scope 0
+     * @magentoDataFixture Magento/Customer/_files/customer.php
+     * @magentoDataFixture Magento/Store/_files/second_website_with_two_stores.php
+     *
+     * @return void
+     */
+    public function testCreateAccountInGlobalScope(): void
+    {
+        $customerEntity = $this->customerFactory->create();
+        $this->dataObjectHelper->populateWithArray(
+            $customerEntity,
+            $this->defaultCustomerData,
+            CustomerInterface::class
         );
+        $storeId = $this->storeManager->getStore('fixture_second_store')->getStoreId();
+        $customerEntity->setStoreId($storeId);
+        $message = 'A customer with the same email address already exists in an associated website.';
+        $this->expectExceptionObject(new InputMismatchException(__($message)));
+        $this->accountManagement->createAccount($customerEntity, '_aPassword1');
     }
 
     /**

dev/tests/integration/testsuite/Magento/Customer/Model/Config/ShareTest.php

@@ -3,43 +3,80 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Customer\Model\Config;
 
+use Magento\Framework\Exception\LocalizedException;
+use Magento\Framework\ObjectManagerInterface;
+use Magento\Store\Api\WebsiteRepositoryInterface;
 use Magento\TestFramework\Helper\Bootstrap;
+use PHPUnit\Framework\TestCase;
 
 /**
  * Test \Magento\Customer\Model\Config\Share
  */
-class ShareTest extends \PHPUnit\Framework\TestCase
+class ShareTest extends TestCase
 {
-    public function testGetSharedWebsiteIds()
+    /** @var ObjectManagerInterface */
+    private $objectManager;
+
+    /** @var Share */
+    private $share;
+
+    /** @var WebsiteRepositoryInterface */
+    private $websiteRepository;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp()
     {
-        /** @var Share $share */
-        $share = Bootstrap::getObjectManager()->get(\Magento\Customer\Model\Config\Share::class);
+        parent::setUp();
 
-        $websiteIds = $share->getSharedWebsiteIds(42);
+        $this->objectManager = Bootstrap::getObjectManager();
+        $this->share = $this->objectManager->get(Share::class);
+        $this->websiteRepository = $this->objectManager->create(WebsiteRepositoryInterface::class);
+    }
 
+    /**
+     * @return void
+     */
+    public function testGetSharedWebsiteIds(): void
+    {
+        $websiteIds = $this->share->getSharedWebsiteIds(42);
         $this->assertEquals([42], $websiteIds);
     }
 
     /**
      * @magentoDataFixture Magento/Store/_files/core_second_third_fixturestore.php
      * @magentoConfigFixture current_store customer/account_share/scope 0
+     *
+     * @return void
      */
-    public function testGetSharedWebsiteIdsMultipleSites()
+    public function testGetSharedWebsiteIdsMultipleSites(): void
     {
-        /** @var Share $share */
-        $share = Bootstrap::getObjectManager()->get(\Magento\Customer\Model\Config\Share::class);
-        $expectedIds = [1];
-        /** @var \Magento\Store\Model\Website $website */
-        $website = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
-            \Magento\Store\Model\Website::class
-        );
-        $expectedIds[] = $website->load('secondwebsite')->getId();
-        $expectedIds[] = $website->load('thirdwebsite')->getId();
-
-        $websiteIds = $share->getSharedWebsiteIds(42);
-
+        $expectedIds[] = $this->websiteRepository->get('base')->getId();
+        $expectedIds[] = $this->websiteRepository->get('secondwebsite')->getId();
+        $expectedIds[] = $this->websiteRepository->get('thirdwebsite')->getId();
+        $websiteIds = $this->share->getSharedWebsiteIds(42);
         $this->assertEquals($expectedIds, $websiteIds);
     }
+
+    /**
+     * @magentoConfigFixture current_store customer/account_share/scope 1
+     * @magentoDataFixture Magento/Customer/_files/customer.php
+     * @magentoDataFixture Magento/Customer/_files/customer_for_second_website.php
+     * @magentoDbIsolation enabled
+     *
+     * @return void
+     */
+    public function testEnableGlobalAccountShareScope(): void
+    {
+        $message = 'We can\'t share customer accounts globally when the accounts share'
+            . ' identical email addresses on more than one website.';
+        $this->expectExceptionObject(new LocalizedException(__($message)));
+        $this->share->setPath(Share::XML_PATH_CUSTOMER_ACCOUNT_SHARE)->setValue((string)Share::SHARE_GLOBAL)
+            ->beforeSave();
+    }
 }