ACP2E-47: Order emails contains data localized using Admin's locale instead of a customer's locale

Author: yvoronoy

app/code/Magento/Sales/Model/Order/Email/Sender/CreditmemoCommentSender.php

@@ -17,9 +17,6 @@
 use Magento\Framework\DataObject;
 use Magento\Store\Model\App\Emulation;
 
-/**
- * Class CreditmemoCommentSender
- */
 class CreditmemoCommentSender extends NotifySender
 {
     /**

app/code/Magento/Sales/Model/Order/Email/Sender/CreditmemoSender.php

@@ -71,6 +71,8 @@ class CreditmemoSender extends Sender
      * @param \Magento\Framework\App\Config\ScopeConfigInterface $globalConfig
      * @param ManagerInterface $eventManager
      * @param Emulation|null $appEmulation
+     *
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         Template $templateContainer,

app/code/Magento/Sales/Model/Order/Email/Sender/InvoiceCommentSender.php

@@ -17,9 +17,6 @@
 use Magento\Framework\DataObject;
 use Magento\Store\Model\App\Emulation;
 
-/**
- * Class InvoiceCommentSender
- */
 class InvoiceCommentSender extends NotifySender
 {
     /**
@@ -46,6 +43,7 @@ class InvoiceCommentSender extends NotifySender
      * @param \Psr\Log\LoggerInterface $logger
      * @param Renderer $addressRenderer
      * @param ManagerInterface $eventManager
+     * @param Emulation|null $appEmulation
      */
     public function __construct(
         Template $templateContainer,

app/code/Magento/Sales/Model/Order/Email/Sender/InvoiceSender.php

@@ -72,6 +72,9 @@ class InvoiceSender extends Sender
      * @param InvoiceResource $invoiceResource
      * @param \Magento\Framework\App\Config\ScopeConfigInterface $globalConfig
      * @param ManagerInterface $eventManager
+     * @param Emulation|null $appEmulation
+     *
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         Template $templateContainer,

app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentCommentSender.php

@@ -17,9 +17,6 @@
 use Magento\Framework\DataObject;
 use Magento\Store\Model\App\Emulation;
 
-/**
- * Class ShipmentCommentSender
- */
 class ShipmentCommentSender extends NotifySender
 {
     /**

app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentSender.php

@@ -73,6 +73,8 @@ class ShipmentSender extends Sender
      * @param \Magento\Framework\App\Config\ScopeConfigInterface $globalConfig
      * @param ManagerInterface $eventManager
      * @param Emulation|null $appEmulation
+     *
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         Template $templateContainer,

app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/InvoiceCommentSenderTest.php

@@ -26,11 +26,6 @@ class InvoiceCommentSenderTest extends AbstractSenderTest
      */
     protected $invoiceMock;
 
-    /**
-     * @var Invoice|MockObject
-     */
-    private $invoiceResource;
-
     /**
      * @inheritDoc
      */