AC-10621::PHPUnit 10 upgrade error: ‘RuntimeException: ObjectManager isn't initialized’

Shradddha · Shradddha · commit 03cdbc6ce9b8 · 2024-01-08T18:46:27.000+05:30
diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/UrlRewriteHandlerTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/UrlRewriteHandlerTest.php
@@ -21,6 +21,8 @@
 use Magento\UrlRewrite\Model\UrlPersistInterface;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Magento\CatalogUrlRewrite\Model\ProductScopeRewriteGenerator;
+use Magento\Framework\App\Config\ScopeConfigInterface;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -77,6 +79,16 @@ class UrlRewriteHandlerTest extends TestCase
      */
     private $serializerMock;
 
+    /**
+     * @var ProductScopeRewriteGenerator
+     */
+    private $productScopeRewriteGeneratorMock;
+
+    /**
+     * @var ScopeConfigInterface
+     */
+    private $scopeConfigMock;
+
     /**
      * {@inheritDoc}
      */
@@ -96,7 +108,7 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMock();
         $this->mergeDataProviderFactoryMock = $this->getMockBuilder(MergeDataProviderFactory::class)
-            ->setMethods(['create'])
+            ->onlyMethods(['create'])
             ->disableOriginalConstructor()
             ->getMock();
         $this->mergeDataProviderMock = $this->getMockBuilder(MergeDataProvider::class)
@@ -111,6 +123,12 @@ protected function setUp(): void
         $this->serializerMock = $this->getMockBuilder(Json::class)
             ->disableOriginalConstructor()
             ->getMock();
+        $this->productScopeRewriteGeneratorMock = $this->getMockBuilder(ProductScopeRewriteGenerator::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->scopeConfigMock = $this->getMockBuilder(ScopeConfigInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
 
         $this->urlRewriteHandler = new UrlRewriteHandler(
             $this->childrenCategoriesProviderMock,
@@ -120,7 +138,9 @@ protected function setUp(): void
             $this->collectionFactoryMock,
             $this->categoryBasedProductRewriteGeneratorMock,
             $this->mergeDataProviderFactoryMock,
-            $this->serializerMock
+            $this->serializerMock,
+            $this->productScopeRewriteGeneratorMock,
+            $this->scopeConfigMock
         );
     }
 
@@ -131,7 +151,8 @@ public function testGenerateProductUrlRewrites()
     {
         /* @var \Magento\Catalog\Model\Category|MockObject $category */
         $category = $this->getMockBuilder(Category::class)
-            ->setMethods(['getEntityId', 'getStoreId', 'getData', 'getChangedProductIds'])
+            ->addMethods(['getChangedProductIds'])
+            ->onlyMethods(['getEntityId', 'getStoreId', 'getData'])
             ->disableOriginalConstructor()
             ->getMock();
         $category->expects($this->any())
@@ -142,18 +163,22 @@ public function testGenerateProductUrlRewrites()
             ->willReturn(1);
         $category->expects($this->any())
             ->method('getData')
-            ->withConsecutive(
-                [$this->equalTo('save_rewrites_history')],
-                [$this->equalTo('initial_setup_flag')]
-            )
-            ->willReturnOnConsecutiveCalls(
-                true,
-                null
-            );
+            ->willReturnCallback(fn ($operation) => match ([$operation]) {
+                [$this->equalTo('save_rewrites_history')] => true,
+                [$this->equalTo('initial_setup_flag')] => null
+            });
+//            ->withConsecutive(
+//                [$this->equalTo('save_rewrites_history')],
+//                [$this->equalTo('initial_setup_flag')]
+//            )
+//            ->willReturnOnConsecutiveCalls(
+//                true,
+//                null
+//            );
 
         /* @var \Magento\Catalog\Model\Category|MockObject $childCategory1 */
         $childCategory1 = $this->getMockBuilder(Category::class)
-            ->setMethods(['getEntityId'])
+            ->onlyMethods(['getEntityId'])
             ->disableOriginalConstructor()
             ->getMock();
         $childCategory1->expects($this->any())
@@ -162,7 +187,7 @@ public function testGenerateProductUrlRewrites()
 
         /* @var \Magento\Catalog\Model\Category|MockObject $childCategory1 */
         $childCategory2 = $this->getMockBuilder(Category::class)
-            ->setMethods(['getEntityId'])
+            ->onlyMethods(['getEntityId'])
             ->disableOriginalConstructor()
             ->getMock();
         $childCategory1->expects($this->any())
diff --git a/app/code/Magento/Checkout/Test/Unit/Block/Checkout/AttributeMergerTest.php b/app/code/Magento/Checkout/Test/Unit/Block/Checkout/AttributeMergerTest.php
@@ -13,6 +13,7 @@
 use Magento\Customer\Model\Session as CustomerSession;
 use Magento\Directory\Helper\Data as DirectoryHelper;
 use PHPUnit\Framework\TestCase;
+use Magento\Directory\Model\AllowedCountries;
 
 class AttributeMergerTest extends TestCase
 {
@@ -41,6 +42,11 @@ class AttributeMergerTest extends TestCase
      */
     private $attributeMerger;
 
+    /**
+     * @var AllowedCountries
+     */
+    private $allowedCountryReader;
+
     /**
      * @inheritdoc
      */
@@ -50,12 +56,14 @@ protected function setUp(): void
         $this->customerSession = $this->createMock(CustomerSession::class);
         $this->addressHelper = $this->createMock(AddressHelper::class);
         $this->directoryHelper = $this->createMock(DirectoryHelper::class);
+        $this->allowedCountryReader = $this->createMock(AllowedCountries::class);
 
         $this->attributeMerger = new AttributeMerger(
             $this->addressHelper,
             $this->customerSession,
             $this->customerRepository,
-            $this->directoryHelper
+            $this->directoryHelper,
+            $this->allowedCountryReader
         );
     }
 
diff --git a/app/code/Magento/Checkout/Test/Unit/Block/LinkTest.php b/app/code/Magento/Checkout/Test/Unit/Block/LinkTest.php
@@ -9,10 +9,12 @@
 
 use Magento\Checkout\Block\Link;
 use Magento\Checkout\Helper\Data;
+use Magento\Framework\Math\Random;
 use Magento\Framework\Module\Manager;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Framework\UrlInterface;
 use Magento\Framework\View\Element\Template\Context;
+use Magento\Framework\View\Helper\SecureHtmlRenderer;
 use PHPUnit\Framework\TestCase;
 
 class LinkTest extends TestCase
@@ -25,6 +27,18 @@ class LinkTest extends TestCase
     protected function setUp(): void
     {
         $this->_objectManagerHelper = new ObjectManager($this);
+
+        $objects = [
+            [
+                SecureHtmlRenderer::class,
+                $this->createMock(SecureHtmlRenderer::class)
+            ],
+            [
+                Random::class,
+                $this->createMock(Random::class)
+            ]
+        ];
+        $this->_objectManagerHelper->prepareObjectManager($objects);
     }
 
     public function testGetUrl()
diff --git a/app/code/Magento/Checkout/Test/Unit/Model/DefaultConfigProviderTest.php b/app/code/Magento/Checkout/Test/Unit/Model/DefaultConfigProviderTest.php
@@ -43,6 +43,7 @@
 use Magento\Store\Model\StoreManagerInterface;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Magento\Framework\Escaper;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -84,6 +85,11 @@ class DefaultConfigProviderTest extends TestCase
      */
     private $configPostProcessor;
 
+    /**
+     * @var Escaper
+     */
+    private $escaper;
+
     /**
      * @inheritdoc
      */
@@ -122,6 +128,7 @@ protected function setUp(): void
         $this->addressMetadata = $this->createMock(AddressMetadataInterface::class);
         $attributeOptionManager = $this->createMock(AttributeOptionManagementInterface::class);
         $customerAddressData = $this->createMock(CustomerAddressDataProvider::class);
+        $escaper = $this->createMock(Escaper::class);
         $this->model = new DefaultConfigProvider(
             $checkoutHelper,
             $this->checkoutSession,
@@ -152,7 +159,8 @@ protected function setUp(): void
             $this->configPostProcessor,
             $this->addressMetadata,
             $attributeOptionManager,
-            $customerAddressData
+            $customerAddressData,
+            $escaper
         );
     }
 
diff --git a/app/code/Magento/Checkout/Test/Unit/Model/SessionTest.php b/app/code/Magento/Checkout/Test/Unit/Model/SessionTest.php
@@ -13,6 +13,7 @@
 use Magento\Framework\Event\ManagerInterface;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Message\CollectionFactory;
+use Magento\Framework\Session\SessionStartChecker;
 use Magento\Framework\Session\Storage;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Quote\Api\CartRepositoryInterface;
@@ -51,6 +52,14 @@ class SessionTest extends TestCase
     protected function setUp(): void
     {
         $this->helper = new ObjectManager($this);
+        $objects = [
+            [
+                SessionStartChecker::class,
+                $this->createMock(SessionStartChecker::class)
+            ]
+        ];
+        $this->helper->prepareObjectManager($objects);
+
     }
 
     /**
diff --git a/app/code/Magento/Cms/Test/Unit/Block/Adminhtml/Wysiwyg/Images/TreeTest.php b/app/code/Magento/Cms/Test/Unit/Block/Adminhtml/Wysiwyg/Images/TreeTest.php
@@ -11,10 +11,12 @@
 use Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Tree;
 use Magento\Cms\Helper\Wysiwyg\Images;
 use Magento\Cms\Model\Wysiwyg\Images\Storage;
+use Magento\Directory\Helper\Data as DirectoryHelper;
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\DataObject;
 use Magento\Framework\Filesystem;
 use Magento\Framework\Filesystem\Directory\Read;
+use Magento\Framework\Json\Helper\Data as JsonHelper;
 use Magento\Framework\Registry;
 use Magento\Framework\Serialize\Serializer\Json;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
@@ -62,6 +64,19 @@ class TreeTest extends TestCase
     protected function setUp(): void
     {
         $objectManager = new ObjectManager($this);
+
+        $objects = [
+            [
+                JsonHelper::class,
+                $this->createMock(JsonHelper::class)
+            ],
+            [
+                DirectoryHelper::class,
+                $this->createMock(DirectoryHelper::class)
+            ]
+        ];
+        $this->objectManager->prepareObjectManager($objects);
+
         $contextMock = $this->createMock(Context::class);
         $this->cmsWysiwygImagesMock = $this->createMock(Images::class);
         $this->coreRegistryMock = $this->createMock(Registry::class);
diff --git a/app/code/Magento/Cms/Test/Unit/Block/Widget/Page/LinkTest.php b/app/code/Magento/Cms/Test/Unit/Block/Widget/Page/LinkTest.php
@@ -9,7 +9,10 @@
 
 use Magento\Cms\Block\Widget\Page\Link;
 use Magento\Cms\Helper\Page;
+use Magento\Framework\Math\Random;
+use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use Magento\Framework\View\Helper\SecureHtmlRenderer;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -35,9 +38,26 @@ class LinkTest extends TestCase
      */
     protected $mockResourcePage;
 
+    /**
+     * @var ObjectManagerHelper
+     */
+    protected $objectManagerHelper;
+
     protected function setUp(): void
     {
         $this->objectManager = new ObjectManager($this);
+        $objects = [
+            [
+                SecureHtmlRenderer::class,
+                $this->createMock(SecureHtmlRenderer::class)
+            ],
+            [
+                Random::class,
+                $this->createMock(Random::class)
+            ]
+        ];
+        $this->objectManager->prepareObjectManager($objects);
+
         $this->mockCmsPage = $this->createMock(Page::class);
         $this->mockResourcePage = $this->createMock(\Magento\Cms\Model\ResourceModel\Page::class);
 
@@ -161,4 +181,22 @@ public function testGetLabelEmpty()
     {
         $this->assertEmpty($this->linkElement->getLabel());
     }
+
+//    /**
+//     * @param $map
+//     */
+//    private function prepareObjectManager($map)
+//    {
+//        $objectManagerMock = $this->getMockBuilder(ObjectManagerInterface::class)
+//            ->addMethods(['getInstance'])
+//            ->onlyMethods(['get'])
+//            ->getMockForAbstractClass();
+//
+//        $objectManagerMock->method('getInstance')->willReturnSelf();
+//        $objectManagerMock->method('get')->willReturnMap($map);
+//
+//        $reflectionProperty = new \ReflectionProperty(\Magento\Framework\App\ObjectManager::class, '_instance');
+//        $reflectionProperty->setAccessible(true);
+//        $reflectionProperty->setValue($objectManagerMock);
+//    }
 }
diff --git a/app/code/Magento/Cms/Test/Unit/Model/PageRepository/ValidationCompositeTest.php b/app/code/Magento/Cms/Test/Unit/Model/PageRepository/ValidationCompositeTest.php
@@ -16,6 +16,7 @@
 use Magento\Framework\Exception\LocalizedException;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Magento\Framework\EntityManager\HydratorInterface;
 
 /**
  * Validate behavior of the validation composite
@@ -27,10 +28,18 @@ class ValidationCompositeTest extends TestCase
      */
     private $subject;
 
+    /**
+     * @var HydratorInterface|MockObject
+     */
+    private $hydratorMock;
+
     protected function setUp(): void
     {
         /** @var PageRepositoryInterface subject */
         $this->subject = $this->getMockForAbstractClass(PageRepositoryInterface::class);
+
+        /** @var PageRepositoryInterface subject */
+        $this->hydratorMock = $this->getMockForAbstractClass(HydratorInterface::class);
     }
 
     /**
@@ -40,7 +49,7 @@ protected function setUp(): void
     public function testConstructorValidation($validators)
     {
         $this->expectException('InvalidArgumentException');
-        new ValidationComposite($this->subject, $validators);
+        new ValidationComposite($this->subject, $validators, $this->hydratorMock);
     }
 
     public function testSaveInvokesValidatorsWithSuccess()
@@ -66,7 +75,7 @@ public function testSaveInvokesValidatorsWithSuccess()
             ->with($page)
             ->willReturn('foo');
 
-        $composite = new ValidationComposite($this->subject, [$validator1, $validator2]);
+        $composite = new ValidationComposite($this->subject, [$validator1, $validator2], $this->hydratorMock);
         $result = $composite->save($page);
 
         self::assertSame('foo', $result);
@@ -97,7 +106,7 @@ public function testSaveInvokesValidatorsWithErrors()
             ->expects($this->never())
             ->method('save');
 
-        $composite = new ValidationComposite($this->subject, [$validator1, $validator2]);
+        $composite = new ValidationComposite($this->subject, [$validator1, $validator2], $this->hydratorMock);
         $composite->save($page);
     }
 
@@ -113,7 +122,7 @@ public function testPassthroughMethods($method, $arg)
             ->with($arg)
             ->willReturn('foo');
 
-        $composite = new ValidationComposite($this->subject, []);
+        $composite = new ValidationComposite($this->subject, [], $this->hydratorMock);
         $result = $composite->{$method}($arg);
 
         self::assertSame('foo', $result);
diff --git a/app/code/Magento/Cms/Test/Unit/Model/Template/FilterTest.php b/app/code/Magento/Cms/Test/Unit/Model/Template/FilterTest.php
diff --git a/lib/internal/Magento/Framework/TestFramework/Unit/Helper/ObjectManager.php b/lib/internal/Magento/Framework/TestFramework/Unit/Helper/ObjectManager.php
