ENGCOM-5923: Optimize performance by using isset() instead of in_array() #24677

Author: VladimirZaets

lib/internal/Magento/Framework/Module/ModuleList/Loader.php

@@ -78,6 +78,8 @@ public function __construct(
     public function load(array $exclude = [])
     {
         $result = [];
+        $excludeSet = array_flip($exclude);
+
         foreach ($this->getModuleConfigs() as list($file, $contents)) {
             try {
                 $this->parser->loadXML($contents);
@@ -93,7 +95,7 @@ public function load(array $exclude = [])
 
             $data = $this->converter->convert($this->parser->getDom());
             $name = key($data);
-            if (!in_array($name, $exclude)) {
+            if (!isset($excludeSet[$name])) {
                 $result[$name] = $data[$name];
             }
         }
@@ -140,15 +142,15 @@ private function sortBySequence(array $origList): array
 
             $expanded[] = [
                 'name' => $moduleName,
-                'sequence' => $sequence,
+                'sequence_set' => array_flip($sequence),
             ];
         }
 
         // Use "bubble sorting" because usort does not check each pair of elements and in this case it is important
         $total = count($expanded);
         for ($i = 0; $i < $total - 1; $i++) {
             for ($j = $i; $j < $total; $j++) {
-                if (in_array($expanded[$j]['name'], $expanded[$i]['sequence'], true)) {
+                if (isset($expanded[$i]['sequence_set'][$expanded[$j]['name']])) {
                     $temp = $expanded[$i];
                     $expanded[$i] = $expanded[$j];
                     $expanded[$j] = $temp;
@@ -196,18 +198,19 @@ private function prearrangeModules(array $modules): array
      */
     private function expandSequence($list, $name, $accumulated = [])
     {
-        $accumulated[] = $name;
+        $accumulated[$name] = true;
         $result = $list[$name]['sequence'];
+        $allResults = [];
         foreach ($result as $relatedName) {
-            if (in_array($relatedName, $accumulated)) {
-                throw new \Exception("Circular sequence reference from '{$name}' to '{$relatedName}'.");
+            if (isset($accumulated[$relatedName])) {
+                throw new \LogicException("Circular sequence reference from '{$name}' to '{$relatedName}'.");
             }
             if (!isset($list[$relatedName])) {
                 continue;
             }
-            $relatedResult = $this->expandSequence($list, $relatedName, $accumulated);
-            $result = array_unique(array_merge($result, $relatedResult));
+            $allResults[] = $this->expandSequence($list, $relatedName, $accumulated);
         }
-        return $result;
+        $allResults[] = $result;
+        return array_unique(array_merge(...$allResults));
     }
 }

lib/internal/Magento/Framework/Setup/Lists.php

@@ -96,9 +96,10 @@ public function getLocaleList()
         $languages = (new LanguageBundle())->get(Resolver::DEFAULT_LOCALE)['Languages'];
         $countries = (new RegionBundle())->get(Resolver::DEFAULT_LOCALE)['Countries'];
         $locales = \ResourceBundle::getLocales('') ?: [];
+        $allowedLocales = array_flip($this->allowedLocales);
         $list = [];
         foreach ($locales as $locale) {
-            if (!in_array($locale, $this->allowedLocales)) {
+            if (!isset($allowedLocales[$locale])) {
                 continue;
             }
             $language = \Locale::getPrimaryLanguage($locale);