MTO-145: [Constraint] Check order grid date filter

- Defects fixed.

Author: SiarheiAndreyeu

dev/tests/functional/tests/app/Magento/Checkout/Test/TestStep/GetDashboardOrderStep.php renamed to dev/tests/functional/tests/app/Magento/Backend/Test/TestStep/GetDashboardOrderStep.php

@@ -4,7 +4,7 @@
  * See COPYING.txt for license details.
  */
 
-namespace Magento\Checkout\Test\TestStep;
+namespace Magento\Backend\Test\TestStep;
 
 use Magento\Mtf\TestStep\TestStepInterface;
 use Magento\Backend\Test\Page\Adminhtml\Dashboard;

dev/tests/functional/tests/app/Magento/Reports/Test/Repository/ConfigData.xml

@@ -48,14 +48,5 @@
                 <item name="value" xsi:type="number">2</item>
             </field>
         </dataset>
-
-        <dataset name="notify_stock_quantity_2_rollback">
-            <field name="cataloginventory/item_options/notify_stock_qty" xsi:type="array">
-                <item name="scope" xsi:type="string">catalog</item>
-                <item name="scope_id" xsi:type="number">1</item>
-                <item name="label" xsi:type="string"/>
-                <item name="value" xsi:type="number">1</item>
-            </field>
-        </dataset>
     </repository>
 </config>

dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/LowStockProductsReportEntityTest.php

@@ -6,8 +6,7 @@
 
 namespace Magento\Reports\Test\TestCase;
 
-use Magento\Catalog\Test\Fixture\CatalogProductSimple;
-use Magento\Mtf\TestCase\Injectable;
+use Magento\Mtf\TestCase\Scenario;
 
 /**
  * Preconditions:
@@ -21,53 +20,19 @@
  * @group Reports
  * @ZephyrId MAGETWO-27193
  */
-class LowStockProductsReportEntityTest extends Injectable
+class LowStockProductsReportEntityTest extends Scenario
 {
     /* tags */
     const MVP = 'no';
     /* end tags */
 
     /**
-     * Configuration data
-     *
-     * @var string
-     */
-    private $configData;
-
-    /**
-     * Create product
-     *
-     * @param CatalogProductSimple $product
-     * @param string|null $configData
-     * @return void
-     */
-    public function test(CatalogProductSimple $product, $configData = null)
-    {
-        $this->configData = $configData;
-
-        if ($this->configData) {
-            $this->objectManager->create(
-                \Magento\Config\Test\TestStep\SetupConfigurationStep::class,
-                ['configData' => $this->configData, 'flushCache' => true]
-            )->run();
-        }
-
-        // Preconditions
-        $product->persist();
-    }
-
-    /**
-     * Clear data after test.
+     * Runs low stock products report test.
      *
      * @return void
      */
-    public function tearDown()
+    public function test()
     {
-        if ($this->configData) {
-            $this->objectManager->create(
-                \Magento\Config\Test\TestStep\SetupConfigurationStep::class,
-                ['configData' => $this->configData, 'rollback' => true, 'flushCache' => true]
-            )->run();
-        }
+        $this->executeScenario();
     }
 }

dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/LowStockProductsReportEntityTest.xml

@@ -9,8 +9,9 @@
     <testCase name="Magento\Reports\Test\TestCase\LowStockProductsReportEntityTest" summary="Generate &quot;Low Stock Products&quot; Report" ticketId="MAGETWO-27193">
         <variation name="LowStockProductsReportEntityTestVariation1" summary="Generate Low Stock Products Report and Set Notify for Quantity Below = 2" ticketId="MAGETWO-52213">
             <data name="issue" xsi:type="string">MAGETWO-62279: Low stock products report doesn't work</data>
-            <data name="product/dataset" xsi:type="string">low_stock_product</data>
+            <data name="product" xsi:type="string">catalogProductSimple::low_stock_product</data>
             <data name="configData" xsi:type="string">notify_stock_quantity_2</data>
+            <data name="flushCache" xsi:type="boolean">true</data>
             <constraint name="Magento\Reports\Test\Constraint\AssertLowStockProductInGrid" />
         </variation>
     </testCase>

dev/tests/functional/tests/app/Magento/Reports/Test/etc/testcase.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/Magento/Mtf/TestCase/etc/testcase.xsd">
+    <scenario name="LowStockProductsReportEntityTest" firstStep="setupConfiguration">
+        <step name="setupConfiguration" module="Magento_Config" next="createProduct" />
+        <step name="createProduct" module="Magento_Catalog" />
+    </scenario>
+</config>

dev/tests/functional/tests/app/Magento/Sales/Test/Constraint/AssertInvoicedOrderOnDashboard.php

@@ -8,49 +8,38 @@
 
 use Magento\Mtf\Constraint\AbstractConstraint;
 use Magento\Mtf\TestStep\TestStepFactory;
-use Magento\Backend\Test\Page\Adminhtml\Dashboard;
 
 /**
  * Assert invoiced order on admin dashboard.
  */
 class AssertInvoicedOrderOnDashboard extends AbstractConstraint
 {
     /**
-     * Invoiced orders quantity.
-     */
-    const EXPECTED_ORDERS_QTY = 1;
-
-    /**
-     * Assert orders quantity and graph image visibility on admin dashboard.
+     * Assert orders quantity on admin dashboard.
      *
      * @param TestStepFactory $stepFactory
-     * @param Dashboard $dashboard
      * @param array $dashboardOrder
      * @param array $argumentsList
+     * @param int $expectedOrdersQuantityOnDashboard
      * @return void
      */
     public function processAssert(
         TestStepFactory $stepFactory,
-        Dashboard $dashboard,
         array $dashboardOrder,
-        array $argumentsList
+        array $argumentsList,
+        $expectedOrdersQuantityOnDashboard
     ) {
         $orderQty = $stepFactory->create(
-            \Magento\Checkout\Test\TestStep\GetDashboardOrderStep::class,
+            \Magento\Backend\Test\TestStep\GetDashboardOrderStep::class,
             ['argumentsList' => $argumentsList]
         )->run()['dashboardOrder']['quantity'];
         $invoicedOrdersQty = $orderQty - $dashboardOrder['quantity'];
 
         \PHPUnit_Framework_Assert::assertEquals(
             $invoicedOrdersQty,
-            self::EXPECTED_ORDERS_QTY,
+            $expectedOrdersQuantityOnDashboard,
             'Order quantity om admin dashboard is not correct.'
         );
-
-        \PHPUnit_Framework_Assert::assertTrue(
-            $dashboard->getMainBlock()->isGraphImageVisible(),
-            'Graph image is not visible on admin dashboard.'
-        );
     }
 
     /**

dev/tests/functional/tests/app/Magento/Sales/Test/Constraint/AssertOrderGraphImageIsVisible.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Sales\Test\Constraint;
+
+use Magento\Mtf\Constraint\AbstractConstraint;
+use Magento\Mtf\TestStep\TestStepFactory;
+use Magento\Backend\Test\Page\Adminhtml\Dashboard;
+
+/**
+ * Assert order graph image is visible on admin dashboard.
+ */
+class AssertOrderGraphImageIsVisible extends AbstractConstraint
+{
+    /**
+     * Assert order graph image is visible on admin dashboard.
+     *
+     * @param TestStepFactory $stepFactory
+     * @param Dashboard $dashboard
+     * @param array $argumentsList
+     * @return void
+     */
+    public function processAssert(
+        TestStepFactory $stepFactory,
+        Dashboard $dashboard,
+        array $argumentsList
+    ) {
+        $stepFactory->create(
+            \Magento\Backend\Test\TestStep\GetDashboardOrderStep::class,
+            ['argumentsList' => $argumentsList]
+        )->run();
+
+        \PHPUnit_Framework_Assert::assertTrue(
+            $dashboard->getMainBlock()->isGraphImageVisible(),
+            'Graph image is not visible on admin dashboard.'
+        );
+    }
+
+    /**
+     * Returns string representation of successful assertion.
+     *
+     * @return string
+     */
+    public function toString()
+    {
+        return 'Order graph image is visible on the dashboard.';
+    }
+}