Skip to content

Commit 0724c0c

Browse files
Fixed failed test
1 parent 5a51254 commit 0724c0c

File tree

5 files changed

+9
-4
lines changed

5 files changed

+9
-4
lines changed

app/code/Magento/Indexer/Controller/Adminhtml/Indexer/MassChangelog.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public function execute()
4141

4242
$this->messageManager->addSuccessMessage(
4343
__(
44-
'%1 indexer(s) have been updated to "Update by Schedule" mode. %2 skipped because there was nothing to change.',
44+
'%1 indexer(s) have been updated to "Update by Schedule" mode.
45+
%2 skipped because there was nothing to change.',
4546
$updatedIndexersCount,
4647
count($indexerIds) - $updatedIndexersCount
4748
)

app/code/Magento/Indexer/Controller/Adminhtml/Indexer/MassOnTheFly.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public function execute()
4141

4242
$this->messageManager->addSuccessMessage(
4343
__(
44-
'%1 indexer(s) have been updated to "Update on Save" mode. %2 skipped because there was nothing to change.',
44+
'%1 indexer(s) have been updated to "Update on Save" mode.
45+
%2 skipped because there was nothing to change.',
4546
$updatedIndexersCount,
4647
count($indexerIds) - $updatedIndexersCount
4748
)

app/code/Magento/Indexer/Test/Mftf/ActionGroup/AdminSwitchAllIndexerToActionModeActionGroup.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,15 @@
1111
<actionGroup name="AdminSwitchAllIndexerToActionModeActionGroup">
1212
<arguments>
1313
<argument name="action" type="string" defaultValue="Update by Schedule"/>
14+
<!-- <argument name="count" type="string" defaultValue="10"/> -->
1415
</arguments>
1516
<amOnPage url="{{AdminIndexManagementPage.url}}" stepKey="onIndexManagement"/>
1617
<waitForPageLoad stepKey="waitForManagementPage"/>
1718
<selectOption userInput="selectAll" selector="{{AdminIndexManagementSection.selectMassAction}}" stepKey="checkIndexer"/>
1819
<selectOption userInput="{{action}}" selector="{{AdminIndexManagementSection.massActionSelect}}" stepKey="selectAction"/>
20+
<grabValueFrom selector="{{AdminIndexManagementSection.massIndexSelectionCount}}" stepKey="selectCount"/>
1921
<click selector="{{AdminIndexManagementSection.massActionSubmit}}" stepKey="clickSubmit"/>
2022
<waitForPageLoad stepKey="waitForSubmit"/>
21-
<see userInput="indexer(s) are in &quot;{{action}}&quot; mode." stepKey="seeMessage"/>
23+
<see userInput="{$selectCount} indexer(s) have been updated to &quot;{{action}}&quot; mode. 0 skipped because there was nothing to change." stepKey="seeMessage"/>
2224
</actionGroup>
2325
</actionGroups>

app/code/Magento/Indexer/Test/Mftf/ActionGroup/AdminSwitchIndexerToActionModeActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
<selectOption userInput="{{action}}" selector="{{AdminIndexManagementSection.massActionSelect}}" stepKey="selectAction"/>
1818
<click selector="{{AdminIndexManagementSection.massActionSubmit}}" stepKey="clickSubmit"/>
1919
<waitForPageLoad stepKey="waitForSubmit"/>
20-
<see selector="{{AdminIndexManagementSection.successMessage}}" userInput="1 indexer(s) are in &quot;{{action}}&quot; mode." stepKey="seeMessage"/>
20+
<see selector="{{AdminIndexManagementSection.successMessage}}" userInput="1 indexer(s) have been updated to &quot;{{action}}&quot; mode. 0 skipped because there was nothing to change." stepKey="seeMessage"/>
2121
</actionGroup>
2222
</actionGroups>

app/code/Magento/Indexer/Test/Mftf/Section/AdminIndexManagementSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,6 @@
1919
<element name="selectMassAction" type="select" selector="#gridIndexer_massaction-mass-select"/>
2020
<element name="columnScheduleStatus" type="text" selector="//th[contains(@class, 'col-indexer_schedule_status')]"/>
2121
<element name="indexerScheduleStatus" type="text" selector="//tr[contains(.,'{{var1}}')]//td[contains(@class,'col-indexer_schedule_status')]" parameterized="true"/>
22+
<element name="massIndexSelectionCount" type="text" selector="#gridIndexer-total-count"/>
2223
</section>
2324
</sections>

0 commit comments

Comments
 (0)