Skip to content

Commit 084c6de

Browse files
ACPT-987
Added support for multiple files for skip and filter lists
1 parent 00abf6a commit 084c6de

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

dev/tests/integration/testsuite/Magento/GraphQl/App/State/Comparator.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,11 @@ private function filterProperties($properties, $propertiesToFilterList): array
148148
private function getSkipList($operationName): array
149149
{
150150
if ($this->skipList === null) {
151-
$this->skipList = include __DIR__ . '/../../_files/state-skip-list.php';
151+
$skipListList = [];
152+
foreach (glob(__DIR__ . '/../../_files/state-skip-list*.php') as $skipListFile) {
153+
$skipListList[] = include($skipListFile);
154+
}
155+
$this->skipList = array_merge_recursive(...$skipListList);
152156
}
153157
return array_merge($this->skipList['*'], $this->skipList[$operationName] ?? []);
154158
}
@@ -161,7 +165,11 @@ private function getSkipList($operationName): array
161165
private function getFilterList(): array
162166
{
163167
if ($this->filterList === null) {
164-
$this->filterList = include __DIR__ . '/../../_files/state-filter-list.php';
168+
$filterListList = [];
169+
foreach (glob(__DIR__ . '/../../_files/state-filter-list*.php') as $filterListFile) {
170+
$filterListList[] = include($filterListFile);
171+
}
172+
$this->filterList = array_merge_recursive(...$filterListList);
165173
}
166174
return $this->filterList;
167175
}

dev/tests/integration/testsuite/Magento/GraphQl/_files/state-filter-list.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
Magento\Framework\View\Template\Html\Minifier::class => ['filesystem' => null],
6767
Magento\Store\Model\Config\Processor\Fallback::class => ['scopes' => null],
6868
'viewFileFallbackResolver' => ['rulePool' => null],
69-
Magento\Staging\Model\Preview\RouteParamsPreprocessor::class => ['request' => null],
7069
Magento\Framework\View\Asset\Source::class => ['filesystem' => null],
7170
Magento\Store\Model\StoreResolver::class => ['request' => null],
7271
Magento\Framework\Url\Decoder::class => ['urlBuilder' => null],
@@ -77,9 +76,7 @@
7776
'_request' => null,
7877
'_urlBuilder' => null,
7978
],
80-
Magento\Staging\Model\Url\BaseUrlModifier::class => ['request' => null, 'state' => null],
8179
Magento\Framework\Event\Config::class => ['_dataContainer' => null],
82-
Magento\Staging\Plugin\Store\Model\StoreResolver::class => ['request' => null],
8380
Magento\TestFramework\Store\StoreManager::class => ['decoratedStoreManager' => null],
8481
Magento\Eav\Model\ResourceModel\Entity\Attribute::class => ['_eavEntityType' => null],
8582
Magento\Eav\Model\Entity\AttributeLoader::class => ['defaultAttributes' => null, 'config' => null],
@@ -90,8 +87,6 @@
9087
Magento\Framework\Model\Context::class => ['_cacheManager' => null, '_appState' => null],
9188
Magento\Framework\App\Cache\TypeList::class => ['_cache' => null],
9289
Magento\GraphQlCache\Model\CacheId\CacheIdCalculator::class => ['contextFactory' => null],
93-
Magento\VersionsCmsUrlRewriteGraphQl\Plugin\UrlRewriteGraphQl\Model\UrlRewrite\HierarchyNodeUrlLocator::class
94-
=> ['contextFactory' => null],
9590
Magento\Store\Model\Config\Placeholder::class => ['request' => null],
9691
Magento\Framework\Config\Scope::class => ['_areaList' => null], // These were added because we switched to ...
9792
Magento\TestFramework\App\State::class => ['_areaCode' => null], // .

dev/tests/integration/testsuite/Magento/GraphQl/_files/state-skip-list.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
Magento\Framework\Url\QueryParamsResolver::class => null,
4141
Magento\Framework\Event\Config\Data::class => null, // TODO: Make sure this is reset when config is reset from poison pill
4242
Magento\Framework\App\AreaList::class => null,
43-
customRemoteFilesystem::class => null,
43+
'customRemoteFilesystem' => null,
4444
Magento\Store\App\Config\Type\Scopes::class => null,
4545
Magento\Framework\Module\Dir\Reader::class => null,
4646
Magento\Framework\App\Language\Dictionary::class => null,
@@ -49,10 +49,8 @@
4949
Magento\Framework\App\Cache\Type\Config::class => null,
5050
Magento\Framework\Interception\PluginListGenerator::class => null,
5151
Magento\TestFramework\App\Config::class => null,
52-
Magento\ApplicationServer\App\RequestProxy::class => null,
5352
Magento\TestFramework\Request::class => null,
5453
Magento\Framework\View\FileSystem::class => null,
55-
Magento\ApplicationServer\App\CookieManager::class => null,
5654
Magento\Framework\App\Config\FileResolver::class => null,
5755
Magento\Framework\Module\Manager::class => null,
5856
Magento\Framework\Logger\LoggerProxy::class => null,

0 commit comments

Comments
 (0)