MC-33420: PayPal button disappears when enable Customize Button

Author: irenelagno

app/code/Magento/Paypal/Setup/Patch/Data/UpdateSmartButtonLabel.php

@@ -16,16 +16,6 @@
  */
 class UpdateSmartButtonLabel implements DataPatchInterface, PatchVersionInterface
 {
-    /**
-     * @var array
-     */
-    private $labelSettingsToUpdate = [
-        'paypal/style/checkout_page_button_label',
-        'paypal/style/cart_page_button_label',
-        'paypal/style/mini_cart_page_button_label',
-        'paypal/style/product_page_button_label',
-    ];
-
     /**
      * @var ModuleDataSetupInterface
      */
@@ -47,26 +37,26 @@ public function __construct(
     public function apply()
     {
         $this->moduleDataSetup->getConnection()->startSetup();
-        $connection = $this->moduleDataSetup->getConnection();
-
-        $select = $connection->select()
-            ->from($this->moduleDataSetup->getTable('core_config_data'), ['path','scope', 'scope_id', 'value'])
-            ->where('path IN (?)', $this->labelSettingsToUpdate)
-            ->where('value = ?', 'credit');
-
-        foreach ($connection->fetchAll($select) as $pair) {
-            $value = $pair['path'] === 'paypal/style/product_page_button_label' ? 'buynow' : 'paypal';
-            $this->moduleDataSetup->getConnection()
-                ->insertOnDuplicate(
-                    $this->moduleDataSetup->getTable('core_config_data'),
-                    [
-                        'scope' => $pair['scope'],
-                        'scope_id' => $pair['scope_id'],
-                        'path' => $pair['path'],
-                        'value' => $value
-                    ]
-                );
-        }
+        $this->moduleDataSetup->getConnection()->update(
+            $this->moduleDataSetup->getTable('core_config_data'),
+            ['value' => 'paypal'],
+            [
+                'path IN (?)' => [
+                    'paypal/style/checkout_page_button_label',
+                    'paypal/style/cart_page_button_label',
+                    'paypal/style/mini_cart_page_button_label'
+                ],
+                'value = ? ' => 'credit'
+            ]
+        );
+        $this->moduleDataSetup->getConnection()->update(
+            $this->moduleDataSetup->getTable('core_config_data'),
+            ['value' => 'buynow'],
+            [
+                'path IN (?)' => ['paypal/style/product_page_button_label'],
+                'value = ? ' => 'credit'
+            ]
+        );
         return $this->moduleDataSetup->getConnection()->endSetup();
     }
 

app/code/Magento/Paypal/Setup/Patch/Data/UpdateSmartButtonSize.php

@@ -47,24 +47,14 @@ public function __construct(
     public function apply()
     {
         $this->moduleDataSetup->getConnection()->startSetup();
-        $connection = $this->moduleDataSetup->getConnection();
-
-        $select = $connection->select()
-            ->from($this->moduleDataSetup->getTable('core_config_data'), ['path','scope', 'scope_id', 'value'])
-            ->where('path IN (?)', $this->sizeSettingsToUpdate)
-            ->where('value = \'large\' OR value=\'medium\'');
-        foreach ($connection->fetchAll($select) as $pair) {
-            $this->moduleDataSetup->getConnection()
-                ->insertOnDuplicate(
-                    $this->moduleDataSetup->getTable('core_config_data'),
-                    [
-                        'scope' => $pair['scope'],
-                        'scope_id' => $pair['scope_id'],
-                        'path' => $pair['path'],
-                        'value' => 'responsive'
-                    ]
-                );
-        }
+        $this->moduleDataSetup->getConnection()->update(
+            $this->moduleDataSetup->getTable('core_config_data'),
+            ['value' => 'responsive'],
+            [
+                'path IN (?)' => $this->sizeSettingsToUpdate,
+                'value NOT IN (?) ' => ['responsive']
+            ]
+        );
         return $this->moduleDataSetup->getConnection()->endSetup();
     }