Skip to content

Commit 0a559c7

Browse files
committed
remove redundant methods
1 parent 878b1c9 commit 0a559c7

File tree

2 files changed

+17
-25
lines changed
  • app/code/Magento

2 files changed

+17
-25
lines changed

app/code/Magento/AsynchronousOperations/Controller/Adminhtml/Index/Index.php

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@
66

77
namespace Magento\AsynchronousOperations\Controller\Adminhtml\Index;
88

9-
class Index extends \Magento\Backend\App\Action
9+
use Magento\Backend\App\Action;
10+
use Magento\Backend\App\Action\Context;
11+
use Magento\Framework\View\Result\Page;
12+
use Magento\Framework\View\Result\PageFactory;
13+
14+
class Index extends Action
1015
{
1116
/**
1217
* Authorization level of a basic admin session
@@ -16,7 +21,7 @@ class Index extends \Magento\Backend\App\Action
1621
const ADMIN_RESOURCE = 'Magento_Logging::system_magento_logging_bulk_operations';
1722

1823
/**
19-
* @var \Magento\Framework\View\Result\PageFactory
24+
* @var PageFactory
2025
*/
2126
private $resultPageFactory;
2227

@@ -27,32 +32,25 @@ class Index extends \Magento\Backend\App\Action
2732

2833
/**
2934
* Details constructor.
30-
* @param \Magento\Backend\App\Action\Context $context
31-
* @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
35+
*
36+
* @param Context $context
37+
* @param PageFactory $resultPageFactory
3238
* @param string $menuId
3339
*/
3440
public function __construct(
35-
\Magento\Backend\App\Action\Context $context,
36-
\Magento\Framework\View\Result\PageFactory $resultPageFactory,
41+
Context $context,
42+
PageFactory $resultPageFactory,
3743
$menuId = 'Magento_AsynchronousOperations::system_magento_logging_bulk_operations'
3844
) {
3945
$this->resultPageFactory = $resultPageFactory;
4046
$this->menuId = $menuId;
4147
parent::__construct($context);
4248
}
4349

44-
/**
45-
* @inheritDoc
46-
*/
47-
protected function _isAllowed()
48-
{
49-
return parent::_isAllowed();
50-
}
51-
5250
/**
5351
* Bulk list action
5452
*
55-
* @return \Magento\Framework\View\Result\Page
53+
* @return Page
5654
*/
5755
public function execute()
5856
{

app/code/Magento/Sales/Block/Adminhtml/Order/Create/Newsletter.php

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,16 @@
55
*/
66
namespace Magento\Sales\Block\Adminhtml\Order\Create;
77

8+
use Magento\Framework\Phrase;
9+
810
/**
911
* Adminhtml sales order create newsletter block
1012
*
1113
* @api
1214
* @author Magento Core Team <[email protected]>
1315
* @since 100.0.2
1416
*/
15-
class Newsletter extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
17+
class Newsletter extends AbstractCreate
1618
{
1719
/**
1820
* Constructor
@@ -28,7 +30,7 @@ protected function _construct()
2830
/**
2931
* Get header text
3032
*
31-
* @return \Magento\Framework\Phrase
33+
* @return Phrase
3234
*/
3335
public function getHeaderText()
3436
{
@@ -44,12 +46,4 @@ public function getHeaderCssClass()
4446
{
4547
return 'head-newsletter-list';
4648
}
47-
48-
/**
49-
* {@inheritdoc}
50-
*/
51-
protected function _toHtml()
52-
{
53-
return parent::_toHtml();
54-
}
5549
}

0 commit comments

Comments
 (0)