Unit Test with data provider

Author: edenduong

app/code/Magento/Persistent/Test/Unit/Helper/SessionTest.php

@@ -90,98 +90,111 @@ protected function setUp()
             ->getMock();
     }
 
-    /***
-     * Test isPersistent() when the session has id and enable persistent
-     */
-    public function testIsPersistentWhenSessionId()
-    {
-        $this->session->expects($this->any())->method('getId')
-            ->willReturn(1);
-        $this->helper->expects($this->any())->method('getSession')
-            ->willReturn($this->session);
-        $this->dataHelper->expects($this->any())->method('isEnabled')
-            ->willReturn(true);
-
-        $this->assertEquals(true, $this->helper->isPersistent());
-    }
-
-    /***
-     * Test isPersistent() when the no session id and enable persistent
+    /**
+     * Test isPersistent() function
+     *
+     * @param int|null $id
+     * @param boolean $isEnabled
+     * @param boolean $expected
+     * @dataProvider isPersistentDataProvider
      */
-    public function testIsPersistentWhenNoSessionId()
+    public function testIsPersistent($id, $isEnabled, $expected)
     {
         $this->session->expects($this->any())->method('getId')
-            ->willReturn(null);
+            ->willReturn($id);
         $this->helper->expects($this->any())->method('getSession')
             ->willReturn($this->session);
         $this->dataHelper->expects($this->any())->method('isEnabled')
-            ->willReturn(true);
+            ->willReturn($isEnabled);
 
-        $this->assertEquals(false, $this->helper->isPersistent());
+        $this->assertEquals($expected, $this->helper->isPersistent());
     }
 
     /**
-     * Test isRememberMeChecked() when enable all config
+     * Data Provider for test isPersistent()
+     *
+     * @return array
      */
-    public function testIsRememberMeCheckedWhenEnabledAll()
+    public function isPersistentDataProvider()
     {
-        $testCase = [
-            'dataset' => [
-                'enabled' => true,
-                'remember_me_enabled' => true,
-                'remember_me_checked_default' => true
+        return [
+            'session_id_and_enable_persistent' => [
+                1,
+                true,
+                true
             ],
-            'expected' => true
+            'no_session_id_and_enable_persistent' => [
+                null,
+                true,
+                false
+            ]
         ];
-        $this->executeTestIsRememberMeChecked($testCase);
     }
 
     /**
-     * Test isRememberMeChecked() when config persistent is disabled
+     * Test isRememberMeChecked() function
+     *
+     * @param boolean|null $checked
+     * @param boolean $isEnabled
+     * @param boolean $isRememberMeEnabled
+     * @param boolean $isRememberMeCheckedDefault
+     * @param boolean $expected
+     * @dataProvider isRememberMeCheckedProvider
      */
-    public function testIsRememberMeCheckedWhenAtLeastOnceDisabled()
-    {
-        $testCase = [
-            'dataset' => [
-                'enabled' => false,
-                'remember_me_enabled' => true,
-                'remember_me_checked_default' => true
-            ],
-            'expected' => false
-        ];
-        $this->executeTestIsRememberMeChecked($testCase);
-    }
+    public function testIsRememberMeChecked(
+        $checked,
+        $isEnabled,
+        $isRememberMeEnabled,
+        $isRememberMeCheckedDefault,
+        $expected
+    ) {
+        $this->helper->setRememberMeChecked($checked);
+        $this->dataHelper->expects($this->any())->method('isEnabled')
+            ->willReturn($isEnabled);
+        $this->dataHelper->expects($this->any())->method('isRememberMeEnabled')
+            ->willReturn($isRememberMeEnabled);
+        $this->dataHelper->expects($this->any())->method('isRememberMeCheckedDefault')
+            ->willReturn($isRememberMeCheckedDefault);
 
-    /**
-     * Test isRememberMeChecked() when setRememberMeChecked(false)
-     */
-    public function testIsRememberMeCheckedWhenSetValue()
-    {
-        $testCase = [
-            'dataset' => [
-                'enabled' => true,
-                'remember_me_enabled' => true,
-                'remember_me_checked_default' => true
-            ],
-            'expected' => false
-        ];
-        $this->helper->setRememberMeChecked(false);
-        $this->executeTestIsRememberMeChecked($testCase);
+        $this->assertEquals($expected, $this->helper->isRememberMeChecked());
     }
 
     /**
-     * Execute test isRememberMeChecked() function
+     * Data Provider for test isRememberMeChecked()
      *
-     * @param array $testCase
+     * @return array
      */
-    public function executeTestIsRememberMeChecked($testCase)
+    public function isRememberMeCheckedProvider()
     {
-        $this->dataHelper->expects($this->any())->method('isEnabled')
-            ->willReturn($testCase['dataset']['enabled']);
-        $this->dataHelper->expects($this->any())->method('isRememberMeEnabled')
-            ->willReturn($testCase['dataset']['remember_me_enabled']);
-        $this->dataHelper->expects($this->any())->method('isRememberMeCheckedDefault')
-            ->willReturn($testCase['dataset']['remember_me_checked_default']);
-        $this->assertEquals($testCase['expected'], $this->helper->isRememberMeChecked());
+        return [
+            'enable_all_config' => [
+                null,
+                true,
+                true,
+                true,
+                true
+            ],
+            'at_least_once_disabled' => [
+                null,
+                false,
+                true,
+                true,
+                false
+            ],
+            'set_remember_me_checked_false' => [
+                false,
+                true,
+                true,
+                true,
+                false
+            ],
+            'set_remember_me_checked_true' => [
+                true,
+                false,
+                true,
+                true,
+                true
+            ]
+        ];
     }
 }