Skip to content

Commit 0c525b1

Browse files
committed
ACPT-826
1 parent 48cd482 commit 0c525b1

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

app/code/Magento/AsyncConfig/Model/AsyncConfigPublisher.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public function saveConfigData(array $configData)
7575
}
7676

7777
/**
78-
* Change Placeholder Data path if exists
78+
* Save Images to temporary Path
7979
*
8080
* @param array $configData
8181
* @return void

app/code/Magento/AsyncConfig/Plugin/Controller/System/Config/SaveAsyncConfigPlugin.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
namespace Magento\AsyncConfig\Plugin\Controller\System\Config;
99

1010
use Magento\AsyncConfig\Api\AsyncConfigPublisherInterface;
11+
use Magento\AsyncConfig\Setup\ConfigOptionsList;
1112
use Magento\Config\Controller\Adminhtml\System\Config\Save;
1213
use Magento\Framework\App\DeploymentConfig;
1314
use Magento\Framework\App\ObjectManager;
@@ -39,11 +40,6 @@ class SaveAsyncConfigPlugin
3940
*/
4041
private $messageManager;
4142

42-
/**
43-
* @var const
44-
*/
45-
public const ASYNC_CONFIG_OPTION_PATH = 'config/async';
46-
4743
/**
4844
*
4945
* @param DeploymentConfig|null $deploymentConfig
@@ -77,12 +73,12 @@ public function __construct(
7773
*/
7874
public function aroundExecute(Save $subject, callable $proceed)
7975
{
80-
if (!$this->deploymentConfig->get(self::ASYNC_CONFIG_OPTION_PATH)) {
76+
if (!$this->deploymentConfig->get(ConfigOptionsList::CONFIG_PATH_ASYNC_CONFIG_SAVE)) {
8177
return $proceed();
8278
} else {
8379
$configData = $subject->getConfigData();
8480
$this->asyncConfigPublisher->saveConfigData($configData);
85-
$this->messageManager->addSuccess(__('Configuration changes will be applied by consumer soon.'));
81+
$this->messageManager->addSuccessMessage(__('Configuration changes will be applied by consumer soon.'));
8682
$subject->_saveState($subject->getRequest()->getPost('config_state'));
8783
/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
8884
$resultRedirect = $this->resultRedirectFactory->create();

app/code/Magento/Config/Controller/Adminhtml/System/AbstractConfig.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,15 @@ abstract class AbstractConfig extends \Magento\Backend\App\AbstractAction
2323
*
2424
* @see _isAllowed()
2525
*/
26-
public const ADMIN_RESOURCE = 'Magento_Config::config';
26+
const ADMIN_RESOURCE = 'Magento_Config::config';
2727

2828
/**
2929
* @var \Magento\Config\Model\Config\Structure
3030
*/
3131
protected $_configStructure;
3232

3333
/**
34-
* @var mixed
3534
* @deprecated 101.0.0
36-
* @see Nothing
3735
*/
3836
protected $_sectionChecker;
3937

app/code/Magento/Config/Controller/Adminhtml/System/Config/Save.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function __construct(
5959

6060
/**
6161
* phpcs:disable Generic.CodeAnalysis.UselessOverridingMethod
62-
* @inheritDoc
62+
* {@inheritdoc}
6363
*/
6464
public function _saveState($configState = []): bool
6565
{

0 commit comments

Comments
 (0)