MC-41001: CAPTCHA fields not displaying after unsuccessful number of attempts in Checkout for 3rd-party payment providers

Author: victor-v-rad

app/code/Magento/Captcha/Plugin/FrontendOrderPlacementPlugin.php renamed to app/code/Magento/Captcha/Plugin/ResetPaymentAttemptsAfterOrderIsPlacedPlugin.php

@@ -13,7 +13,7 @@
 /**
  * Reset attempts for frontend checkout
  */
-class FrontendOrderPlacementPlugin
+class ResetPaymentAttemptsAfterOrderIsPlacedPlugin
 {
     /**
      * Form ID
@@ -23,15 +23,15 @@ class FrontendOrderPlacementPlugin
     /**
      * @var HelperCaptcha
      */
-    private HelperCaptcha $helper;
+    private $helper;
 
     /**
      * @var LogFactory
      */
     private $resLogFactory;
 
     /**
-     * ResetAttemptForFrontendAccountEditObserver constructor
+     * ResetPaymentAttemptsAfterOrderIsPlacedPlugin constructor
      *
      * @param HelperCaptcha $helper
      * @param LogFactory $resLogFactory

app/code/Magento/Captcha/Test/Unit/Plugin/FrontendOrderPlacementPluginTest.php renamed to app/code/Magento/Captcha/Test/Unit/Plugin/ResetPaymentAttemptsAfterOrderIsPlacedPluginTest.php

@@ -10,17 +10,17 @@
 
 use Magento\Captcha\Model\ResourceModel\Log;
 use Magento\Captcha\Model\ResourceModel\LogFactory;
-use Magento\Captcha\Plugin\FrontendOrderPlacementPlugin;
+use Magento\Captcha\Plugin\ResetPaymentAttemptsAfterOrderIsPlacedPlugin;
 use Magento\Captcha\Helper\Data as HelperCaptcha;
 use Magento\Captcha\Model\DefaultModel;
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Api\OrderManagementInterface;
 use PHPUnit\Framework\TestCase;
 
 /**
- * Unit test for \Magento\Captcha\Observer\FrontendOrderPlacementPluginTest
+ * Unit test for ResetPaymentAttemptsAfterOrderIsPlacedPluginTest
  */
-class FrontendOrderPlacementPluginTest extends TestCase
+class ResetPaymentAttemptsAfterOrderIsPlacedPluginTest extends TestCase
 {
     /**
      * Test that the method resets attempts for frontend checkout
@@ -39,7 +39,7 @@ public function testExecuteExpectsDeleteUserAttemptsCalled()
         $logMock->expects($this->once())->method('deleteUserAttempts')->willReturnSelf();
         $resLogFactoryMock = $this->createMock(LogFactory::class);
         $resLogFactoryMock->expects($this->once())->method('create')->willReturn($logMock);
-        $observer = new FrontendOrderPlacementPlugin($helperCaptchaMock, $resLogFactoryMock);
+        $observer = new ResetPaymentAttemptsAfterOrderIsPlacedPlugin($helperCaptchaMock, $resLogFactoryMock);
         $observer->afterPlace($orderManagementInterfaceMock, $resultOrderMock, $orderMock);
     }
 }

app/code/Magento/Captcha/etc/frontend/di.xml

@@ -35,6 +35,6 @@
         </arguments>
     </type>
     <type name="Magento\Sales\Api\OrderManagementInterface">
-        <plugin name="frontend_order_placement_reset_captcha_attempt" type="Magento\Captcha\Plugin\FrontendOrderPlacementPlugin"/>
+        <plugin name="reset_payment_attempts_after_order_is_placed_plugin" type="Magento\Captcha\Plugin\ResetPaymentAttemptsAfterOrderIsPlacedPlugin"/>
     </type>
 </config>

app/code/Magento/Captcha/etc/webapi_rest/di.xml

@@ -7,6 +7,6 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
     <type name="Magento\Sales\Api\OrderManagementInterface">
-        <plugin name="frontend_order_placement_reset_captcha_attempt" type="Magento\Captcha\Plugin\FrontendOrderPlacementPlugin"/>
+        <plugin name="reset_payment_attempts_after_order_is_placed_plugin" type="Magento\Captcha\Plugin\ResetPaymentAttemptsAfterOrderIsPlacedPlugin"/>
     </type>
 </config>