fixes for magento automation testing v4

Author: Krishna Kumar

app/code/Magento/LoginAsCustomerGraphQl/Model/LoginAsCustomer/CreateCustomerToken.php

@@ -11,8 +11,8 @@
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Integration\Model\Oauth\TokenFactory;
-use Magento\Setup\Exception;
 use Magento\Store\Model\StoreManagerInterface;
+use Exception;
 
 /**
  * Create customer token from customer email

app/code/Magento/LoginAsCustomerGraphQl/Model/Resolver/RequestCustomerToken.php

@@ -12,14 +12,14 @@
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\GraphQl\Config\Element\Field;
 use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException;
+use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
 use Magento\Framework\GraphQl\Query\Resolver\ContextInterface;
 use Magento\Framework\GraphQl\Query\Resolver\Value;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 use Magento\LoginAsCustomerApi\Api\ConfigInterface as LoginAsCustomerConfig;
 use Magento\LoginAsCustomerGraphQl\Model\LoginAsCustomer\CreateCustomerToken;
-use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 
 /**
  * Gets customer token
@@ -29,17 +29,17 @@ class RequestCustomerToken implements ResolverInterface
     /**
      * @var LoginAsCustomerConfig
      */
-    private LoginAsCustomerConfig $config;
+    private $config;
 
     /**
      * @var AuthorizationInterface
      */
-    private AuthorizationInterface $authorization;
+    private $authorization;
 
     /**
      * @var CreateCustomerToken
      */
-    private CreateCustomerToken $createCustomerToken;
+    private $createCustomerToken;
 
     /**
      * RequestCustomerToken constructor.
@@ -67,7 +67,7 @@ public function __construct(
      * @param array|null $args
      * @return Value|mixed|void
      * @throws GraphQlAuthorizationException|GraphQlNoSuchEntityException|LocalizedException
-     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function resolve(
         Field $field,

app/code/Magento/LoginAsCustomerGraphQl/composer.json

@@ -2,8 +2,11 @@
     "name": "magento/module-login-as-customer-graph-ql",
     "description": "Flexible login as a customer so a merchant or merchant admin can log into an end customer's account to assist them with their account.",
     "require": {
-        "php": "~7.4.0",
+        "php": "~7.3.0||~7.4.0",
         "magento/framework": "102.0.*",
+        "magento/module-login-as-customer-api": "100.4.*",
+        "magento/module-integration": "100.4.*",
+        "magento/module-store": "101.1.*",
         "magento/module-customer": "103.0.*",
         "magento/module-catalog-graph-ql": "100.4.*",
         "magento/framework": "103.0.*"

dev/tests/api-functional/testsuite/Magento/GraphQl/LoginAsCustomer/GenerateLoginCustomerTokenTest.php

@@ -41,8 +41,8 @@ protected function setUp(): void
      * Verify with Admin email ID and Magento_LoginAsCustomer::login is enabled
      *
      * @magentoApiDataFixture Magento/LoginAsCustomer/_files/admin.php
+     * @magentoApiDataFixture Magento/LoginAsCustomer/_files/login_as_customer_config_enable.php
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
-     * @magentoConfigFixture default_store login_as_customer/general/enabled 1
      * @throws Exception
      */
     public function testGenerateCustomerValidTokenLoginAsCustomerEnabled()
@@ -65,15 +65,17 @@ public function testGenerateCustomerValidTokenLoginAsCustomerEnabled()
      * Verify with Admin email ID and Magento_LoginAsCustomer::login is disabled
      *
      * @magentoApiDataFixture Magento/LoginAsCustomer/_files/admin.php
+     * @magentoApiDataFixture Magento/LoginAsCustomer/_files/login_as_customer_config_disable.php
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
-     * @magentoConfigFixture default_store login_as_customer/general/enabled 0
      * @throws Exception
      */
     public function testGenerateCustomerValidTokenLoginAsCustomerDisabled()
     {
         $customerEmail = '[email protected]';
 
         $mutation = $this->getQuery($customerEmail);
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage("Login as Customer is disabled..");
 
         $response = $this->graphQlMutation(
             $mutation,
@@ -89,7 +91,7 @@ public function testGenerateCustomerValidTokenLoginAsCustomerDisabled()
      * Verify with Customer Token in auth header
      *
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
-     * @magentoConfigFixture default_store login_as_customer/general/enabled 1
+     * @magentoApiDataFixture Magento/LoginAsCustomer/_files/login_as_customer_config_enable.php
      * @throws Exception
      */
     public function testGenerateCustomerTokenLoginWithCustomerCredentials()
@@ -116,7 +118,7 @@ public function testGenerateCustomerTokenLoginWithCustomerCredentials()
      * Test with invalid data.
      *
      * @magentoApiDataFixture Magento/LoginAsCustomer/_files/admin.php
-     * @magentoConfigFixture default_store login_as_customer/general/enabled 1
+     * @magentoApiDataFixture Magento/LoginAsCustomer/_files/login_as_customer_config_enable.php
      *
      * @dataProvider dataProviderInvalidInfo
      * @param string $adminUserName

dev/tests/integration/testsuite/Magento/LoginAsCustomer/_files/login_as_customer_config_disable.php

@@ -0,0 +1,19 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+use Magento\Config\Model\Config\Factory as ConfigFactory;
+
+$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+
+$loginAsCustomerConfigPath = 'login_as_customer/general/enabled';
+/** @var ConfigFactory $configFactory */
+$configFactory = $objectManager->get(ConfigFactory::class);
+
+$configModel = $configFactory->create();
+$configModel->setDataByPath($loginAsCustomerConfigPath, 0);
+try {
+    $configModel->save();
+} catch (Exception $e) {
+}

dev/tests/integration/testsuite/Magento/LoginAsCustomer/_files/login_as_customer_config_enable.php

@@ -0,0 +1,19 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+use Magento\Config\Model\Config\Factory as ConfigFactory;
+
+$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+
+$loginAsCustomerConfigPath = 'login_as_customer/general/enabled';
+/** @var ConfigFactory $configFactory */
+$configFactory = $objectManager->get(ConfigFactory::class);
+
+$configModel = $configFactory->create();
+$configModel->setDataByPath($loginAsCustomerConfigPath, 1);
+try {
+    $configModel->save();
+} catch (Exception $e) {
+}

dev/tests/integration/testsuite/Magento/LoginAsCustomer/_files/login_as_customer_config_enable_rollback.php

@@ -0,0 +1,19 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+use Magento\Config\Model\Config\Factory as ConfigFactory;
+
+$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+
+$loginAsCustomerConfigPath = 'login_as_customer/general/enabled';
+/** @var ConfigFactory $configFactory */
+$configFactory = $objectManager->get(ConfigFactory::class);
+
+$configModel = $configFactory->create();
+$configModel->setDataByPath($loginAsCustomerConfigPath, 0);
+try {
+    $configModel->save();
+} catch (Exception $e) {
+}