[fixed] Login As Customer functionality is available when Login As Customer->Enable Extension=No

Author: ihorvansach

app/code/Magento/LoginAsCustomerUi/Block/Adminhtml/ConfirmationPopup.php

@@ -79,4 +79,17 @@ public function getJsLayout()
 
         return $this->json->serialize($layout);
     }
+
+    /**
+     * Render block HTML
+     *
+     * @return string
+     */
+    protected function _toHtml()
+    {
+        if (!$this->config->isEnabled()) {
+            return '';
+        }
+        return parent::_toHtml();
+    }
 }

app/code/Magento/LoginAsCustomerUi/Plugin/Button/ToolbarPlugin.php

@@ -12,6 +12,7 @@
 use Magento\Framework\View\Element\AbstractBlock;
 use Magento\Framework\Escaper;
 use Magento\Framework\AuthorizationInterface;
+use Magento\LoginAsCustomerApi\Api\ConfigInterface;
 
 /**
  * Plugin for \Magento\Backend\Block\Widget\Button\Toolbar.
@@ -28,16 +29,24 @@ class ToolbarPlugin
      */
     private $escaper;
 
+    /**
+     * @var ConfigInterface
+     */
+    private $config;
+
     /**
      * ToolbarPlugin constructor.
      * @param AuthorizationInterface $authorization
+     * @param ConfigInterface $config
      * @param Escaper $escaper
      */
     public function __construct(
         AuthorizationInterface $authorization,
+        ConfigInterface $config,
         Escaper $escaper
     ) {
         $this->authorization = $authorization;
+        $this->config = $config;
         $this->escaper = $escaper;
     }
 
@@ -67,7 +76,10 @@ public function beforePushButtons(
             $order = $context->getCreditmemo()->getOrder();
         }
         if ($order) {
-            if ($this->isAllowed()) {
+
+            $isAllowed = $this->authorization->isAllowed('Magento_LoginAsCustomer::login_button');
+            $isEnabled = $this->config->isEnabled();
+            if ($isAllowed && $isEnabled) {
                 if (!empty($order['customer_id'])) {
                     $buttonUrl = $context->getUrl('loginascustomer/login/login', [
                         'customer_id' => $order['customer_id']
@@ -87,14 +99,4 @@ public function beforePushButtons(
             }
         }
     }
-
-    /**
-     * Check is allowed access
-     *
-     * @return bool
-     */
-    private function isAllowed(): bool
-    {
-        return (bool)$this->authorization->isAllowed('Magento_LoginAsCustomer::login_button');
-    }
 }

app/code/Magento/LoginAsCustomerUi/Ui/Customer/Component/Control/LoginAsCustomerButton.php

@@ -8,21 +8,28 @@
 namespace Magento\LoginAsCustomerUi\Ui\Customer\Component\Control;
 
 use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
+use Magento\Framework\AuthorizationInterface;
 use Magento\Framework\Escaper;
 use Magento\Framework\Registry;
 use Magento\Backend\Block\Widget\Context;
 use Magento\Customer\Block\Adminhtml\Edit\GenericButton;
+use Magento\LoginAsCustomerApi\Api\ConfigInterface;
 
 /**
  * Login As Customer button UI component.
  */
 class LoginAsCustomerButton extends GenericButton implements ButtonProviderInterface
 {
     /**
-     * @var \Magento\Framework\AuthorizationInterface
+     * @var AuthorizationInterface
      */
     private $authorization;
 
+    /**
+     * @var ConfigInterface
+     */
+    private $config;
+
     /**
      * Escaper
      *
@@ -33,13 +40,16 @@ class LoginAsCustomerButton extends GenericButton implements ButtonProviderInter
     /**
      * @param Context $context
      * @param Registry $registry
+     * @param ConfigInterface $config
      */
     public function __construct(
         Context $context,
-        Registry $registry
+        Registry $registry,
+        ConfigInterface $config
     ) {
         parent::__construct($context, $registry);
         $this->authorization = $context->getAuthorization();
+        $this->config = $config;
         $this->escaper = $context->getEscaper();
     }
 
@@ -50,8 +60,9 @@ public function getButtonData(): array
     {
         $customerId = $this->getCustomerId();
         $data = [];
-        $canModify = $customerId && $this->authorization->isAllowed('Magento_LoginAsCustomer::login_button');
-        if ($canModify) {
+        $isAllowed = $customerId && $this->authorization->isAllowed('Magento_LoginAsCustomer::login_button');
+        $isEnabled = $this->config->isEnabled();
+        if ($isAllowed && $isEnabled) {
             $data = [
                 'label' => __('Login As Customer'),
                 'class' => 'login login-button',