MQE-2045: Upgrade script to remove unused arguments

soumyau · soumyau · commit 187b8c6e71e9 · 2020-05-06T16:02:25.000-05:00
updated action groups to remove unused arguments
diff --git a/app/code/Magento/Backend/Test/Mftf/ActionGroup/AdminFilterLegacyGridActionGroup.xml b/app/code/Magento/Backend/Test/Mftf/ActionGroup/AdminFilterLegacyGridActionGroup.xml
@@ -10,7 +10,6 @@
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="AdminFilterLegacyGridActionGroup">
         <arguments>
-            <argument name="fieldSelector" type="string"/>
             <argument name="value" type="string"/>
             <argument name="button" type="string" defaultValue="{{AdminLegacyDataGridFilterSection.apply}}"/>
         </arguments>
diff --git a/app/code/Magento/Braintree/Test/Mftf/ActionGroup/AdminCreateNewRoleActionGroup.xml b/app/code/Magento/Braintree/Test/Mftf/ActionGroup/AdminCreateNewRoleActionGroup.xml
@@ -14,9 +14,6 @@
         </annotations>
         <arguments>
             <argument name="role" type="string" defaultValue=""/>
-            <argument name="resource" type="string" defaultValue="All"/>
-            <argument name="scope" type="string" defaultValue="Custom"/>
-            <argument name="websites" type="string" defaultValue="Main Website"/>
         </arguments>
 
         <click selector="{{AdminCreateRoleSection.create}}" stepKey="clickToAddNewRole"/>
diff --git a/app/code/Magento/Braintree/Test/Mftf/ActionGroup/AdminDeleteRoleActionGroup.xml b/app/code/Magento/Braintree/Test/Mftf/ActionGroup/AdminDeleteRoleActionGroup.xml
@@ -12,9 +12,6 @@
         <annotations>
             <description>Deletes a User Role that contains the text 'Role'. PLEASE NOTE: The Action Group values are Hardcoded.</description>
         </annotations>
-        <arguments>
-            <argument name="role" defaultValue=""/>
-        </arguments>
 
         <click stepKey="clickOnRole" selector="{{AdminDeleteRoleSection.theRole}}"/>
         <fillField stepKey="TypeCurrentPassword" selector="{{AdminDeleteRoleSection.current_pass}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}"/>
diff --git a/app/code/Magento/Bundle/Test/Mftf/ActionGroup/AdminOrderBundleProductActionGroup.xml b/app/code/Magento/Bundle/Test/Mftf/ActionGroup/AdminOrderBundleProductActionGroup.xml
@@ -10,7 +10,6 @@
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="AdminOrderConfigureBundleProduct">
         <arguments>
-            <argument name="productName" type="string" defaultValue="{{SimpleProduct.sku}}"/>
             <argument name="productNumber" type="string" defaultValue="1"/>
             <argument name="productQty" type="string" defaultValue="1"/>
         </arguments>
diff --git a/app/code/Magento/Bundle/Test/Mftf/ActionGroup/ViewBundleProductInAdminGridActionGroup.xml b/app/code/Magento/Bundle/Test/Mftf/ActionGroup/ViewBundleProductInAdminGridActionGroup.xml
@@ -14,7 +14,6 @@
         </annotations>
         <arguments>
             <argument name="product" defaultValue="BundleProduct"/>
-            <argument name="thumbnail" defaultValue="ProductPlaceholderImage"/>
         </arguments>
 
         <amOnPage url="{{AdminProductIndexPage.url}}" stepKey="visitAdminProductPage"/>
diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCreateAttributeWithValueWithTwoStoreViesFromProductPageActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCreateAttributeWithValueWithTwoStoreViesFromProductPageActionGroup.xml
@@ -15,7 +15,6 @@
         </annotations>
         <arguments>
             <argument name="firstStoreViewName" type="string"/>
-            <argument name="secondStoreViewName" type="string"/>
         </arguments>
 
         <click selector="{{AdminProductFormNewAttributeSection.addValue}}" stepKey="addValue" after="selectAttributeType"/>
diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCreateSimpleProductWithTextOptionCharLimitActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCreateSimpleProductWithTextOptionCharLimitActionGroup.xml
@@ -15,7 +15,6 @@
         <arguments>
             <argument name="category"/>
             <argument name="simpleProduct"/>
-            <argument name="charLimit"/>
         </arguments>
 
         <amOnPage url="{{AdminProductIndexPage.url}}" stepKey="navigateToProductIndex"/>
diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminSwitchScopeForProductAttributeActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminSwitchScopeForProductAttributeActionGroup.xml
@@ -9,9 +9,6 @@
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="AdminSwitchScopeForProductAttributeActionGroup">
-        <arguments>
-            <argument name="scope" type="string" defaultValue="1"/>
-        </arguments>
         <click selector="{{AttributePropertiesSection.AdvancedProperties}}" stepKey="expandAdvancedProperties"/>
         <waitForElementVisible selector="{{AttributePropertiesSection.Scope}}" stepKey="waitOpenAdvancedProperties"/>
         <selectOption selector="{{AttributePropertiesSection.Scope}}" userInput="1" stepKey="selectNecessaryScope"/>
diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/CheckCategoryImageInAdminActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/CheckCategoryImageInAdminActionGroup.xml
@@ -12,9 +12,6 @@
         <annotations>
             <description>Requires navigation to the Category creation/edit page. Click on the Upload button. Validates that the Image exists.</description>
         </annotations>
-        <arguments>
-            <argument name="image" defaultValue="ProductImage"/>
-        </arguments>
 
         <conditionalClick selector="{{AdminCategoryContentSection.sectionHeader}}" dependentSelector="{{AdminCategoryContentSection.uploadButton}}" visible="false" stepKey="openContentSection"/>
         <waitForPageLoad stepKey="waitForPageLoad"/>
diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/CheckItemInLayeredNavigationActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/CheckItemInLayeredNavigationActionGroup.xml
@@ -14,7 +14,6 @@
         </annotations>
         <arguments>
             <argument name="itemType"/>
-            <argument name="itemName"/>
         </arguments>
 
         <conditionalClick selector="{{StorefrontCategorySidebarSection.filterOptionsTitle('itemType')}}" dependentSelector="{{StorefrontCategorySidebarSection.filterOptions}}" visible="false" stepKey="expandFilterOptions"/>
diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/DeleteProductAttributeByAttributeCodeActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/DeleteProductAttributeByAttributeCodeActionGroup.xml
@@ -12,9 +12,6 @@
         <annotations>
             <description>Delete a Product Attribute from the Product Attribute creation/edit page.</description>
         </annotations>
-        <arguments>
-            <argument name="productAttributeCode" type="string"/>
-        </arguments>
 
         <waitForPageLoad stepKey="waitForViewAdminProductAttributeLoad" time="30"/>
         <click selector="{{AttributePropertiesSection.DeleteAttribute}}" stepKey="deleteAttribute"/>
diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/TestDynamicValidationHintActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/TestDynamicValidationHintActionGroup.xml
@@ -12,9 +12,6 @@
         <annotations>
             <description>Validates that the Product Text Option Text Length Hint displays the correct Count for multiple inputs based on the provided Character Limit.</description>
         </annotations>
-        <arguments>
-            <argument name="charLimit"/>
-        </arguments>
 
         <fillField userInput="abcde" selector="{{StorefrontProductPageSection.customTextOptionInput}}" stepKey="textInput1"/>
         <see selector="{{StorefrontProductPageSection.charCounter}}" userInput="(15 remaining)" stepKey="assertHint1"/>
diff --git a/app/code/Magento/CatalogRule/Test/Mftf/ActionGroup/AdminCreateCatalogPriceRuleWithConditionActionGroup.xml b/app/code/Magento/CatalogRule/Test/Mftf/ActionGroup/AdminCreateCatalogPriceRuleWithConditionActionGroup.xml
@@ -9,9 +9,6 @@
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="AdminCreateCatalogPriceRuleWithConditionActionGroup" extends="CreateCatalogPriceRuleActionGroup">
-        <arguments>
-            <argument name="catalogRuleType" type="entity" defaultValue="PriceRuleWithCondition"/>
-        </arguments>
         <waitForPageLoad stepKey="waitForPageLoad" after="addNewRule"/>
         <click selector="{{AdminNewCatalogPriceRule.conditionsTab}}" stepKey="expandConditions" before="openActionDropdown"/>
         <scrollTo selector="{{AdminNewCatalogPriceRule.conditionsTab}}" stepKey="scrollToConditionsTab" after="expandConditions"/>
diff --git a/app/code/Magento/CatalogRule/Test/Mftf/ActionGroup/AssertCatalogPriceRuleFormActionGroup.xml b/app/code/Magento/CatalogRule/Test/Mftf/ActionGroup/AssertCatalogPriceRuleFormActionGroup.xml
@@ -14,7 +14,6 @@
         </annotations>
         <arguments>
             <argument name="catalogRule" defaultValue="inactiveCatalogRule" />
-            <argument name="status"  type="string" defaultValue=""/>
             <argument name="websites" type="string"/>
             <argument name="customerGroup" type="string"/>
         </arguments>
diff --git a/app/code/Magento/Checkout/Test/Mftf/ActionGroup/AssertStorefrontCheckoutCartItemsActionGroup.xml b/app/code/Magento/Checkout/Test/Mftf/ActionGroup/AssertStorefrontCheckoutCartItemsActionGroup.xml
@@ -14,7 +14,6 @@
         </annotations>
         <arguments>
             <argument name="productName" type="string"/>
-            <argument name="productSku" type="string"/>
             <argument name="productPrice" type="string"/>
             <argument name="subtotal" type="string"/>
             <argument name="qty" type="string"/>
diff --git a/app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontAssertProductAddToCartSuccessMessageActionGroup.xml b/app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontAssertProductAddToCartSuccessMessageActionGroup.xml
@@ -8,9 +8,6 @@
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="StorefrontAssertProductAddToCartSuccessMessageActionGroup">
-        <arguments>
-            <argument name="message" type="string" defaultValue=""/>
-        </arguments>
         <waitForElementVisible selector="{{StorefrontMessagesSection.success}}" time="30" stepKey="waitForProductAddedMessage"/>
         <see selector="{{StorefrontMessagesSection.success}}" userInput="message" stepKey="seeAddToCartSuccessMessage"/>
     </actionGroup>
diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminInsertRecentlyViewedWidgetActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminInsertRecentlyViewedWidgetActionGroup.xml
@@ -13,7 +13,6 @@
             <argument name="attributeSelector2" type="string" defaultValue="show_buttons"/>
             <argument name="productAttributeSection1" type="string"  defaultValue="1"/>
             <argument name="productAttributeSection2" type="string" defaultValue="4" />
-            <argument name="buttonToShowSection1" type="string"  defaultValue="1"/>
             <argument name="buttonToShowSection2" type="string" defaultValue="3" />
         </arguments>
 
diff --git a/app/code/Magento/ConfigurableProduct/Test/Mftf/ActionGroup/AssertConfigurableProductOnAdminProductPageActionGroup.xml b/app/code/Magento/ConfigurableProduct/Test/Mftf/ActionGroup/AssertConfigurableProductOnAdminProductPageActionGroup.xml
@@ -12,9 +12,6 @@
         <annotations>
             <description>Validates that the provided Configurable Product Name, SKU and Price are present and correct on the Configurable Product creation/edit page. PLEASE NOTE: The Product Data is Hardcoded.</description>
         </annotations>
-        <arguments>
-            <argument name="product" type="entity"/>
-        </arguments>
 
         <seeInField userInput="{{ApiConfigurableProduct.name}}" selector="{{AdminProductFormSection.productName}}" stepKey="seeNameRequired"/>
         <seeInField userInput="{{ApiConfigurableProduct.sku}}" selector="{{AdminProductFormSection.productSku}}" stepKey="seeSkuRequired"/>
diff --git a/app/code/Magento/ConfigurableProduct/Test/Mftf/ActionGroup/AssertConfigurableProductWithSpecialPriceOnStorefrontProductPageActionGroup.xml b/app/code/Magento/ConfigurableProduct/Test/Mftf/ActionGroup/AssertConfigurableProductWithSpecialPriceOnStorefrontProductPageActionGroup.xml
@@ -15,7 +15,6 @@
         <arguments>
             <argument name="option" type="string"/>
             <argument name="price" type="string"/>
-            <argument name="specialPrice" defaultValue="specialProductPrice"/>
         </arguments>
 
         <selectOption userInput="{{option}}" selector="{{StorefrontProductInfoMainSection.productAttributeOptionsSelectButton}}" stepKey="selectOptionWithSpecialPrice"/>
diff --git a/app/code/Magento/ConfigurableProduct/Test/Mftf/ActionGroup/CreateConfigurableProductWithAttributeSetActionGroup.xml b/app/code/Magento/ConfigurableProduct/Test/Mftf/ActionGroup/CreateConfigurableProductWithAttributeSetActionGroup.xml
@@ -14,7 +14,6 @@
         </annotations>
         <arguments>
             <argument name="product" defaultValue="_defaultProduct"/>
-            <argument name="category" defaultValue="_defaultCategory"/>
             <argument name="label" type="string" defaultValue="mySet"/>
             <argument name="option" type="string" defaultValue="['option1', 'option2', 'option3', 'option4']"/>
         </arguments>
diff --git a/app/code/Magento/Email/Test/Mftf/ActionGroup/CreateCustomTemplateActionGroup.xml b/app/code/Magento/Email/Test/Mftf/ActionGroup/CreateCustomTemplateActionGroup.xml
@@ -9,6 +9,9 @@
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="CreateCustomTemplateActionGroup" extends="CreateNewTemplateActionGroup">
+        <arguments>
+            <argument name="template" defaultValue="EmailTemplate"/>
+        </arguments>
         <remove keyForRemoval="selectValueFromTemplateDropDown"/>
         <remove keyForRemoval="clickLoadTemplateButton"/>
 
diff --git a/app/code/Magento/Email/Test/Mftf/ActionGroup/CreateNewTemplateActionGroup.xml b/app/code/Magento/Email/Test/Mftf/ActionGroup/CreateNewTemplateActionGroup.xml
@@ -13,9 +13,6 @@
         <annotations>
             <description>Clicks on Add New Template. Fills the Template details. Clicks on Save. PLEASE NOTE: The values are Hardcoded.</description>
         </annotations>
-        <arguments>
-            <argument name="template" defaultValue="EmailTemplate"/>
-        </arguments>
 
         <!--Go to Marketing> Email Templates-->
         <amOnPage url="{{AdminEmailTemplateIndexPage.url}}" stepKey="navigateToEmailTemplatePage"/>
diff --git a/app/code/Magento/Sales/Test/Mftf/ActionGroup/NavigateToNewOrderPageNewCustomerSingleStoreActionGroup.xml b/app/code/Magento/Sales/Test/Mftf/ActionGroup/NavigateToNewOrderPageNewCustomerSingleStoreActionGroup.xml
@@ -12,9 +12,6 @@
         <annotations>
             <description>Goes to the Admin Orders grid page. Clicks on 'Create New Order'. Clicks on 'Create New Customer'. Validates that Page Title is present and correct.</description>
         </annotations>
-        <arguments>
-            <argument name="storeView" defaultValue="_defaultStore"/>
-        </arguments>
 
         <amOnPage url="{{AdminOrdersPage.url}}" stepKey="navigateToOrderIndexPage"/>
         <waitForPageLoad stepKey="waitForIndexPageLoad"/>
diff --git a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminFilterStoreViewActionGroup.xml b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminFilterStoreViewActionGroup.xml
@@ -13,7 +13,6 @@
             <description>Filters the Admin Catalog Product page based on the provided Store Group and Custom Store.</description>
         </annotations>
         <arguments>
-            <argument name="StoreGroup" defaultValue="_defaultStoreGroup"/>
             <argument name="customStore" defaultValue="customStore.name"/>
         </arguments>
 
diff --git a/composer.json b/composer.json
@@ -89,7 +89,7 @@
         "friendsofphp/php-cs-fixer": "~2.16.0",
         "lusitanian/oauth": "~0.8.10",
         "magento/magento-coding-standard": "*",
-        "magento/magento2-functional-testing-framework": "dev-3.0.0-RC2",
+        "magento/magento2-functional-testing-framework": "dev-MQE-2045",
         "pdepend/pdepend": "~2.7.1",
         "phpcompatibility/php-compatibility": "^9.3",
         "phpmd/phpmd": "^2.8.0",
diff --git a/composer.lock b/composer.lock
