MC-20508: Api-functional tests for Product prices including FPT

- add some docs to schema
- fix static and revert Model tax

Author: cpartica

app/code/Magento/CatalogGraphQl/etc/schema.graphqls

@@ -27,7 +27,7 @@ type PriceAdjustment @doc(description: "PriceAdjustment is deprecated. Taxes wil
     description: PriceAdjustmentDescriptionEnum @deprecated(reason: "PriceAdjustment is deprecated.") @doc(description: "Indicates whether the entity described by the code attribute is included or excluded from the adjustment.")
 }
 
-enum PriceAdjustmentCodesEnum @doc(description: "PriceAdjustmentCodesEnum is deprecated. This enumeration contains values defined in modules other than the Catalog module.") {
+enum PriceAdjustmentCodesEnum @doc(description: "PriceAdjustment.code is deprecated. This enumeration contains values defined in modules other than the Catalog module.") {
 }
 
 enum PriceAdjustmentDescriptionEnum @doc(description: "PriceAdjustmentDescriptionEnum is deprecated. This enumeration states whether a price adjustment is included or excluded.") {

app/code/Magento/TaxGraphQl/etc/schema.graphqls

@@ -2,5 +2,5 @@
 # See COPYING.txt for license details.
 
 enum PriceAdjustmentCodesEnum {
-    TAX
+    TAX @deprecated(reason: "PriceAdjustmentCodesEnum is deprecated. Tax is included or excluded in price. Tax is not shown separtely in Catalog")
 }

app/code/Magento/Weee/Model/Tax.php

@@ -13,8 +13,6 @@
 use Magento\Catalog\Model\Product\Type;
 
 /**
- * Weee tax model
- *
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @api
  * @since 100.0.2
@@ -143,8 +141,6 @@ protected function _construct()
     }
 
     /**
-     * Get the weee amount
-     *
      * @param Product $product
      * @param null|false|\Magento\Framework\DataObject $shipping
      * @param null|false|\Magento\Framework\DataObject $billing
@@ -174,8 +170,6 @@ public function getWeeeAmount(
     }
 
     /**
-     * Get the weee amount excluding tax
-     *
      * @param Product $product
      * @param null|false|\Magento\Framework\DataObject $shipping
      * @param null|false|\Magento\Framework\DataObject $billing
@@ -206,8 +200,6 @@ public function getWeeeAmountExclTax(
     }
 
     /**
-     * Get the weee attribute codes
-     *
      * @param bool $forceEnabled
      * @return array
      */
@@ -219,8 +211,8 @@ public function getWeeeAttributeCodes($forceEnabled = false)
     /**
      * Retrieve Wee tax attribute codes
      *
-     * @param null|string|bool|int|Store $store
-     * @param bool $forceEnabled
+     * @param  null|string|bool|int|Store $store
+     * @param  bool $forceEnabled
      * @return array
      */
     public function getWeeeTaxAttributeCodes($store = null, $forceEnabled = false)
@@ -236,8 +228,6 @@ public function getWeeeTaxAttributeCodes($store = null, $forceEnabled = false)
     }
 
     /**
-     * Retrieve the relevant wee tax attributes assigned to a product by location
-     *
      * @param Product $product
      * @param null|false|\Magento\Quote\Model\Quote\Address $shipping
      * @param null|false|\Magento\Quote\Model\Quote\Address $billing
@@ -248,7 +238,6 @@ public function getWeeeTaxAttributeCodes($store = null, $forceEnabled = false)
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     * phpcs:disable Generic.Metrics.NestingLevel
      */
     public function getProductWeeeAttributes(
         $product,
@@ -279,7 +268,7 @@ public function getProductWeeeAttributes(
             return $result;
         }
 
-        /** @var Calculation $calculator */
+        /** @var \Magento\Tax\Model\Calculation $calculator */
         $calculator = $this->_calculationFactory->create();
 
         $customerId = $this->_customerSession->getCustomerId();
@@ -328,7 +317,7 @@ public function getProductWeeeAttributes(
                 $amount = $value;
                 $amountExclTax = $value;
                 if ($calculateTax && $this->weeeConfig->isTaxable($store)) {
-                    /** @var Calculation $calculator */
+                    /** @var \Magento\Tax\Model\Calculation $calculator */
                     $defaultPercent = $calculator->getRate(
                         $defaultRateRequest->setProductClassId($product->getTaxClassId())
                     );
@@ -381,13 +370,10 @@ public function getProductWeeeAttributes(
                 $result[] = $one;
             }
         }
-
         return $result;
     }
 
     /**
-     * Is there a weee attribute available for the location provided
-     *
      * @param int $countryId
      * @param int $regionId
      * @param int $websiteId

app/code/Magento/WeeeGraphQl/etc/schema.graphqls

@@ -1,13 +1,13 @@
 # Copyright © Magento, Inc. All rights reserved.
 # See COPYING.txt for license details.
 
-enum PriceAdjustmentCodesEnum @doc(description: "PriceAdjustmentCodesEnum is deprecated, use ProductPrice.") {
-    WEEE @deprecated(reason: "WEEE is deprecated, use fixed_product_taxes.label")
-    WEEE_TAX @deprecated(reason: "WEEE_TAX is deprecated, use fixed_product_taxes. Tax is included or excluded in the amount")
+enum PriceAdjustmentCodesEnum {
+    WEEE @deprecated(reason: "WEEE code is deprecated, use fixed_product_taxes.label")
+    WEEE_TAX @deprecated(reason: "Use fixed_product_taxes. PriceAdjustmentCodesEnum is deprecated. Tax is included or excluded in price. Tax is not shown separtely in Catalog")
 }
 
 type ProductPrice {
-    fixed_product_taxes: [FixedProductTax] @doc(description: "The multiple FPTs that can be applied to a product price.")  @resolver(class: "Magento\\WeeeGraphQl\\Model\\Resolver\\FixedProductTax")
+    fixed_product_taxes: [FixedProductTax] @doc(description: "The multiple FPTs that can be applied to a product price.") @resolver(class: "Magento\\WeeeGraphQl\\Model\\Resolver\\FixedProductTax")
 }
 
 type FixedProductTax @doc(description: "A single FPT that can be applied to a product price.") {