ENGCOM-5519: Resolve MassDelete Product will have'the counter' wrong if an EXCEPTION happens #23939

 - Merge Pull Request #23939 from edenduong/magento2:2.3-bugfix/process_throw_exception
 - Merged commits:
   1. 30f5581
   2. 7ca5932
   3. 71b6a7e
   4. 78a2c51
   5. ea5d411
   6. 7bcb47e
   7. 8f9246f

Author: magento-engcom-team

app/code/Magento/Catalog/Controller/Adminhtml/Product/MassDelete.php

@@ -4,6 +4,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Catalog\Controller\Adminhtml\Product;
 
 use Magento\Framework\App\Action\HttpPostActionInterface as HttpPostActionInterface;
@@ -12,7 +14,14 @@
 use Magento\Ui\Component\MassAction\Filter;
 use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory;
 use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Framework\Exception\CouldNotSaveException;
+use Magento\Framework\Exception\StateException;
+use Magento\Framework\Exception\LocalizedException;
+use Psr\Log\LoggerInterface;
 
+/**
+ * Class \Magento\Catalog\Controller\Adminhtml\Product\MassDelete
+ */
 class MassDelete extends \Magento\Catalog\Controller\Adminhtml\Product implements HttpPostActionInterface
 {
     /**
@@ -32,38 +41,55 @@ class MassDelete extends \Magento\Catalog\Controller\Adminhtml\Product implement
      */
     private $productRepository;
 
+    /**
+     * @var LoggerInterface
+     */
+    private $logger;
+
     /**
      * @param Context $context
      * @param Builder $productBuilder
      * @param Filter $filter
      * @param CollectionFactory $collectionFactory
      * @param ProductRepositoryInterface $productRepository
+     * @param LoggerInterface $logger
      */
     public function __construct(
         Context $context,
         Builder $productBuilder,
         Filter $filter,
         CollectionFactory $collectionFactory,
-        ProductRepositoryInterface $productRepository = null
+        ProductRepositoryInterface $productRepository = null,
+        LoggerInterface $logger = null
     ) {
         $this->filter = $filter;
         $this->collectionFactory = $collectionFactory;
-        $this->productRepository = $productRepository
-            ?: \Magento\Framework\App\ObjectManager::getInstance()->create(ProductRepositoryInterface::class);
+        $this->productRepository = $productRepository ?:
+            \Magento\Framework\App\ObjectManager::getInstance()->create(ProductRepositoryInterface::class);
+        $this->logger = $logger ?:
+            \Magento\Framework\App\ObjectManager::getInstance()->create(LoggerInterface::class);
         parent::__construct($context, $productBuilder);
     }
 
     /**
+     * Mass Delete Action
+     *
      * @return \Magento\Backend\Model\View\Result\Redirect
      */
     public function execute()
     {
         $collection = $this->filter->getCollection($this->collectionFactory->create());
         $productDeleted = 0;
+        $productDeletedError = 0;
         /** @var \Magento\Catalog\Model\Product $product */
         foreach ($collection->getItems() as $product) {
-            $this->productRepository->delete($product);
-            $productDeleted++;
+            try {
+                $this->productRepository->delete($product);
+                $productDeleted++;
+            } catch (LocalizedException $exception) {
+                $this->logger->error($exception->getLogMessage());
+                $productDeletedError++;
+            }
         }
 
         if ($productDeleted) {
@@ -72,6 +98,15 @@ public function execute()
             );
         }
 
+        if ($productDeletedError) {
+            $this->messageManager->addErrorMessage(
+                __(
+                    'A total of %1 record(s) haven\'t been deleted. Please see server logs for more details.',
+                    $productDeletedError
+                )
+            );
+        }
+
         return $this->resultFactory->create(ResultFactory::TYPE_REDIRECT)->setPath('catalog/*/index');
     }
 }

app/code/Magento/Catalog/i18n/en_US.csv

@@ -810,4 +810,5 @@ Details,Details
 "Category with ID: (%1) doesn't exist", "Category with ID: (%1) doesn't exist"
 "You added product %1 to the <a href=""%2"">comparison list</a>.","You added product %1 to the <a href=""%2"">comparison list</a>."
 "Edit Product Design","Edit Product Design"
-"Edit Category Design","Edit Category Design"
+"Edit Category Design","Edit Category Design"
+"A total of %1 record(s) haven't been deleted. Please see server logs for more details.","A total of %1 record(s) haven't been deleted. Please see server logs for more details."