Remove Varnish 4/5 support

Fix static test failures

Author: ihor-sviziev

app/code/Magento/PageCache/Console/Command/GenerateVclCommand.php

@@ -29,32 +29,32 @@ class GenerateVclCommand extends Command
     /**
      * Access list option name
      */
-    const ACCESS_LIST_OPTION = 'access-list';
+    public const ACCESS_LIST_OPTION = 'access-list';
 
     /**
      * Backend host option name
      */
-    const BACKEND_HOST_OPTION = 'backend-host';
+    public const BACKEND_HOST_OPTION = 'backend-host';
 
     /**
      * Backend port option name
      */
-    const BACKEND_PORT_OPTION = 'backend-port';
+    public const BACKEND_PORT_OPTION = 'backend-port';
 
     /**
      * Varnish version option name
      */
-    const EXPORT_VERSION_OPTION = 'export-version';
+    public const EXPORT_VERSION_OPTION = 'export-version';
 
     /**
      * Grace period option name
      */
-    const GRACE_PERIOD_OPTION = 'grace-period';
+    public const GRACE_PERIOD_OPTION = 'grace-period';
 
     /**
      * Output file option name
      */
-    const OUTPUT_FILE_OPTION = 'output-file';
+    public const OUTPUT_FILE_OPTION = 'output-file';
 
     /**
      * @var \Magento\Framework\Filesystem\Directory\WriteFactory
@@ -211,6 +211,8 @@ private function getOptionList()
     }
 
     /**
+     * Maps input keys to vcl parameters
+     *
      * @param InputInterface $input
      * @return array
      */

app/code/Magento/PageCache/Controller/Adminhtml/PageCache/ExportVarnishConfig.php

@@ -16,7 +16,7 @@ class ExportVarnishConfig extends \Magento\Backend\App\Action implements HttpGet
     /**
      * Authorization level of a basic admin session
      */
-    const ADMIN_RESOURCE = 'Magento_Backend::system';
+    public const ADMIN_RESOURCE = 'Magento_Backend::system';
 
     /**
      * @var \Magento\Backend\App\Response\Http\FileFactory

app/code/Magento/PageCache/Model/Config.php

@@ -144,7 +144,8 @@ public function getTtl()
      *
      * @param string $vclTemplatePath
      * @return string
-     * @deprecated 100.2.0 see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
+     * @deprecated 100.2.0
+     * @see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
      */
     public function getVclFile($vclTemplatePath)
     {
@@ -180,7 +181,8 @@ public function getVclFile($vclTemplatePath)
      * Prepare data for VCL config
      *
      * @return array
-     * @deprecated 100.2.0 see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
+     * @deprecated 100.2.0
+     * @see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
      */
     protected function _getReplacements()
     {
@@ -210,7 +212,8 @@ protected function _getReplacements()
      * }
      *
      * @return mixed|null|string
-     * @deprecated 100.2.0 see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
+     * @deprecated 100.2.0
+     * @see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
      */
     protected function _getAccessList()
     {
@@ -236,7 +239,8 @@ protected function _getAccessList()
      * we have to convert "/pattern/iU" into "(?Ui)pattern"
      *
      * @return string
-     * @deprecated 100.2.0 see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
+     * @deprecated 100.2.0
+     * @see \Magento\PageCache\Model\VclGeneratorInterface::generateVcl
      */
     protected function _getDesignExceptions()
     {

app/code/Magento/PageCache/Model/Varnish/VclTemplateLocator.php

@@ -21,39 +21,39 @@ class VclTemplateLocator implements VclTemplateLocatorInterface
     /**
      * XML path to Varnish 6 config template path
      */
-    const VARNISH_6_CONFIGURATION_PATH = 'system/full_page_cache/varnish6/path';
+    public const VARNISH_6_CONFIGURATION_PATH = 'system/full_page_cache/varnish6/path';
 
     /**
      * @deprecated Varnish 5 is EOL
      * @see VARNISH_6_CONFIGURATION_PATH
      * XML path to Varnish 5 config template path
      */
-    const VARNISH_5_CONFIGURATION_PATH = 'system/full_page_cache/varnish5/path';
+    public const VARNISH_5_CONFIGURATION_PATH = 'system/full_page_cache/varnish5/path';
 
     /**
      * @deprecated Varnish 4 is EOL
      * @see VARNISH_6_CONFIGURATION_PATH
      * XML path to Varnish 4 config template path
      */
-    const VARNISH_4_CONFIGURATION_PATH = 'system/full_page_cache/varnish4/path';
+    public const VARNISH_4_CONFIGURATION_PATH = 'system/full_page_cache/varnish4/path';
 
     /**
      * @deprecated Varnish 4 is EOL
      * @see VARNISH_SUPPORTED_VERSION_6
      */
-    const VARNISH_SUPPORTED_VERSION_4 = '4';
+    public const VARNISH_SUPPORTED_VERSION_4 = '4';
 
     /**
      * @deprecated Varnish 5 is EOL
      * @see VARNISH_SUPPORTED_VERSION_6
      */
-    const VARNISH_SUPPORTED_VERSION_5 = '5';
+    public const VARNISH_SUPPORTED_VERSION_5 = '5';
 
     /**
      * Varnish 6 supported version
      * @see VARNISH_SUPPORTED_VERSION_6
      */
-    const VARNISH_SUPPORTED_VERSION_6 = '6';
+    public const VARNISH_SUPPORTED_VERSION_6 = '6';
 
     /**
      * @var array