ACP2E-1388, fixed static and unit

Author: aplapana

app/code/Magento/CatalogInventory/Model/Indexer/ProductPriceIndexFilter.php

@@ -121,7 +121,9 @@ public function modifyPrice(IndexTableStructure $priceTable, array $entityIds =
         foreach ($batchSelectIterator as $select) {
             $productIds = null;
             foreach ($connection->query($select)->fetchAll() as $row) {
-                if ($row['product_id'] && $this->isWithinDynamicPriceBundle($priceTable->getTableName(), (int) $row['product_id'])) {
+                if ($row['product_id'] &&
+                    $this->isWithinDynamicPriceBundle($priceTable->getTableName(), (int) $row['product_id'])
+                ) {
                     $productIds[] = (int) $row['product_id'];
                 }
             }
@@ -144,12 +146,16 @@ private function isWithinDynamicPriceBundle(string $priceTableName, int $product
         $connection = $this->resourceConnection->getConnection($this->connectionName);
         $select = $connection->select();
         $select->from(['selection' => 'catalog_product_bundle_selection'], 'selection_id');
-        $select->joinInner(['entity' => 'catalog_product_entity'], implode(' AND ', ['selection.parent_product_id = entity.entity_id']), null);
-        $select->joinInner(['price' => $priceTableName], implode(' AND ', ['price.entity_id = selection.product_id']), null);
+        $select->joinInner(['entity' => 'catalog_product_entity'],
+            implode(' AND ', ['selection.parent_product_id = entity.entity_id']), null
+        );
+        $select->joinInner(['price' => $priceTableName],
+            implode(' AND ', ['price.entity_id = selection.product_id']), null
+        );
         $select->where('selection.product_id = ?', $productId);
         $select->where('entity.type_id = ?', \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE);
         $select->where('price.tax_class_id = ?', \Magento\Bundle\Model\Product\Price::PRICE_TYPE_DYNAMIC);
 
-        return intval($connection->fetchOne($select)) != 0;
+        return (int) $connection->fetchOne($select) != 0;
     }
 }

app/code/Magento/CatalogInventory/Test/Unit/Model/Indexer/ProductPriceIndexFilterTest.php

@@ -78,13 +78,10 @@ public function testModifyPrice(): void
         $entityIds = [1, 2, 3];
         $indexTableStructure = $this->createMock(IndexTableStructure::class);
         $connectionMock = $this->getMockForAbstractClass(AdapterInterface::class);
-        $this->resourceConnection->expects($this->once())->method('getConnection')->willReturn($connectionMock);
+        $this->resourceConnection->expects($this->exactly(6))->method('getConnection')->willReturn($connectionMock);
         $selectMock = $this->createMock(Select::class);
-        $connectionMock->expects($this->once())->method('select')->willReturn($selectMock);
-        $selectMock
-            ->method('where')
-            ->withConsecutive([], [], ['stock_item.product_id IN (?)', $entityIds])
-            ->willReturnOnConsecutiveCalls(null, null, $selectMock);
+        $connectionMock->expects($this->exactly(6))->method('select')->willReturn($selectMock);
+
         $this->generator->expects($this->once())
             ->method('generate')
             ->willReturnCallback(

app/code/Magento/CatalogInventory/composer.json

@@ -13,7 +13,8 @@
         "magento/module-eav": "*",
         "magento/module-quote": "*",
         "magento/module-store": "*",
-        "magento/module-ui": "*"
+        "magento/module-ui": "*",
+        "magento/module-bundle": "*"
     },
     "type": "magento2-module",
     "license": [