Skip to content

Commit 228ebc5

Browse files
author
joweecaquicla
committed
magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized - modifications on enabled and in menu columns and mftf files
1 parent 0cd1e55 commit 228ebc5

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

app/code/Magento/MediaGalleryCatalogUi/Test/Mftf/Section/AdminMediaGalleryCatalogUiCategoryGridSection.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
<element name="name" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Name')]/preceding-sibling::th) +1 ]//*[text()='{{categoryName}}']" parameterized="true"/>
1616
<element name="displayMode" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Display Mode')]/preceding-sibling::th) +1 ]//*[text()='{{productsText}}']" parameterized="true"/>
1717
<element name="products" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Products')]/preceding-sibling::th) +1 ]//*[text()='{{productsQty}}']" parameterized="true"/>
18-
<element name="inMenu" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'In Menu')]/preceding-sibling::th) +1 ]//*[text()='{{inMenuValue}}']" parameterized="true"/>
19-
<element name="enabled" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Enabled')]/preceding-sibling::th) +1 ]//*[text()='{{enabledValue}}']" parameterized="true"/>
20-
<element name="edit" type="button" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Action')]/preceding-sibling::th) +1 ]//*[text()='{{edit}}']" parameterized="true"/>
18+
<element name="inMenu" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'In Menu')]/preceding-sibling::th) +1 ]//span[contains(@class, '{{inMenuValue}}')]" parameterized="true"/>
19+
<element name="enabled" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Enabled')]/preceding-sibling::th) +1 ]//span[contains(@class, '{{enabledValue}}')]" parameterized="true"/>
20+
<element name="edit" type="button" selector="//tr[td//text()[contains(., '{{categoryName}}')]]//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Action')]/preceding-sibling::th) +1 ]//*[text()='{{actionButton}}']" parameterized="true"/>
2121
</section>
2222
</sections>

app/code/Magento/MediaGalleryCatalogUi/Ui/Component/Listing/Columns/InMenu.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ public function prepareDataSource(array $dataSource)
2424
$fieldName = $this->getData('name');
2525
foreach ($dataSource['data']['items'] as & $item) {
2626
if (isset($item[$fieldName]) && $item[$fieldName] == 1) {
27-
$item[$fieldName] = 'Yes';
27+
$item[$fieldName] = '<span class="true">Yes</span>';
2828
} else {
29-
$item[$fieldName] = 'No';
29+
$item[$fieldName] = '<span class="false">No</span>';
3030
}
3131
}
3232
}

app/code/Magento/MediaGalleryCatalogUi/Ui/Component/Listing/Columns/IsActive.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ public function prepareDataSource(array $dataSource)
2424
$fieldName = $this->getData('name');
2525
foreach ($dataSource['data']['items'] as & $item) {
2626
if (isset($item[$fieldName]) && $item[$fieldName] == 1) {
27-
$item[$fieldName] = 'Yes';
27+
$item[$fieldName] = '<span class="true">Yes</span>';
2828
} else {
29-
$item[$fieldName] = 'No';
29+
$item[$fieldName] = '<span class="false">No</span>';
3030
}
3131
}
3232
}

app/code/Magento/MediaGalleryCatalogUi/view/adminhtml/ui_component/media_gallery_category_listing.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,13 @@
170170
<column name="include_in_menu" class="Magento\MediaGalleryCatalogUi\Ui\Component\Listing\Columns\InMenu">
171171
<settings>
172172
<label translate="true">In Menu</label>
173+
<bodyTmpl>ui/grid/cells/html</bodyTmpl>
173174
</settings>
174175
</column>
175176
<column name="is_active" class="Magento\MediaGalleryCatalogUi\Ui\Component\Listing\Columns\IsActive">
176177
<settings>
177178
<label translate="true">Enabled</label>
179+
<bodyTmpl>ui/grid/cells/html</bodyTmpl>
178180
</settings>
179181
</column>
180182
<actionsColumn name="actions" class="Magento\MediaGalleryCatalogUi\Ui\Component\Listing\Columns\CategoryActions" sortOrder="1000">

app/code/Magento/MediaGalleryUi/Test/Mftf/ActionGroup/AdminMediaGalleryAssertCategoryNameInCategoryGridActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
<argument name="categoryName" type="string"/>
1717
</arguments>
1818

19-
<seeElement selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.name('1', categoryName)}}" stepKey="assertNameColumn"/>
19+
<seeElement selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.name(categoryName)}}" stepKey="assertNameColumn"/>
2020
</actionGroup>
2121
</actionGroups>

0 commit comments

Comments
 (0)