Skip to content

Commit 22e50b0

Browse files
committed
Merge remote-tracking branch 'origin/ACP2E-4160' into PR_2025_09_19_flowers
2 parents 1bd7aa6 + 0e18989 commit 22e50b0

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

app/code/Magento/ImportExport/Model/Export/Entity/AbstractEntity.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2013 Adobe
4+
* All Rights Reserved.
55
*/
66
namespace Magento\ImportExport\Model\Export\Entity;
77

@@ -290,7 +290,7 @@ protected function _prepareEntityCollection(\Magento\Eav\Model\Entity\Collection
290290
$attrFilterType = \Magento\ImportExport\Model\Export::getAttributeFilterType($attribute);
291291

292292
if (\Magento\ImportExport\Model\Export::FILTER_TYPE_SELECT == $attrFilterType) {
293-
if (is_scalar($exportFilter[$attrCode]) && trim($exportFilter[$attrCode])) {
293+
if (is_scalar($exportFilter[$attrCode]) && strlen(trim($exportFilter[$attrCode]))) {
294294
$collection->addAttributeToFilter($attrCode, ['eq' => $exportFilter[$attrCode]]);
295295
}
296296
} elseif (\Magento\ImportExport\Model\Export::FILTER_TYPE_MULTISELECT == $attrFilterType) {

dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Export/ProductTest.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
use Magento\CatalogInventory\Api\StockItemRepositoryInterface;
2222
use Magento\CatalogInventory\Model\Stock\Item;
2323
use Magento\Directory\Helper\Data as DirectoryData;
24+
use Magento\Framework\App\Area;
2425
use Magento\Framework\App\Config\ReinitableConfigInterface;
2526
use Magento\Framework\App\Config\ScopeConfigInterface;
2627
use Magento\Framework\Exception\NoSuchEntityException;
@@ -998,4 +999,22 @@ public function testExportProductWithDateAndDatetimeAttributes(): void
998999
$this->assertMatchesRegularExpression('#datetime_attr=7/19/15,\p{Zs}3:30\p{Zs}AM#u', $csv);
9991000
$this->assertMatchesRegularExpression('#date_attr=2/7/17("|(,\w+=))#', $csv);
10001001
}
1002+
1003+
#[
1004+
AppArea(Area::AREA_ADMINHTML),
1005+
DataFixture(
1006+
AttributeFixture::class,
1007+
['frontend_input' => 'boolean', 'backend_type' => 'int', 'attribute_code' => 'yesno_attr']
1008+
),
1009+
DataFixture(ProductFixture::class, ['sku' => 'prod1']),
1010+
DataFixture(ProductFixture::class, ['sku' => 'prod2', 'yesno_attr' => '0']),
1011+
DataFixture(ProductFixture::class, ['sku' => 'prod3', 'yesno_attr' => '1']),
1012+
]
1013+
public function testExportProductWithYesNoAttribute(): void
1014+
{
1015+
$csv = $this->doExport(['yesno_attr' => '0']);
1016+
self::assertStringContainsString('prod2', $csv);
1017+
self::assertStringNotContainsString('prod1', $csv);
1018+
self::assertStringNotContainsString('prod3', $csv);
1019+
}
10011020
}

0 commit comments

Comments
 (0)