#27536: Review fixes

Author: Stanislav Idolov

app/code/Magento/MediaContentCatalog/Observer/Category.php

@@ -50,27 +50,17 @@ public function execute(Observer $observer): void
         /** @var CatalogCategory $model */
         $model = $observer->getEvent()->getData('category');
         if ($model instanceof AbstractModel) {
-            $this->updateRelations($model);
-        }
-    }
-
-    /**
-     * Update relations for the model
-     *
-     * @param AbstractModel $model
-     */
-    private function updateRelations(AbstractModel $model): void
-    {
-        foreach ($this->fields as $field) {
-            if (!$model->dataHasChangedFor($field)) {
-                continue;
+            foreach ($this->fields as $field) {
+                if (!$model->dataHasChangedFor($field)) {
+                    continue;
+                }
+                $this->processor->execute(
+                    self::CONTENT_TYPE,
+                    $field,
+                    (string) $model->getId(),
+                    (string) $model->getData($field)
+                );
             }
-            $this->processor->execute(
-                self::CONTENT_TYPE,
-                $field,
-                (string) $model->getId(),
-                (string) $model->getData($field)
-            );
         }
     }
 }

app/code/Magento/MediaContentCatalog/Observer/Product.php

@@ -49,28 +49,19 @@ public function execute(Observer $observer): void
     {
         /** @var CatalogProduct $model */
         $model = $observer->getEvent()->getData('product');
-        if ($model instanceof AbstractModel) {
-            $this->updateRelations($model);
-        }
-    }
 
-    /**
-     * Update relations for the model
-     *
-     * @param AbstractModel $model
-     */
-    private function updateRelations(AbstractModel $model): void
-    {
-        foreach ($this->fields as $field) {
-            if (!$model->dataHasChangedFor($field)) {
-                continue;
+        if ($model instanceof AbstractModel) {
+            foreach ($this->fields as $field) {
+                if (!$model->dataHasChangedFor($field)) {
+                    continue;
+                }
+                $this->processor->execute(
+                    self::CONTENT_TYPE,
+                    $field,
+                    (string) $model->getId(),
+                    (string) $model->getData($field)
+                );
             }
-            $this->processor->execute(
-                self::CONTENT_TYPE,
-                $field,
-                (string) $model->getId(),
-                (string) $model->getData($field)
-            );
         }
     }
 }

app/code/Magento/MediaContentCms/Observer/Block.php

@@ -50,27 +50,17 @@ public function execute(Observer $observer): void
         /** @var CmsBlock $model */
         $model = $observer->getEvent()->getData('object');
         if ($model instanceof AbstractModel) {
-            $this->updateRelations($model);
-        }
-    }
-
-    /**
-     * Update relations for the model
-     *
-     * @param AbstractModel $model
-     */
-    private function updateRelations(AbstractModel $model): void
-    {
-        foreach ($this->fields as $field) {
-            if (!$model->dataHasChangedFor($field)) {
-                continue;
+            foreach ($this->fields as $field) {
+                if (!$model->dataHasChangedFor($field)) {
+                    continue;
+                }
+                $this->processor->execute(
+                    self::CONTENT_TYPE,
+                    $field,
+                    (string) $model->getId(),
+                    (string) $model->getData($field)
+                );
             }
-            $this->processor->execute(
-                self::CONTENT_TYPE,
-                $field,
-                (string) $model->getId(),
-                (string) $model->getData($field)
-            );
         }
     }
 }

app/code/Magento/MediaContentCms/Observer/Page.php

@@ -50,27 +50,17 @@ public function execute(Observer $observer): void
         /** @var CmsPage $model */
         $model = $observer->getEvent()->getData('object');
         if ($model instanceof AbstractModel) {
-            $this->updateRelations($model);
-        }
-    }
-
-    /**
-     * Update relations for the model
-     *
-     * @param AbstractModel $model
-     */
-    private function updateRelations(AbstractModel $model): void
-    {
-        foreach ($this->fields as $field) {
-            if (!$model->dataHasChangedFor($field)) {
-                continue;
+            foreach ($this->fields as $field) {
+                if (!$model->dataHasChangedFor($field)) {
+                    continue;
+                }
+                $this->processor->execute(
+                    self::CONTENT_TYPE,
+                    $field,
+                    (string) $model->getId(),
+                    (string) $model->getData($field)
+                );
             }
-            $this->processor->execute(
-                self::CONTENT_TYPE,
-                $field,
-                (string) $model->getId(),
-                (string) $model->getData($field)
-            );
         }
     }
 }