Code review suggestion, reemove deprecated onmousemove from ui-select component

Nazar65 · Nazar65 · commit 2534e462572b · 2020-08-05T17:03:13.000+03:00
diff --git a/app/code/Magento/MediaGalleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest.xml b/app/code/Magento/MediaGalleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest.xml
@@ -23,13 +23,13 @@
             <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
         </before>
         <after>
-        <actionGroup ref="AdminOpenStandaloneMediaGalleryActionGroup" stepKey="openMediaGallery"/>
-        <actionGroup ref="AdminEnhancedMediaGalleryEnableMassActionModeActionGroup" stepKey="enableMassActionToDeleteImages"/>
-        <actionGroup ref="AdminEnhancedMediaGallerySelectImageForMassActionActionGroup" stepKey="selectSecondImageToDelete">
-            <argument name="imageName" value="{{UpdatedImageDetails.title}}"/>
-        </actionGroup>
-        <actionGroup ref="AdminEnhancedMediaGalleryClickDeleteImagesButtonActionGroup" stepKey="clikDeleteSelectedButton"/>
-        <actionGroup ref="AdminEnhancedMediaGalleryConfirmDeleteImagesActionGroup" stepKey="deleteImages"/>
+            <actionGroup ref="AdminOpenStandaloneMediaGalleryActionGroup" stepKey="openMediaGallery"/>
+            <actionGroup ref="AdminEnhancedMediaGalleryEnableMassActionModeActionGroup" stepKey="enableMassActionToDeleteImages"/>
+            <actionGroup ref="AdminEnhancedMediaGallerySelectImageForMassActionActionGroup" stepKey="selectSecondImageToDelete">
+                <argument name="imageName" value="{{UpdatedImageDetails.title}}"/>
+            </actionGroup>
+            <actionGroup ref="AdminEnhancedMediaGalleryClickDeleteImagesButtonActionGroup" stepKey="clikDeleteSelectedButton"/>
+            <actionGroup ref="AdminEnhancedMediaGalleryConfirmDeleteImagesActionGroup" stepKey="deleteImages"/>
             <deleteData createDataKey="category" stepKey="deleteCategory"/>
         </after>
 
diff --git a/app/code/Magento/MediaGalleryCatalogUi/view/adminhtml/layout/media_gallery_catalog_category_index.xml b/app/code/Magento/MediaGalleryCatalogUi/view/adminhtml/layout/media_gallery_catalog_category_index.xml
@@ -10,11 +10,7 @@
     <body>
         <referenceContainer htmlTag="div" htmlClass="media-gallery-category-container" name="content">
             <uiComponent name="media_gallery_category_listing"/>
+            <block class="Magento\Backend\Block\Template" template="Magento_MediaGalleryCatalogUi::url_filter_applier.phtml" name="category_list_url_filter_applier"/>
         </referenceContainer>
-        <block class="Magento\Backend\Block\Template" template="Magento_Cms::url_filter_applier.phtml" name="category_list_url_filter_applier">
-            <arguments>
-                <argument name="listing_namespace" xsi:type="string">media_gallery_category_listing</argument>
-            </arguments>
-        </block>
     </body>
 </page>
diff --git a/app/code/Magento/MediaGalleryCatalogUi/view/adminhtml/templates/url_filter_applier.phtml b/app/code/Magento/MediaGalleryCatalogUi/view/adminhtml/templates/url_filter_applier.phtml
@@ -0,0 +1,18 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+/** @var $block \Magento\Backend\Block\Template */
+/** @var \Magento\Framework\Escaper $escaper */
+?>
+<script type="text/x-magento-init">
+    {
+        "*": {
+            "Magento_Ui/js/grid/url-filter-applier": {
+                "listingNamespace": "media_gallery_category_listing"
+            }
+        }
+    }
+</script>
diff --git a/app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js b/app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js
@@ -10,8 +10,7 @@ define([
     'uiLayout',
     'Magento_Ui/js/lib/key-codes',
     'Magento_MediaGalleryUi/js/action/getDetails',
-    'mage/validation',
-    'Magento_Ui/js/lib/view/utils/async'
+    'mage/validation'
 ], function ($, _, Component, layout, keyCodes, getDetails) {
     'use strict';
 
@@ -55,33 +54,9 @@ define([
         initialize: function () {
             this._super().initView();
 
-            this.removeMouseOverEvent();
-
             return this;
         },
 
-        /**
-         * Remove mousemove event from ui-select as it deprecated
-         */
-        removeMouseOverEvent: function () {
-
-            if (_.isUndefined(this.keywordsSelect())) {
-                setTimeout(function () {
-                    this.removeMouseOverEvent();
-                }.bind(this), 100);
-
-                return;
-            }
-
-            $.async(
-                this.keywordsSelect().rootListSelector,
-                function () {
-                    $(this.keywordsSelect().rootListSelector).off('mousemove');
-                }.bind(this)
-            );
-
-        },
-
         /**
          * Add a new keyword to select
          */
diff --git a/app/code/Magento/Ui/view/base/web/js/form/element/ui-select.js b/app/code/Magento/Ui/view/base/web/js/form/element/ui-select.js
@@ -748,11 +748,6 @@ define([
             return this.value() ? !!this.value().length : false;
         },
 
-        /**
-         * @deprecated
-         */
-        onMousemove: function () {},
-
         /**
          * Handles hover on list items.
          *
