MC-19791: Poor performance on sales order update - string to integer

Author: Oleksandr Iegorov

lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php

@@ -11,6 +11,7 @@
 use Magento\Framework\Model\ResourceModel\AbstractResource;
 use Magento\Framework\DB\Adapter\DuplicateException;
 use Magento\Framework\Phrase;
+use Magento\Framework\DB\Adapter\AdapterInterface;
 
 /**
  * Abstract resource model
@@ -301,7 +302,7 @@ public function getTable($tableName)
      * Get connection by resource name
      *
      * @param string $resourceName
-     * @return \Magento\Framework\DB\Adapter\AdapterInterface|false
+     * @return AdapterInterface|false
      */
     protected function _getConnection($resourceName)
     {
@@ -320,7 +321,7 @@ protected function _getConnection($resourceName)
     /**
      * Get connection
      *
-     * @return \Magento\Framework\DB\Adapter\AdapterInterface|false
+     * @return AdapterInterface|false
      */
     public function getConnection()
     {
@@ -793,13 +794,10 @@ protected function saveNewObject(\Magento\Framework\Model\AbstractModel $object)
      */
     protected function updateObject(\Magento\Framework\Model\AbstractModel $object)
     {
-        $tableDescription = $this->getConnection()
-            ->describeTable($this->getMainTable());
-        $preparedValue = $this->getConnection()
-            ->prepareColumnValue(
-                $tableDescription[$this->getIdFieldName()],
-                $object->getId()
-            );
+        /** @var AdapterInterface $connection */
+        $connection = $this->getConnection();
+        $tableDescription = $connection->describeTable($this->getMainTable());
+        $preparedValue = $connection->prepareColumnValue($tableDescription[$this->getIdFieldName()], $object->getId());
         $condition  = $this->getIdFieldName() . '=' . $preparedValue;
 
         /**
@@ -808,22 +806,22 @@ protected function updateObject(\Magento\Framework\Model\AbstractModel $object)
         if ($this->_isPkAutoIncrement) {
             $data = $this->prepareDataForUpdate($object);
             if (!empty($data)) {
-                $this->getConnection()->update($this->getMainTable(), $data, $condition);
+                $connection->update($this->getMainTable(), $data, $condition);
             }
         } else {
-            $select = $this->getConnection()->select()->from(
+            $select = $connection->select()->from(
                 $this->getMainTable(),
                 [$this->getIdFieldName()]
             )->where(
                 $condition
             );
-            if ($this->getConnection()->fetchOne($select) !== false) {
+            if ($connection->fetchOne($select) !== false) {
                 $data = $this->prepareDataForUpdate($object);
                 if (!empty($data)) {
-                    $this->getConnection()->update($this->getMainTable(), $data, $condition);
+                    $connection->update($this->getMainTable(), $data, $condition);
                 }
             } else {
-                $this->getConnection()->insert(
+                $connection->insert(
                     $this->getMainTable(),
                     $this->_prepareDataForSave($object)
                 );

lib/internal/Magento/Framework/Model/Test/Unit/ResourceModel/Db/AbstractDbTest.php

@@ -425,6 +425,7 @@ public function testPrepareDataForUpdate()
         $connectionMock = $this->getMockBuilder(AdapterInterface::class)
             ->setMethods(['save'])
             ->getMockForAbstractClass();
+
         $context = (new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this))->getObject(
             \Magento\Framework\Model\Context::class
         );
@@ -451,6 +452,7 @@ public function testPrepareDataForUpdate()
         $this->_resourcesMock->expects($this->any())->method('getTableName')->with($data)->will(
             $this->returnValue('tableName')
         );
+
         $mainTableReflection = new \ReflectionProperty(
             AbstractDb::class,
             '_mainTable'
@@ -465,6 +467,13 @@ public function testPrepareDataForUpdate()
         $idFieldNameReflection->setValue($this->_model, 'idFieldName');
         $connectionMock->expects($this->any())->method('save')->with('tableName', 'idFieldName');
         $connectionMock->expects($this->any())->method('quoteInto')->will($this->returnValue('idFieldName'));
+        $connectionMock->expects($this->any())
+            ->method('describeTable')
+            ->with('tableName')
+            ->willReturn(['idFieldName' => []]);
+        $connectionMock->expects($this->any())
+            ->method('prepareColumnValue')
+            ->willReturn(0);
         $abstractModelMock->setIdFieldName('id');
         $abstractModelMock->setData(
             [