ENGCOM-3525: correct param, var and return annotation values #19325

Author: sidolov

lib/internal/Magento/Framework/Acl/Loader/ResourceLoader.php

@@ -12,12 +12,15 @@
 use Magento\Framework\Acl\AclResource\ProviderInterface;
 use Magento\Framework\Acl\AclResourceFactory;
 
+/**
+ * ACL Loader
+ */
 class ResourceLoader implements \Magento\Framework\Acl\LoaderInterface
 {
     /**
      * Acl resource config
      *
-     * @var ProviderInterface $resourceProvider
+     * @var ProviderInterface
      */
     protected $_resourceProvider;
 

lib/internal/Magento/Framework/Amqp/Queue.php

@@ -37,7 +37,7 @@ class Queue implements QueueInterface
     private $envelopeFactory;
 
     /**
-     * @var LoggerInterface $logger
+     * @var LoggerInterface
      */
     private $logger;
 
@@ -63,7 +63,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      * @since 100.0.0
      */
     public function dequeue()
@@ -98,7 +98,7 @@ public function dequeue()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      * @since 100.0.0
      */
     public function acknowledge(EnvelopeInterface $envelope)
@@ -119,7 +119,7 @@ public function acknowledge(EnvelopeInterface $envelope)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      * @since 100.0.0
      */
     public function subscribe($callback)
@@ -153,7 +153,7 @@ public function subscribe($callback)
     }
 
     /**
-     * (@inheritdoc)
+     * @inheritdoc
      * @since 100.0.0
      */
     public function reject(EnvelopeInterface $envelope, $requeue = true, $rejectionMessage = null)
@@ -172,7 +172,7 @@ public function reject(EnvelopeInterface $envelope, $requeue = true, $rejectionM
     }
 
     /**
-     * (@inheritdoc)
+     * @inheritdoc
      * @since 100.0.0
      */
     public function push(EnvelopeInterface $envelope)

lib/internal/Magento/Framework/Api/SearchCriteria/CollectionProcessor/JoinProcessor.php

@@ -10,6 +10,9 @@
 use Magento\Framework\Api\SearchCriteriaInterface;
 use Magento\Framework\Data\Collection\AbstractDb;
 
+/**
+ * Search criteria join processor
+ */
 class JoinProcessor implements CollectionProcessorInterface
 {
     /**
@@ -28,7 +31,7 @@ class JoinProcessor implements CollectionProcessorInterface
     private $appliedFields = [];
 
     /**
-     * @param CustomJoinInterface[] $customFilters
+     * @param CustomJoinInterface[] $customJoins
      * @param array $fieldMapping
      */
     public function __construct(

lib/internal/Magento/Framework/Api/Test/Unit/ExtensionAttribute/Config/SchemaLocatorTest.php

@@ -15,7 +15,7 @@ class SchemaLocatorTest extends \PHPUnit\Framework\TestCase
      */
     protected $model;
 
-    /** @var \Magento\Framework\Config\Dom\UrnResolver $urnResolverMock */
+    /** @var \Magento\Framework\Config\Dom\UrnResolver */
     protected $urnResolver;
 
     protected function setUp()

lib/internal/Magento/Framework/App/ResourceConnection.php

@@ -11,7 +11,9 @@
 
 /**
  * Application provides ability to configure multiple connections to persistent storage.
+ *
  * This class provides access to all these connections.
+ *
  * @api
  */
 class ResourceConnection
@@ -53,7 +55,7 @@ class ResourceConnection
     protected $connectionFactory;
 
     /**
-     * @var DeploymentConfig $deploymentConfig
+     * @var DeploymentConfig
      */
     private $deploymentConfig;
 

lib/internal/Magento/Framework/App/Test/Unit/Request/HttpTest.php

@@ -246,8 +246,8 @@ public function testIsAjax()
     }
 
     /**
-     * @param $serverVariables array
-     * @param $expectedResult string
+     * @param array $serverVariables
+     * @param string $expectedResult
      * @dataProvider serverVariablesProvider
      */
     public function testGetDistroBaseUrl($serverVariables, $expectedResult)
@@ -374,7 +374,7 @@ public function testIsSecure($isSecure, $serverHttps, $headerOffloadKey, $header
     /**
      * @dataProvider httpSafeMethodProvider
      * @backupGlobals enabled
-     * @param string $method value of $_SERVER['REQUEST_METHOD']
+     * @param string $httpMethod value of $_SERVER['REQUEST_METHOD']
      */
     public function testIsSafeMethodTrue($httpMethod)
     {
@@ -386,7 +386,7 @@ public function testIsSafeMethodTrue($httpMethod)
     /**
      * @dataProvider httpNotSafeMethodProvider
      * @backupGlobals enabled
-     * @param string $method value of $_SERVER['REQUEST_METHOD']
+     * @param string $httpMethod value of $_SERVER['REQUEST_METHOD']
      */
     public function testIsSafeMethodFalse($httpMethod)
     {

lib/internal/Magento/Framework/App/Test/Unit/ResourceConnection/Config/SchemaLocatorTest.php

@@ -13,7 +13,7 @@ class SchemaLocatorTest extends \PHPUnit\Framework\TestCase
      */
     protected $model;
 
-    /** @var \Magento\Framework\Config\Dom\UrnResolver $urnResolverMock */
+    /** @var \Magento\Framework\Config\Dom\UrnResolver */
     protected $urnResolver;
 
     protected function setUp()

lib/internal/Magento/Framework/App/Test/Unit/Route/Config/SchemaLocatorTest.php

@@ -12,10 +12,10 @@ class SchemaLocatorTest extends \PHPUnit\Framework\TestCase
      */
     protected $config;
 
-    /** @var \Magento\Framework\Config\Dom\UrnResolver $urnResolverMock */
+    /** @var \Magento\Framework\Config\Dom\UrnResolver */
     protected $urnResolver;
 
-    /** @var \Magento\Framework\Config\Dom\UrnResolver $urnResolverMock */
+    /** @var \Magento\Framework\Config\Dom\UrnResolver */
     protected $urnResolverMock;
 
     protected function setUp()

lib/internal/Magento/Framework/App/Utility/Classes.php

@@ -9,6 +9,9 @@
 
 use Magento\Framework\Component\ComponentRegistrar;
 
+/**
+ * Utility for class names processing
+ */
 class Classes
 {
     /**
@@ -236,7 +239,7 @@ public static function getVirtualClasses()
     /**
      * Check if instance is virtual type
      *
-     * @param $className string
+     * @param string $className
      * @return bool
      */
     public static function isVirtual($className)

lib/internal/Magento/Framework/Cache/Test/Unit/Backend/Decorator/DecoratorAbstractTest.php

@@ -54,7 +54,7 @@ public function testConstructor()
     }
 
     /**
-     * @param array options
+     * @param array $options
      * @expectedException \Zend_Cache_Exception
      * @dataProvider constructorExceptionDataProvider
      */