Skip to content

Commit 2a84039

Browse files
committed
AC-15345: Undefined array key in ProductRepository getById
Fix for static test
1 parent af02add commit 2a84039

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

app/code/Magento/Review/Test/Unit/Block/FormTest.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,12 @@
99

1010
use Magento\Catalog\Api\Data\ProductInterface;
1111
use Magento\Catalog\Api\ProductRepositoryInterface;
12+
use Magento\Customer\Model\Url;
1213
use Magento\Framework\App\RequestInterface;
1314
use Magento\Framework\DataObject;
1415
use Magento\Framework\Serialize\Serializer\Json;
1516
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
17+
use Magento\Framework\Url\EncoderInterface;
1618
use Magento\Framework\UrlInterface;
1719
use Magento\Framework\View\Element\Template\Context;
1820
use Magento\Review\Block\Form;
@@ -258,7 +260,7 @@ public function testGetRegisterUrl(): void
258260
{
259261
$expectedUrl = 'https://example.com/customer/account/create/';
260262

261-
$customerUrl = $this->getMockBuilder(\Magento\Customer\Model\Url::class)
263+
$customerUrl = $this->getMockBuilder(Url::class)
262264
->disableOriginalConstructor()
263265
->onlyMethods(['getRegisterUrl'])
264266
->getMock();
@@ -290,14 +292,14 @@ public function testConstructSetsLoginLinkWhenGuestCannotWrite(): void
290292
return $currentUrl;
291293
}
292294
if ($route === 'customer/account/login/') {
293-
$this->assertArrayHasKey(\Magento\Customer\Model\Url::REFERER_QUERY_PARAM_NAME, $params);
294-
$this->assertSame($encoded, $params[\Magento\Customer\Model\Url::REFERER_QUERY_PARAM_NAME]);
295-
return $loginUrlBase . '?' . \Magento\Customer\Model\Url::REFERER_QUERY_PARAM_NAME . '=' . $encoded;
295+
$this->assertArrayHasKey(Url::REFERER_QUERY_PARAM_NAME, $params);
296+
$this->assertSame($encoded, $params[Url::REFERER_QUERY_PARAM_NAME]);
297+
return $loginUrlBase . '?' . Url::REFERER_QUERY_PARAM_NAME . '=' . $encoded;
296298
}
297299
return '';
298300
});
299301

300-
$urlEncoder = $this->createMock(\Magento\Framework\Url\EncoderInterface::class);
302+
$urlEncoder = $this->createMock(EncoderInterface::class);
301303
$urlEncoder->expects($this->once())
302304
->method('encode')
303305
->with($currentUrl . '#review-form')
@@ -326,7 +328,7 @@ public function testConstructSetsLoginLinkWhenGuestCannotWrite(): void
326328
$method->setAccessible(true);
327329
$method->invoke($formBlock);
328330

329-
$expectedLoginUrl = $loginUrlBase . '?' . \Magento\Customer\Model\Url::REFERER_QUERY_PARAM_NAME . '=' . $encoded;
331+
$expectedLoginUrl = $loginUrlBase . '?' . Url::REFERER_QUERY_PARAM_NAME . '=' . $encoded;
330332
$this->assertSame($expectedLoginUrl, $formBlock->getLoginLink());
331333
}
332334

0 commit comments

Comments
 (0)