MC-40053: Create automated test for: "Update attribute option by API call"

Author: ysapiga

dev/tests/api-functional/testsuite/Magento/Swatches/Api/ProductAttributeOptionManagementInterfaceTest.php

@@ -12,6 +12,7 @@
 use Magento\Eav\Api\Data\AttributeOptionInterface;
 use Magento\Eav\Api\Data\AttributeOptionLabelInterface;
 use Magento\Eav\Model\AttributeRepository;
+use Magento\Framework\DataObject;
 use Magento\Framework\Webapi\Rest\Request;
 use Magento\Swatches\Model\ResourceModel\Swatch\Collection;
 use Magento\Swatches\Model\ResourceModel\Swatch\CollectionFactory;
@@ -33,23 +34,23 @@ class ProductAttributeOptionManagementInterfaceTest extends WebapiAbstract
     /**
      * Test add option to swatch attribute
      *
+     * @dataProvider addDataProvider
      * @magentoApiDataFixture Magento/Catalog/Model/Product/Attribute/_files/select_attribute.php
      * @param array $data
      * @param array $payload
      * @param int $expectedSwatchType
      * @param string $expectedLabel
      * @param string $expectedValue
      *
-     * @dataProvider addDataProvider
+     * @return void
      */
     public function testAdd(
         array $data,
         array $payload,
         int $expectedSwatchType,
         string $expectedLabel,
         string $expectedValue
-    )
-    {
+    ): void {
         $objectManager = Bootstrap::getObjectManager();
         /** @var $attributeRepository AttributeRepository */
         $attributeRepository = $objectManager->get(AttributeRepository::class);
@@ -87,8 +88,9 @@ public function testAdd(
 
     /**
      * @magentoApiDataFixture Magento/Swatches/_files/text_swatch_attribute.php
+     * @return void
      */
-    public function testUpdate()
+    public function testUpdate(): void
     {
         $testAttributeCode = 'test_configurable';
         $optionData = [
@@ -115,7 +117,7 @@ public function testUpdate()
         $this->assertNotNull(
             $this->getAttributeOption(
                 $testAttributeCode,
-                $optionData[AttributeOptionLabelInterface::LABEL]
+                $optionData[AttributeOptionInterface::LABEL]
             )
         );
     }
@@ -124,7 +126,7 @@ public function testUpdate()
      * @return array
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
-    public function addDataProvider()
+    public function addDataProvider(): array
     {
         return [
             'visual swatch option with value' => [
@@ -249,14 +251,15 @@ public function addDataProvider()
      * Get swatch model
      *
      * @param int $optionId
-     * @return Swatch
+     * @return DataObject
      */
-    private function getSwatch(int $optionId)
+    private function getSwatch(int $optionId): DataObject
     {
         /** @var Collection $collection */
         $collection = Bootstrap::getObjectManager()->get(CollectionFactory::class)->create();
         $collection->addFieldToFilter('option_id', $optionId);
         $collection->setPageSize(1);
+
         return $collection->getFirstItem();
     }
 
@@ -300,6 +303,8 @@ private function webApiCallAttributeOptions(
     }
 
     /**
+     * Get Attribute options by attribute code
+     *
      * @param string $testAttributeCode
      * @param string|null $storeCode
      * @return array|bool|float|int|string
@@ -317,6 +322,8 @@ private function getAttributeOptions(string $testAttributeCode, ?string $storeCo
     }
 
     /**
+     * Get Attribute option by attribute code
+     *
      * @param string $attributeCode
      * @param string $optionLabel
      * @param string|null $storeCode
@@ -326,8 +333,7 @@ private function getAttributeOption(
         string $attributeCode,
         string $optionLabel,
         ?string $storeCode = null
-    ): ?array
-    {
+    ): ?array {
         $attributeOptions = $this->getAttributeOptions($attributeCode, $storeCode);
         $option = null;
         /** @var array $attributeOption */