Skip to content

Commit 2b10dd5

Browse files
committed
Fix static test failures
1 parent 993b014 commit 2b10dd5

File tree

10 files changed

+41
-25
lines changed

10 files changed

+41
-25
lines changed

app/code/Magento/Backup/Block/Adminhtml/Backup.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616
class Backup extends \Magento\Backend\Block\Template
1717
{
1818
/**
19-
* Block's template
20-
*
2119
* @var string
2220
*/
2321
protected $_template = 'Magento_Backup::backup/list.phtml';
2422

2523
/**
26-
* @return AbstractBlock|void
24+
* Prepare the layout
25+
*
26+
* @return void
2727
*/
2828
protected function _prepareLayout()
2929
{
@@ -61,6 +61,8 @@ protected function _prepareLayout()
6161
}
6262

6363
/**
64+
* Return HTML for the backups grid
65+
*
6466
* @return string
6567
*/
6668
public function getGridHtml()

app/code/Magento/Backup/Controller/Adminhtml/Index.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
/**
1313
* Backup admin controller
1414
*
15+
* @phpcs:ignore Magento2.Classes.AbstractApi.AbstractApi
1516
* @api
1617
* @since 100.0.2
1718
* @SuppressWarnings(PHPMD.AllPurposeAction)
@@ -23,11 +24,9 @@ abstract class Index extends Action
2324
*
2425
* @see _isAllowed()
2526
*/
26-
const ADMIN_RESOURCE = 'Magento_Backup::backup';
27+
public const ADMIN_RESOURCE = 'Magento_Backup::backup';
2728

2829
/**
29-
* Core registry
30-
*
3130
* @var \Magento\Framework\Registry
3231
*/
3332
protected $_coreRegistry = null;

app/code/Magento/Backup/Model/Config/Source/Type.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
class Type implements \Magento\Framework\Option\ArrayInterface
1515
{
1616
/**
17-
* Backup data
18-
*
1917
* @var \Magento\Backup\Helper\Data
2018
*/
2119
protected $_backupData = null;
@@ -29,7 +27,7 @@ public function __construct(\Magento\Backup\Helper\Data $backupData)
2927
}
3028

3129
/**
32-
* {@inheritdoc}
30+
* @inheritDoc
3331
*/
3432
public function toOptionArray()
3533
{

app/code/Magento/Backup/Model/Grid/Options.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
/**
8-
* Backup types option array
9-
*/
107
namespace Magento\Backup\Model\Grid;
118

129
/**
10+
* Backup types option array
11+
*
1312
* @api
1413
* @since 100.0.2
1514
*/
@@ -30,6 +29,7 @@ public function __construct(\Magento\Backup\Helper\Data $backupHelper)
3029

3130
/**
3231
* Return backup types array
32+
*
3333
* @return array
3434
*/
3535
public function toOptionArray()

app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes/Extend.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,14 @@
1212
class Extend extends \Magento\Catalog\Block\Adminhtml\Form\Renderer\Fieldset\Element
1313
{
1414
/**
15-
* Initialize block template
15+
* @var string
1616
*/
1717
private $template = 'Magento_Bundle::catalog/product/edit/tab/attributes/extend.phtml';
1818

19-
const DYNAMIC = 0;
20-
21-
const FIXED = 1;
19+
public const DYNAMIC = 0;
20+
public const FIXED = 1;
2221

2322
/**
24-
* Core registry
25-
*
2623
* @var \Magento\Framework\Registry
2724
*/
2825
protected $_coreRegistry = null;

app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes/Special.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
class Special extends \Magento\Catalog\Block\Adminhtml\Form\Renderer\Fieldset\Element
1212
{
1313
/**
14+
* Return the HTML for this element
15+
*
1416
* @return string
1517
*/
1618
public function getElementHtml()

app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle.php

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ class Bundle extends \Magento\Backend\Block\Widget implements \Magento\Backend\B
2121
protected $_template = 'Magento_Bundle::product/edit/bundle.phtml';
2222

2323
/**
24-
* Core registry
25-
*
2624
* @var \Magento\Framework\Registry
2725
*/
2826
protected $_coreRegistry = null;
@@ -42,6 +40,8 @@ public function __construct(
4240
}
4341

4442
/**
43+
* Return tab URL
44+
*
4545
* @return string
4646
*/
4747
public function getTabUrl()
@@ -50,6 +50,8 @@ public function getTabUrl()
5050
}
5151

5252
/**
53+
* Return tab CSS class
54+
*
5355
* @return string
5456
*/
5557
public function getTabClass()
@@ -98,6 +100,8 @@ public function isReadonly()
98100
}
99101

100102
/**
103+
* Return HTML for add button
104+
*
101105
* @return string
102106
*/
103107
public function getAddButtonHtml()
@@ -106,6 +110,8 @@ public function getAddButtonHtml()
106110
}
107111

108112
/**
113+
* Return HTML for options box
114+
*
109115
* @return string
110116
*/
111117
public function getOptionsBoxHtml()
@@ -114,6 +120,8 @@ public function getOptionsBoxHtml()
114120
}
115121

116122
/**
123+
* Return field suffix
124+
*
117125
* @return string
118126
*/
119127
public function getFieldSuffix()
@@ -122,6 +130,8 @@ public function getFieldSuffix()
122130
}
123131

124132
/**
133+
* Return product from core registry
134+
*
125135
* @return mixed
126136
*/
127137
public function getProduct()
@@ -130,6 +140,8 @@ public function getProduct()
130140
}
131141

132142
/**
143+
* Return tab label
144+
*
133145
* @return \Magento\Framework\Phrase
134146
*/
135147
public function getTabLabel()
@@ -138,6 +150,8 @@ public function getTabLabel()
138150
}
139151

140152
/**
153+
* Return tab title
154+
*
141155
* @return \Magento\Framework\Phrase
142156
*/
143157
public function getTabTitle()
@@ -146,6 +160,8 @@ public function getTabTitle()
146160
}
147161

148162
/**
163+
* Return true always
164+
*
149165
* @return bool
150166
*/
151167
public function canShowTab()
@@ -154,6 +170,8 @@ public function canShowTab()
154170
}
155171

156172
/**
173+
* Return false always
174+
*
157175
* @return bool
158176
*/
159177
public function isHidden()

app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option/Search.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ class Search extends \Magento\Backend\Block\Widget
1616
protected $_template = 'Magento_Bundle::product/edit/bundle/option/search.phtml';
1717

1818
/**
19+
* Initialise the block
20+
*
1921
* @return void
2022
*/
2123
protected function _construct()

app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Bundle/Option/Selection.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,11 @@ class Selection extends \Magento\Backend\Block\Widget
1616
protected $_template = 'Magento_Bundle::product/edit/bundle/option/selection.phtml';
1717

1818
/**
19-
* Catalog data
20-
*
2119
* @var \Magento\Catalog\Helper\Data
2220
*/
2321
protected $_catalogData = null;
2422

2523
/**
26-
* Core registry
27-
*
2824
* @var \Magento\Framework\Registry
2925
*/
3026
protected $_coreRegistry = null;

app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ class Tabs extends \Magento\Catalog\Block\Adminhtml\Product\Edit\Tabs
1616
protected $_attributeTabBlock = \Magento\Bundle\Block\Adminhtml\Catalog\Product\Edit\Tab\Attributes::class;
1717

1818
/**
19-
* @return $this|void
19+
* Prepare the layout
20+
*
21+
* @return void
2022
*/
2123
protected function _prepareLayout()
2224
{

0 commit comments

Comments
 (0)