Added @param, private, : bool

sedonik · sedonik · commit 2b120366d59a · 2019-08-09T22:23:13.000+03:00
diff --git a/app/code/Magento/Newsletter/Model/Config.php b/app/code/Magento/Newsletter/Model/Config.php
@@ -17,7 +17,7 @@ class Config
     /**
      * Configuration path to newsletter active setting
      */
-    const XML_PATH_NEWSLETTER_ACTIVE = 'newsletter/general/active';
+    private const XML_PATH_NEWSLETTER_ACTIVE = 'newsletter/general/active';
 
     /**
      * @var ScopeConfigInterface
@@ -38,9 +38,10 @@ public function __construct(
     /**
      * Returns newsletter's enabled status
      *
+     * @param string $scopeType
      * @return bool
      */
-    public function isActive($scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT)
+    public function isActive($scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT): bool
     {
         return $this->scopeConfig->isSetFlag(self::XML_PATH_NEWSLETTER_ACTIVE, $scopeType);
     }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ class Config`
`17`	`17`	`/**`
`18`	`18`	`* Configuration path to newsletter active setting`
`19`	`19`	`*/`
`20`		`- const XML_PATH_NEWSLETTER_ACTIVE = 'newsletter/general/active';`
	`20`	`+ private const XML_PATH_NEWSLETTER_ACTIVE = 'newsletter/general/active';`
`21`	`21`
`22`	`22`	`/**`
`23`	`23`	`* @var ScopeConfigInterface`
`@@ -38,9 +38,10 @@ public function __construct(`
`38`	`38`	`/**`
`39`	`39`	`* Returns newsletter's enabled status`
`40`	`40`	`*`
	`41`	`+ * @param string $scopeType`
`41`	`42`	`* @return bool`
`42`	`43`	`*/`
`43`		`- public function isActive($scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT)`
	`44`	`+ public function isActive($scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT): bool`
`44`	`45`	`{`
`45`	`46`	`return $this->scopeConfig->isSetFlag(self::XML_PATH_NEWSLETTER_ACTIVE, $scopeType);`
`46`	`47`	`}`