WIP: BUG#AC-901: Cant install Magento in interactive mode

Author: glo80326

app/code/Magento/Config/Setup/ConfigOptionsList.php

@@ -61,14 +61,14 @@ public function getOptions()
             new SelectConfigOption(
                 self::INPUT_KEY_DEBUG_LOGGING,
                 SelectConfigOption::FRONTEND_WIZARD_RADIO,
-                [true, false, 1, 0],
+                ['true', 'false', 1, 0],
                 self::CONFIG_PATH_DEBUG_LOGGING,
                 'Enable debug logging'
             ),
             new SelectConfigOption(
                 self::INPUT_KEY_SYSLOG_LOGGING,
                 SelectConfigOption::FRONTEND_WIZARD_RADIO,
-                [true, false, 1, 0],
+                ['true', 'false', 1, 0],
                 self::CONFIG_PATH_SYSLOG_LOGGING,
                 'Enable syslog logging'
             ),

setup/src/Magento/Setup/Console/Command/InstallCommand.php

@@ -116,6 +116,11 @@ class InstallCommand extends AbstractSetupCommand
      */
     protected $searchConfigOptionsList;
 
+    /**
+     * @var array
+     */
+    protected $interactiveSetupUserInput;
+
     /**
      * Constructor
      *
@@ -228,7 +233,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
     {
         $consoleLogger = new ConsoleLogger($output);
         $installer = $this->installerFactory->create($consoleLogger);
-        $installer->install($input->getOptions());
+        $isInteractiveSetup = $input->getOption(self::INPUT_KEY_INTERACTIVE_SETUP) ?? false;
+        $installer->install($isInteractiveSetup ? $this->interactiveSetupUserInput : $input->getOptions());
 
         $importConfigCommand = $this->getApplication()->find(ConfigImportCommand::COMMAND_NAME);
         $arrayInput = new ArrayInput([]);
@@ -260,6 +266,7 @@ protected function initialize(InputInterface $input, OutputInterface $output)
                 $command .= " --{$key}={$value}";
             }
             $output->writeln("<comment>Try re-running command: php bin/magento setup:install{$command}</comment>");
+            $this->interactiveSetupUserInput = $configOptionsToValidate;
         }
 
         $errors = $this->configModel->validate($configOptionsToValidate);
@@ -409,7 +416,7 @@ private function askQuestion(
             if ($answer == null) {
                 $answer = '';
             } else {
-                $answer = trim($answer);
+                $answer = is_string($answer) ? trim($answer) : $answer;
             }
 
             if ($validateInline) {

setup/src/Magento/Setup/Model/ConfigModel.php

@@ -134,9 +134,12 @@ public function validate(array $inputOptions)
         $options = $this->getAvailableOptions();
         foreach ($options as $option) {
             try {
-                if ($inputOptions[$option->getName()] !== null) {
-                    $option->validate($inputOptions[$option->getName()]);
+                $inputValue = $inputOptions[$option->getName()] ?? null;
+
+                if ($inputValue !== null) {
+                    $option->validate($inputValue);
                 }
+
             } catch (\InvalidArgumentException $e) {
                 $errors[] = $e->getMessage();
             }

setup/src/Magento/Setup/Model/ConfigOptionsList.php

@@ -252,7 +252,7 @@ public function validate(array $options, DeploymentConfig $deploymentConfig)
             $errors[] = $this->validateDbPrefix($options[ConfigOptionsListConstants::INPUT_KEY_DB_PREFIX]);
         }
 
-        if (!$options[ConfigOptionsListConstants::INPUT_KEY_SKIP_DB_VALIDATION]) {
+        if ($options[ConfigOptionsListConstants::INPUT_KEY_SKIP_DB_VALIDATION] ?? false) {
             $errors[] = $this->validateDbSettings($options, $deploymentConfig);
         }